Func pack fix #4462
Open
Func pack fix #4462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.abi_tag = parts[start_idx + 1] | ||
| self.platform_tag = parts[start_idx + 2] | ||
|
|
||
| def install(self, paths, maker): |
There was a problem hiding this comment.
Where are we calling this install method?
| cmd = [ | ||
| 'pip', 'download', '--no-deps', '--only-binary', ':all:', | ||
| '--platform', _platform_map.get(args.platform), | ||
| sys.executable, '-m', 'pip', 'download', '--no-deps', '--only-binary', ':all:', |
There was a problem hiding this comment.
I did not follow why we added sys.executable here? and why we removed line 162?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR removes the dependency on 'distlib
from theFunc pack` process. Replaced with native python libraries.Tests Performed:
Ran:
func pack --output testresolves #issue_for_this_pr
Pull request checklist