Update LibAppIndicator in V4 to libayatana-appindicator #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CooperLink
requested review from
anirudhgarg,
vrdmr,
divyagandhisethi,
balag0,
pragnagopa and
ahmelsayed
as code owners
|
Hi @CooperLink , thanks for addressing this issue! I've noticed the lines where the dependencies are installed are still commented out. |
pragnagopa
reviewed
Jul 21, 2022
| @@ -20,7 +20,7 @@ RUN apt-get update && \ | |||
| # libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 \ | |||
| # libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 \ | |||
| # libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 \ | |||
| # libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget | |||
| # libxtst6 ca-certificates fonts-liberation libayatana-appindicator3-1 libnss3 lsb-release xdg-utils wget | |||
There was a problem hiding this comment.
code is still commented. Also, lets add this library on need basis - not all languages / Cx scenarios need it.
Lets go ahead and add to node and dotnet images only. Lets see if Cx ask for python and dotnet-isolated
pragnagopa
requested changes
Jul 21, 2022
4 tasks
4 tasks
|
made a PR with an uncommented version of the changes. #755. the builds fail, I'm not quite sure why though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#333 identified that LibAppIndicator is deprecated in Bullseye Debian and needs to be replaced with a supported library. This library needs to be updated to support Chrome Headless.
This PR is building off of the work of @nyds https://github.com/Azure/azure-functions-docker/pull/738/files
Link to Debian Bug Discussion : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895037
PR information