Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions src/DotNetWorker.Core/FunctionsApplication.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,23 @@ public void LoadFunction(FunctionDefinition definition)

public async Task InvokeFunctionAsync(FunctionContext context)
{
// This will act as an internal activity that represents remote Host activity. This cannot be tracked as this is not associate to an ActivitySource.
using Activity activity = new Activity(nameof(InvokeFunctionAsync));
activity.Start();
Activity? activity = null;

if (ActivityContext.TryParse(context.TraceContext.TraceParent, context.TraceContext.TraceState, true, out ActivityContext activityContext))
if (Activity.Current is null)
{
activity.SetId(context.TraceContext.TraceParent);
activity.SetSpanId(activityContext.SpanId.ToString());
activity.SetTraceId(activityContext.TraceId.ToString());
activity.SetRootId(activityContext.TraceId.ToString());
activity.ActivityTraceFlags = activityContext.TraceFlags;
activity.TraceStateString = activityContext.TraceState;
// This will act as an internal activity that represents remote Host activity. This cannot be tracked as this is not associate to an ActivitySource.
activity = new Activity(nameof(InvokeFunctionAsync));
activity.Start();

if (ActivityContext.TryParse(context.TraceContext.TraceParent, context.TraceContext.TraceState, true, out ActivityContext activityContext))
{
activity.SetId(context.TraceContext.TraceParent);
activity.SetSpanId(activityContext.SpanId.ToString());
activity.SetTraceId(activityContext.TraceId.ToString());
activity.SetRootId(activityContext.TraceId.ToString());
activity.ActivityTraceFlags = activityContext.TraceFlags;
activity.TraceStateString = activityContext.TraceState;
}
}

var scope = new FunctionInvocationScope(context.FunctionDefinition.Name, context.InvocationId);
Expand All @@ -98,6 +103,9 @@ public async Task InvokeFunctionAsync(FunctionContext context)

throw;
}

invokeActivity?.Stop();
activity?.Stop();
}
}
}
18 changes: 18 additions & 0 deletions test/DotNetWorker.OpenTelemetry.Tests/EndToEndTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,24 @@ public async Task ContextPropagation()
}
}

[Fact]
public async Task ContextPropagationWithTriggerInstrumentation()
{
using var host = InitializeHost();
var context = CreateContext(host);
using Activity testActivity = new Activity("ASPNetCoreMockActivity");
testActivity.Start();
await _application.InvokeFunctionAsync(context);
var activity = OtelFunctionDefinition.LastActivity;

Assert.Equal(activity.Id, testActivity.Id);
Assert.Equal(activity.OperationName, testActivity.OperationName);
Assert.Equal(activity.SpanId, testActivity.SpanId);
Assert.Equal(activity.TraceId, testActivity.TraceId);
Assert.Equal(activity.ActivityTraceFlags, testActivity.ActivityTraceFlags);
Assert.Equal(activity.TraceStateString, testActivity.TraceStateString);
}

[Fact]
public void ResourceDetectorLocalDevelopment()
{
Expand Down
Loading