Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Oct 28, 2025

Issue describing the changes in this PR

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Quick engineering work to remove out of support SDKs and consolidate to a single global.json

Copilot AI review requested due to automatic review settings October 28, 2025 16:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates .NET SDK versions by removing out-of-support SDKs (net6.0 and net7.0) and standardizing on net8.0. The changes remove a redundant global.json file and update the test project to target net8.0.

  • Updated Worker.ApplicationInsights.Tests project from net6.0 to net8.0
  • Removed duplicate global.json file from FunctionsNetHost directory
  • Simplified build pipeline to install only net8.0 SDK instead of net6.0 and net7.0

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/Worker.ApplicationInsights.Tests/Worker.ApplicationInsights.Tests.csproj Updated target framework to net8.0 and simplified xunit.runner.visualstudio package reference
host/src/FunctionsNetHost/global.json Removed redundant global.json file
build/install-dotnet.yml Removed net6.0 and net7.0 SDK installation steps, keeping only net8.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau merged commit 37f9796 into main Oct 29, 2025
68 checks passed
@jviau jviau deleted the u/jviau/net-sdk-updates branch October 29, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants