Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Nov 4, 2025

Issue describing the changes in this PR

resolves #3137

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Ports the func run targets from the existing SDK. Includes a minor tweak of using the FuncSdkLog task to error out the target if the func CLI is not found.

Regarding Tests

Unfortunately, it is not possible to add stable tests for this target. We cannot control the Exec task, and so cannot stub out if func CLI is found or not.

Copilot AI review requested due to automatic review settings November 4, 2025 00:27
@jviau jviau changed the title Support dotnet run in new msbuild sdk [MSBUILD SDK] Support dotnet run in new msbuild sdk Nov 4, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for running Azure Functions projects using dotnet run by configuring MSBuild to invoke the Azure Functions Core Tools (func start). The changes also include a minor cleanup of an empty line in a test file.

  • Adds MSBuild targets to check for Core Tools availability and configure run arguments
  • Sets up platform-specific command execution (Windows via cmd, Unix/Linux/macOS via func directly)
  • Removes an empty line from a test utilities file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Azure.Functions.Sdk/Targets/Azure.Functions.Sdk.targets Adds _FunctionsCheckForCoreTools and _FunctionsComputeRunArguments targets to enable dotnet run support for Functions projects
test/Azure.Functions.Sdk.Tests/Integration/MSBuildExtensions.cs Removes an empty line between methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau merged commit f2e03be into feature/msbuild-sdk Nov 11, 2025
34 checks passed
@jviau jviau deleted the jviau/msbuild-sdk/run branch November 11, 2025 18:28
jviau added a commit that referenced this pull request Nov 18, 2025
* Support dotnet run in new msbuild sdk

* EchoOff=true

* update run impl
jviau added a commit that referenced this pull request Nov 19, 2025
* Support dotnet run in new msbuild sdk

* EchoOff=true

* update run impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants