-
Notifications
You must be signed in to change notification settings - Fork 201
[SourceGen] Fix for duplicate properties generated #3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses an issue where binding properties with default values could create duplicate entries when named arguments differ only in casing. The fix implements case-insensitive key comparison to prevent duplicates.
- Updates multiple Azure Functions Worker Extension packages to newer versions
- Removes CosmosDB extension dependency and adds MCP extension support
- Implements case-insensitive duplicate key detection in attribute property parsing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Sdk.Generator.Tests/Sdk.Generator.Tests.csproj | Updates package references to newer versions, removes CosmosDB extension, adds MCP extension |
| test/Sdk.Generator.Tests/FunctionMetadataProvider/RetryOptionsTests.cs | Removes CosmosDB extension assembly reference from test setup |
| test/Sdk.Generator.Tests/FunctionMetadataProvider/BindingPropertiesTests.cs | Adds new test to verify no duplicate binding properties are created when default values exist |
| sdk/Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs | Implements case-insensitive duplicate key detection when processing attribute named arguments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/Sdk.Generator.Tests/FunctionMetadataProvider/BindingPropertiesParsingTests.cs
Show resolved
Hide resolved
sdk/FunctionMetadataLoaderExtension/FunctionMetadataLoaderExtension.csproj
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
liliankasem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend undoing package change
Issue describing the changes in this PR
resolves #3203
Pull request checklist
release_notes.mdAdditional Information
The core part of the change is changing the casing of the case sensitivity of the dictionary that collections binding attribute properties (
isRequiredandIsRequiredare not treated differently).