Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Nov 18, 2025

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR relocates some test resources to be all contained under the /tests/resources folder, to keep them separate from actual test projects.

Copilot AI review requested due to automatic review settings November 18, 2025 22:50
Copilot finished reviewing on behalf of jviau November 18, 2025 22:52
@jviau jviau changed the title Move test resource projects under tests/resources [Eng] Move test resource projects under tests/resources Nov 18, 2025
@jviau jviau added the area: engineering Engineering improvements label Nov 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes test resource projects by relocating them from the root test/ directory into a new test/Resources/ subdirectory structure, specifically under test/Resources/Extensions/ and test/Resources/Projects/. Additionally, the PR updates test dependencies in one test project to more recent versions.

  • Moved sample extension projects to test/Resources/Extensions/
  • Moved dependent assembly test projects to test/Resources/Projects/
  • Updated test package references in Worker.ApplicationInsights.Tests to latest versions (Microsoft.NET.Test.Sdk 17.11.1, Moq 4.20.71, xunit 2.9.0, xunit.runner.visualstudio 2.8.2)

Reviewed Changes

Copilot reviewed 5 out of 75 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/Worker.ApplicationInsights.Tests/Worker.ApplicationInsights.Tests.csproj Updates test package dependencies to current versions used across the solution
test/Sdk.Generator.Tests/Sdk.Generator.Tests.csproj Updates project references to point to new resource locations under test/Resources/
test/Resources/Projects/DependentAssemblyWithFunctions/*.cs New location for test project source files with Azure Functions samples
test/Resources/Projects/DependentAssemblyWithFunctions/*.csproj Project files for test resources moved from root test directory
test/Resources/Projects/DependentAssemblyWithFunctions.NetStandard/*.cs NetStandard test project sources relocated to Resources folder
test/Resources/Projects/DependentAssemblyWithFunctions.NetStandard/*.csproj NetStandard test project configuration relocated to Resources folder
test/Resources/Extensions/Worker.Extensions.Sample/*.cs Sample extension implementation moved to organized Resources structure
test/Resources/Extensions/Worker.Extensions.Sample/*.csproj Sample extension project file relocated with incorrect project reference path
test/Resources/Extensions/Worker.Extensions.Sample-IncorrectImplementation/*.cs Intentionally incorrect extension sample moved to Resources folder
test/Resources/Extensions/Worker.Extensions.Sample-IncorrectImplementation/*.csproj Project file for incorrect implementation sample with invalid project reference
DotNetWorker.sln Updates solution file structure to reflect new resource organization under a dedicated solution folder
Comments suppressed due to low confidence (2)

test/Resources/Extensions/Worker.Extensions.Sample/Worker.Extensions.Sample.csproj:8

  • The project reference path is incorrect. From test/Resources/Extensions/Worker.Extensions.Sample/, the relative path ..\..\src\ only goes up 2 levels to test/Resources/, not to the repository root. The correct path should be ..\..\..\..\src\DotNetWorker.Core\DotNetWorker.Core.csproj to properly reference the source project.
    test/Resources/Extensions/Worker.Extensions.Sample-IncorrectImplementation/Worker.Extensions.Sample-IncorrectImplementation.csproj:8
  • The project reference path is incorrect. From test/Resources/Extensions/Worker.Extensions.Sample-IncorrectImplementation/, the relative path ..\..\src\ only goes up 2 levels to test/Resources/, not to the repository root. The correct path should be ..\..\..\..\src\DotNetWorker.Core\DotNetWorker.Core.csproj to properly reference the source project.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau merged commit 11143ec into main Nov 20, 2025
28 checks passed
@jviau jviau deleted the u/jviau/eng/move-test-resources branch November 20, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: engineering Engineering improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants