Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Nov 19, 2025

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

The update to .net10 packages and sdk introduced many build warnings. This PR addresses/suppresses them.

Copilot AI review requested due to automatic review settings November 19, 2025 18:35
Copilot finished reviewing on behalf of jviau November 19, 2025 18:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses build warnings introduced by the .NET 10 SDK and package updates by adding missing copyright headers to test files and suppressing specific build warnings related to assembly strong naming and deprecated target framework monikers.

  • Added copyright headers to 6 test files in the Sdk.Analyzers.Tests project
  • Suppressed CS8002 (assembly strong name) warning in Sdk.Analyzers.Tests project
  • Suppressed TFM support warnings for legacy net6.0/net7.0 frameworks to avoid breaking changes

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Directory.Build.props Added property to suppress TFM support warnings for legacy .NET 6.0/7.0 frameworks
test/Sdk.Analyzers.Tests/Sdk.Analyzers.Tests.csproj Added CS8002 warning suppression for assembly strong name issues
test/Sdk.Analyzers.Tests/WebJobsAttributesNotSupportedTests.cs Added missing copyright header
test/Sdk.Analyzers.Tests/IterableBindingTypeExpectedForBlobContainerPathTests.cs Added missing copyright header
test/Sdk.Analyzers.Tests/DeferredBindingAttributeNotSupportedTests.cs Added missing copyright header
test/Sdk.Analyzers.Tests/BindingTypeNotSupportedTests.cs Added missing copyright header
test/Sdk.Analyzers.Tests/BindingTypeCodeRefactoringProviderTests.cs Added missing copyright header
test/Sdk.Analyzers.Tests/AsyncVoidAnalyzerTests.cs Added missing copyright header

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau merged commit f84a238 into main Nov 19, 2025
34 checks passed
@jviau jviau deleted the u/jviau/fix-warnings branch November 19, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants