Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Nov 19, 2025

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Migrates Azure.Functions.Sdk to use the new C#14 extensions syntax.

https://devblogs.microsoft.com/dotnet/csharp-exploring-extension-members/

Copilot AI review requested due to automatic review settings November 19, 2025 23:36
Copilot finished reviewing on behalf of jviau November 19, 2025 23:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Azure.Functions.Sdk MSBuild project to use C# 14's new extension syntax, which allows extension methods to be defined more intuitively within extension blocks rather than as static methods in static classes.

Key changes:

  • Refactored extension methods from traditional static syntax to C# 14 extension(Type) blocks
  • Consolidated helper methods (e.g., Read methods in LockFileExtensions) that were previously scattered
  • Removed unused test utility method (WriteNugetConfig)

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
MSBuildExtensions.cs Converted static extension methods to C# 14 extension syntax for ProjectCreatorTemplates and ProjectCreator
MSBuildLogExtensions.cs Converted static extension methods to C# 14 extension syntax for TaskLoggingHelper with private helper methods
TaskItemExtensions.cs Converted static extension methods to C# 14 extension syntax for ITaskItem
LockFileExtensions.cs Converted to C# 14 extension syntax and added new static helper methods for reading lock files
ExceptionExtensions.cs Converted static extension methods to C# 14 extension syntax for Exception
ResolveExtensionPackages.cs Updated to use new LockFile.Read helper method
TempDirectory.cs Removed unused WriteNugetConfig method
ResolveExtensionPackagesTests.cs Removed call to deleted WriteNugetConfig method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau requested a review from Copilot November 20, 2025 19:05
Copilot finished reviewing on behalf of jviau November 20, 2025 19:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jviau jviau requested a review from Copilot November 20, 2025 19:38
Copilot finished reviewing on behalf of jviau November 20, 2025 19:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Conflicts:
#	test/Azure.Functions.Sdk.Tests/ProjectCreatorExtensions.cs
@jviau jviau merged commit 45cea69 into feature/msbuild-sdk Nov 20, 2025
28 checks passed
@jviau jviau deleted the jviau/msbuild-sdk/extensions branch November 20, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants