This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Add Azure Function App support with list command#863
Merged
Conversation
…ion App management instructions
…pected function app list
…trings from bicep
colbytimm
requested review from
KarishmaGhiya,
g2vinay,
hallipr,
jongio,
joshfree,
sandeep-sen and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Azure Function App support to the Azure MCP server, adding a list command to enumerate function apps within a subscription. The implementation follows the established patterns used by other Azure services in the codebase.
Key changes:
- New Function App area with complete list functionality
- Integration tests and unit tests with proper test infrastructure
- Documentation updates including README and command reference
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/src/AzureMcp.Cli/Program.cs | Registers the new FunctionAppSetup area |
| areas/functionApp/src/AzureMcp.FunctionApp/* | Complete Function App implementation with service, commands, models, and options |
| areas/functionApp/tests/* | Comprehensive unit and live test coverage with Bicep test resources |
| docs/azmcp-commands.md | Documentation for the new functionapp list command |
| e2eTests/e2eTestPrompts.md | Test prompts for the new Function App functionality |
| README.md | Updated service table to include Function App |
| Directory.Packages.props | Added Azure.ResourceManager.AppService package |
| AzureMcp.sln | Solution file updates for new projects |
| .vscode/cspell.json | Spelling dictionary updates for Function App terms |
| .github/CODEOWNERS | Code ownership for Function App area |
Comments suppressed due to low confidence (3)
areas/functionApp/src/AzureMcp.FunctionApp/Models/FunctionApp.cs:6
- The class name 'FunctionAppModel' is inconsistent with the file name 'FunctionApp.cs'. Either rename the file to 'FunctionAppModel.cs' or rename the class to 'FunctionApp'.
public class FunctionAppModel
areas/functionApp/tests/test-resources.bicep:138
- The API version '2018-01-01-preview' for roleDefinitions is outdated. Consider using a more recent stable version like '2022-04-01'.
resource websiteContributorRoleDefinition 'Microsoft.Authorization/roleDefinitions@2018-01-01-preview' existing = {
areas/functionApp/tests/test-resources.bicep:157
- The API version '2018-01-01-preview' for roleDefinitions is outdated. Consider using a more recent stable version like '2022-04-01'.
resource blobContributorRoleDefinition 'Microsoft.Authorization/roleDefinitions@2018-01-01-preview' existing = {
Contributor
Author
|
@microsoft-github-policy-service agree |
…ride ToolMetadata instead of using the attributes on ExecuteAsync.
Member
|
/azp run azure - mcp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
We had a CI system change late last week. Let me rerun and to make sure we're good. Thanks |
jongio
approved these changes
Aug 11, 2025
Contributor
Author
|
@jongio Looks like we will need another approver |
…end SubscriptionOptions for the list options.
… FunctionAppListOptions to include necessary using directive.
colbytimm
commented
Aug 12, 2025
colbytimm
left a comment
colbytimm
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @alzimmermsft. Made some updates based on your feedback.
alzimmermsft
approved these changes
Aug 12, 2025
conniey
reviewed
Aug 12, 2025
conniey
approved these changes
Aug 13, 2025
Member
|
/azp run azure - mcp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-project-automation
Bot
moved this from In Progress
to Done
in Azure MCP Server (OLD)
Member
|
Why did we call the new command group |
Contributor
Author
|
@joshfree Fair point. Looking at MS docs (example: https://learn.microsoft.com/en-us/azure/azure-functions/functions-overview) they reference them as |
Contributor
Author
|
@joshfree Thinking about it more...maybe functionapp makes sense because the functionapp is the container for your functions. So functionapp is the parent level and therefore the root command group. |
chidozieononiwu
pushed a commit
to chidozieononiwu/azure-mcp
that referenced
this pull request
Aug 18, 2025
* Add custom words for function app to cspell configuration * Scaffold and setup Function app with list command * Add test setup bicep * Add unit tests for list command * Add live tests * Add Azure Function App operations and test prompts * Add "azurewebsites" to cspell dictionary and update README with Function App management instructions * Fix formatting * Remove unnecessary comments * Update FunctionAppListCommandTests to include ResourceGroupName in expected function app list * Update codeowners * Add additional test prompt for azmcp-aks-functionapp-list in e2eTestPrompts.md * Fix typo for function app e2e tests * Add additional words to cspell configuration for content connection strings from bicep * Update FunctionAppListCommand to inherit BaseFunctionAppCommand. Override ToolMetadata instead of using the attributes on ExecuteAsync. * Update subscription parameter name. Update cacheKey to remove unnecessary cache key type. * Update changelog to include function app list command * Rename areas directory to `functionapp` * Remove duplicate * Fix casing in function app directory paths in solution file * Update .github/CODEOWNERS * Update .github/CODEOWNERS * Update .github/CODEOWNERS * Update .github/CODEOWNERS * Remove base function app options since they are not necessary and extend SubscriptionOptions for the list options. * Remove option definition as it's not necessary for the list command. * Update command group description to align with other areas. * Refactor BaseFunctionAppCommand to use SubscriptionOptions and update FunctionAppListOptions to include necessary using directive. * Update FunctionApp to be record and update references and unit tests. * Remove SubscriptionId from FunctionAppInfo and update related tests * Refactor FunctionAppInfo to include JsonPropertyName attributes for serialization * Update Azure.ResourceManager.AppService package version to 1.4.1 * Remove telemetry tag based on consolidation change in Azure#935 --------- Co-authored-by: Jon Gallant <2163001+jongio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sample run
GitHub issue number?
Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/e2eTests/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline