Lua evaluator - take 1#1113
Merged
Merged
Conversation
wupeka
force-pushed
the
wupeka/lua-evaluator
branch
from
a99fd29 to
c7256c8
Compare
Test Results 18 files 912 suites 15m 17s ⏱️ Results for commit 6ef3e5d. ♻️ This comment has been updated with latest results. |
robertwoj-microsoft
left a comment
robertwoj-microsoft
left a comment
Contributor
There was a problem hiding this comment.
In general this looks awesome :) I was thinking whether we could do some additional features. For example exposing iterators (PasswdIterator, ShellsIterator, UsersIterator, etc), so that we could offload some straightforward functionality to Lua instead of needing to reimplement this in C++ for single rules (see this, this or that).
wupeka
force-pushed
the
wupeka/lua-evaluator
branch
3 times, most recently
from
83fbebf to
bb5f2f3
Compare
wupeka
force-pushed
the
wupeka/lua-evaluator
branch
from
e8f1466 to
ab98c20
Compare
robertwoj-microsoft
left a comment
robertwoj-microsoft
left a comment
Contributor
There was a problem hiding this comment.
Please a module test to verify whether the evaluator class picks it up properly.
robertwoj-microsoft
approved these changes
Sep 2, 2025
simonjaeger
reviewed
Sep 2, 2025
simonjaeger
reviewed
Sep 2, 2025
AhmedBM
reviewed
Sep 2, 2025
AhmedBM
reviewed
Sep 3, 2025
AhmedBM
reviewed
Sep 3, 2025
Co-authored-by: Robert Wojciechowski <robertwoj@microsoft.com>
wupeka
force-pushed
the
wupeka/lua-evaluator
branch
2 times, most recently
from
e2e516a to
718d899
Compare
- More verbose logging
wupeka
force-pushed
the
wupeka/lua-evaluator
branch
from
718d899 to
6ef3e5d
Compare
robertwoj-microsoft
approved these changes
Sep 3, 2025
MariusNi
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Lua evaluator - take 1 * Ignore git version in vcpkg, needed for rhel7 et consortes.
MariusNi
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Lua evaluator - take 1 * Ignore git version in vcpkg, needed for rhel7 et consortes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Basic implementation of LUA evaluator for ComplianceEngine
Checklist
devbranch prior to this PR submission.devbranch.