Skip to content

Comments

Telemetry and dependency cleanup#1206

Merged
AhmedBM merged 16 commits intodevfrom
ahbenmes/telemetry_devbranch_ci_cleanup
Nov 20, 2025
Merged

Telemetry and dependency cleanup#1206
AhmedBM merged 16 commits intodevfrom
ahbenmes/telemetry_devbranch_ci_cleanup

Conversation

@AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Nov 14, 2025

Description

  • Removes uneeded dependencies from all containers
  • Added GTest to vcpkg
  • Removed rapidjson references
  • Removes old telemetry staging branch from ci
  • Minor telemetry macro change to function
  • Updated all container references to use cleaned up references
  • Updated README.md with telemetry pre-requisites

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@AhmedBM AhmedBM requested review from a team as code owners November 14, 2025 19:50
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Test Results

 64 files  +1   64 suites  +1   58m 47s ⏱️ +49s
  8 tests ±0    8 ✅ ±0   0 💤 ±0  0 ❌ ±0 
256 runs  +4  234 ✅ +4  22 💤 ±0  0 ❌ ±0 

Results for commit e8a3ba1. ± Comparison against base commit aa37de9.

♻️ This comment has been updated with latest results.

MariusNi
MariusNi previously approved these changes Nov 14, 2025
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi dismissed their stale review November 15, 2025 01:50

revoking review

@AhmedBM AhmedBM changed the title Telemetry dev branch cleanup Telemetry and dependency cleanup Nov 19, 2025
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@simonjaeger simonjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that not all checks are required right now but please make sure nothing is broken before we merge.

@AhmedBM AhmedBM merged commit e05d93c into dev Nov 20, 2025
162 of 165 checks passed
@AhmedBM AhmedBM mentioned this pull request Dec 3, 2025
5 tasks
MariusNi pushed a commit that referenced this pull request Jan 13, 2026
MariusNi pushed a commit that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants