Skip to content

Comments

Improve logging on Universal NRP Pester test#1218

Merged
AhmedBM merged 1 commit intodevfrom
ahbenmes/improve_nrp_logging
Dec 1, 2025
Merged

Improve logging on Universal NRP Pester test#1218
AhmedBM merged 1 commit intodevfrom
ahbenmes/improve_nrp_logging

Conversation

@AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Nov 25, 2025

Description

  • Improve logging in the pester tests, include the DesiredObjectName (policy name) when failing

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@AhmedBM AhmedBM requested review from a team as code owners November 25, 2025 00:08
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Test Results

 64 files  ±0   64 suites  ±0   1h 0m 15s ⏱️ +51s
  8 tests ±0    8 ✅ ±0   0 💤 ±0  0 ❌ ±0 
256 runs  ±0  234 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 3b02aee. ± Comparison against base commit d6ee0aa.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
/home/user1/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure resons are properly populated
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure resons are properly populated
/home/user1/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure reasons are properly populated
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure reasons are properly populated

♻️ This comment has been updated with latest results.

Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AhmedBM AhmedBM merged commit 3ec4da3 into dev Dec 1, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants