Skip to content

Comments

Added fuzzing for Telemetry#1220

Merged
AhmedBM merged 2 commits intodevfrom
ahbenmes/telemetry_add_fuzzing
Dec 3, 2025
Merged

Added fuzzing for Telemetry#1220
AhmedBM merged 2 commits intodevfrom
ahbenmes/telemetry_add_fuzzing

Conversation

@AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Dec 1, 2025

Description

  • Added Telemetry to fuzzing
    • Required changes since the 1DS SDK builds in an external process, added a new telemetry-interface which exposes the telemetry-external interface and its dependencies
    • Added lsan.supressions to suppress failures from third-party dependencies
      • Added initial suppression for leak from sqlite3MemMalloc
  • Added fix for out_of_range and all other exceptions (nlohmann::json::exception) from a resulting fuzzer failure. Also included the failure in the corpus (crash-778dddf07f9c31b3259fe5a09d63d16573bd8718)

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@AhmedBM AhmedBM requested review from a team as code owners December 1, 2025 21:46
@AhmedBM AhmedBM assigned AhmedBM and unassigned AhmedBM Dec 1, 2025
@simonjaeger
Copy link
Contributor

Intended to commit src/tests/fuzzer/seed_corpus/crash-778dddf07f9c31b3259fe5a09d63d16573bd8718?

@simonjaeger
Copy link
Contributor

Intended to commit src/tests/fuzzer/seed_corpus/crash-778dddf07f9c31b3259fe5a09d63d16573bd8718?

Can you help me understand how it works and why it's included?

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test Results

 64 files  ±0   64 suites  ±0   59m 51s ⏱️ + 1m 57s
  8 tests ±0    8 ✅ ±0   0 💤 ±0  0 ❌ ±0 
256 runs  ±0  234 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 4e9beb6. ± Comparison against base commit 3ec4da3.

♻️ This comment has been updated with latest results.

@AhmedBM
Copy link
Contributor Author

AhmedBM commented Dec 1, 2025

Intended to commit src/tests/fuzzer/seed_corpus/crash-778dddf07f9c31b3259fe5a09d63d16573bd8718?

Can you help me understand how it works and why it's included?

Yes its meant to be included. Everything under seed_corpus are the fuzzed inputs, the crash-* are seeds that triggered crashes. Although i fixed the crash (added exception handling for out_of_range exceptions) i added kept the seed there to ensure we catch regressions

@simonjaeger
Copy link
Contributor

Intended to commit src/tests/fuzzer/seed_corpus/crash-778dddf07f9c31b3259fe5a09d63d16573bd8718?

Can you help me understand how it works and why it's included?

Yes its meant to be included. Everything under seed_corpus are the fuzzed inputs, the crash-* are seeds that triggered crashes. Although i fixed the crash (added exception handling for out_of_range exceptions) i added kept the seed there to ensure we catch regressions

Thanks for the context!

@simonjaeger
Copy link
Contributor

Ensure that Azure Core has a look as well please.

@AhmedBM AhmedBM merged commit 6833e3b into dev Dec 3, 2025
119 checks passed
@AhmedBM AhmedBM deleted the ahbenmes/telemetry_add_fuzzing branch December 3, 2025 19:15
MariusNi pushed a commit that referenced this pull request Jan 13, 2026
* Added fuzzing for Telemetry (ProcessJsonFile)

* added additional exception handlers
MariusNi pushed a commit that referenced this pull request Jan 14, 2026
* Added fuzzing for Telemetry (ProcessJsonFile)

* added additional exception handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants