Skip to content

Add missing property to CommandExecuted event #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertschaedler3 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add missing property to CommandExecuted event #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb56ded
Add missing property to CommandExecuted event
robertschaedler3 Mar 4, 2026
bb21c08
update tests
robertschaedler3 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/telemetry/lib/ParameterSets.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const std::set<std::string> STATUS_TRACE_OPTIONAL_PARAMS = {

// CommandExecuted
const std::set<std::string> COMMAND_EXECUTED_REQUIRED_PARAMS = {
"CorrelationGroup", "IsTestMode", "Subcommand", "Success", "Duration", "ErrorResourceName", "ErrorResourceType", "ErrorLocation", "ErrorCode"};
"CorrelationGroup", "IsTestMode", "Subcommand", "Success", "Duration", "ErrorKind", "ErrorResourceName", "ErrorResourceType", "ErrorLocation", "ErrorCode"};
const std::set<std::string> COMMAND_EXECUTED_OPTIONAL_PARAMS = {
// No optional params for now
};
Expand Down
4 changes: 2 additions & 2 deletions src/common/telemetry/lib/tests/TelemetryTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,15 @@ TEST_F(TelemetryTest, ProcessStatusTraceMissingScenarioNameEvent)

TEST_F(TelemetryTest, ProcessCommandExecutedEvent)
{
std::string realEvent = R"({"EventName":"CommandExecuted","DistroName":"CentOS","Version":"1.3.0-preview123","CorrelationId":"{00000000-0000-0000-0000-000000000000}","CorrelationGroup":"TestGroup","Timestamp":"2025-10-17 22:52:56+0000","IsTestMode":true,"Subcommand":"get resource","Duration":1234.5678,"Success":true,"ErrorResourceName":"Test Resource","ErrorResourceType":"Microsoft.OSConfig/Test","ErrorLocation":"utils/test.rs:123","ErrorCode":1})";
std::string realEvent = R"({"EventName":"CommandExecuted","DistroName":"CentOS","Version":"1.3.0-preview123","CorrelationId":"{00000000-0000-0000-0000-000000000000}","CorrelationGroup":"TestGroup","Timestamp":"2025-10-17 22:52:56+0000","IsTestMode":true,"Subcommand":"get resource","Duration":1234.5678,"Success":true,"ErrorKind":"Resource","ErrorResourceName":"Test Resource","ErrorResourceType":"Microsoft.OSConfig/Test","ErrorLocation":"utils/test.rs:123","ErrorCode":1})";
ASSERT_TRUE(CreateTestJsonFile(realEvent));
Telemetry::TelemetryManager telemetryManager(false, std::chrono::seconds(1));
EXPECT_TRUE(telemetryManager.ProcessJsonFile(m_testJsonFile));
}

TEST_F(TelemetryTest, ProcessCommandExecutedMissingSubcommandEvent)
{
std::string realEvent = R"({"EventName":"CommandExecuted","DistroName":"CentOS","Version":"1.3.0-preview123","CorrelationId":"{00000000-0000-0000-0000-000000000000}","CorrelationGroup":"TestGroup","Timestamp":"2025-10-17 22:52:56+0000","IsTestMode":true,"Duration":1234.5678,"Success":true,"ErrorResourceName":"Test Resource","ErrorResourceType":"Microsoft.OSConfig/Test","ErrorLocation":"utils/test.rs:123","ErrorCode":1})";
std::string realEvent = R"({"EventName":"CommandExecuted","DistroName":"CentOS","Version":"1.3.0-preview123","CorrelationId":"{00000000-0000-0000-0000-000000000000}","CorrelationGroup":"TestGroup","Timestamp":"2025-10-17 22:52:56+0000","IsTestMode":true,"Duration":1234.5678,"Success":true,"ErrorKind":"Resource","ErrorResourceName":"Test Resource","ErrorResourceType":"Microsoft.OSConfig/Test","ErrorLocation":"utils/test.rs:123","ErrorCode":1})";
ASSERT_TRUE(CreateTestJsonFile(realEvent));
Telemetry::TelemetryManager telemetryManager(false, std::chrono::seconds(1));
EXPECT_FALSE(telemetryManager.ProcessJsonFile(m_testJsonFile));
Expand Down
Loading