Update RHEL7/Centos7/OracleLinux7 dockerfiles #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rapidjson has a google test submodule that it installs. This module is incompatible with our usage of google test, and conflicts with the version that we clone ourselves. Disable installations of rapidjson's googletest and reorder to ensure google test is built last. - Centos 7 mirror lists have been decomissioned but we can still access a snapshot of the repo - we just have to overwrite the repo definitions.
robertschaedler3
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update build container dockerfiles for Centos 7 (and derivative) to fix an issue preventing
commandrunnerandsamples/cppfrom building.Rapidjson has a google test submodule that it installs. This module has a version of google test that does not match the one we expect and overwrites the version that we clone ourselves. Disable installation of rapidjson's googletest by setting a cmake variable and order the gtest installation after rapidjson to ensure google test is installed correctly.
Centos 7 mirror lists have been decomissioned but we can still access a snapshot of the repo - we just have to overwrite the repo definitions. This is necessary to get the containers to build at all.
Checklist
mainbranch prior to this PR submission.mainbranch.