Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dockerfiles from pre-commit exclusion #896

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Remove dockerfiles from pre-commit exclusion #896

merged 2 commits into from
Mar 10, 2025

Conversation

AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Mar 4, 2025

Description

  • Removes the devops/docker/.*/Dockerfile exclusion from the trailing-whitespace and mixed-line-ending pre-commit hooks in the `.pre-commit-config.yaml

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@AhmedBM AhmedBM requested a review from a team as a code owner March 4, 2025 19:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

Test Results

 44 files  ±0   44 suites  ±0   37m 24s ⏱️ +19s
  4 tests ±0    4 ✅ ±0   0 💤 ±0  0 ❌ ±0 
176 runs  ±0  154 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 6e968b4. ± Comparison against base commit edcf1df.

♻️ This comment has been updated with latest results.

kkanas
kkanas approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@kkanas kkanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MariusNi
MariusNi approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AhmedBM AhmedBM merged commit c0d1f90 into dev Mar 10, 2025
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusNi MariusNi MariusNi approved these changes

@kkanas kkanas kkanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AhmedBM @MariusNi @kkanas