Skip to content

Conversation

@vinfnet
Copy link
Contributor

@vinfnet vinfnet commented Nov 20, 2024

Fixed typos in a couple of variable names
Added called but undeclared variables to stop script failing Updated some commands to reflect current syntax
Added -DisableRbacAuthorization for KeyVault
Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)

Description

Fixed typos in a couple of variable names
Added called but undeclared variables to stop script failing Updated some commands to reflect current syntax
Added -DisableRbacAuthorization for KeyVault
Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Fixed typos in a couple of variable names
Added called but undeclared variables to stop script failing
Updated some commands to reflect current syntax
Added -DisableRbacAuthorization for KeyVault
Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 20, 2024

⚠️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Set-AzVMOSDisk 5 42 Unassigned_Variable Get-AzDiskEncryptionSet -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMOSDisk 5 53 Unassigned_Variable New-AzVirtualNetworkSubnetConfig -Name ($subnetPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($subnetPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 54 Unassigned_Variable New-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($vnetPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 55 Unassigned_Variable Get-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($vnetPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 57 Unassigned_Variable New-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($pubIpPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 57 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $domainNameLabel2 is a null-valued parameter value. -DomainNameLabel Assign value for $domainNameLabel2.
⚠️ Set-AzVMOSDisk 5 58 Unassigned_Variable Get-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($pubIpPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 62 Unassigned_Variable New-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($nicPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 63 Unassigned_Variable Get-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($nicPrefix + $ResourceGroupName).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Set-AzVMOSDisk 5 42 Unassigned_Variable Get-AzDiskEncryptionSet -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Set-AzVMOSDisk 5 53 Unassigned_Variable New-AzVirtualNetworkSubnetConfig -Name ($subnetPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($subnetPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 54 Unassigned_Variable New-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($vnetPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 55 Unassigned_Variable Get-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($vnetPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 57 Unassigned_Variable New-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($pubIpPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 57 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $domainNameLabel2 is a null-valued parameter value. -DomainNameLabel Assign value for $domainNameLabel2.
⚠️ Set-AzVMOSDisk 5 58 Unassigned_Variable Get-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($pubIpPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 62 Unassigned_Variable New-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($nicPrefix + $ResourceGroupName).
⚠️ Set-AzVMOSDisk 5 63 Unassigned_Variable Get-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value. -Name Assign value for ($nicPrefix + $ResourceGroupName).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution vinfnet! We will review the pull request and get back to you soon.

@VeryEarly VeryEarly self-assigned this Nov 21, 2024
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly closed this Nov 29, 2024
@VeryEarly VeryEarly reopened this Nov 29, 2024
@VeryEarly VeryEarly merged commit 404abf2 into Azure:main Nov 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants