-
Notifications
You must be signed in to change notification settings - Fork 4k
Throughput bucket preview #27824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Az.CosmosDB-preview
Are you sure you want to change the base?
Throughput bucket preview #27824
Conversation
… model with help messages
Modified maximum throughput percentages for two buckets in `Test-SqlThroughputCmdlets`. Added assertions to verify updated bucket properties. Removed the test for container throughput buckets and the associated function `Test-SqlThroughputBucketCmdlets`. Adjusted formatting in `Test-ClientEncryptionKeyCmdletsUsingInputObject` for clarity.
Modified the help message for the `MaxThroughputPercentage` parameter in `NewAzCosmosDBThroughputBucketObject.cs` for clarity. Restored two help message constants in `Constants.cs` related to throughput buckets and added a new constant to improve usability in Cosmos DB resource management.
Updated `Test-SqlThroughputCmdlets` in `SqlOperationsTests.ps1` to add assertions for `ThroughputBuckets`. The test now verifies the count of buckets and checks the `Id` and `MaxThroughputPercentage` for each bucket to ensure expected values are set correctly.
Corrected the parameter name from `-Name $AccountName` to `-AccountName $AccountName` in the `Update-AzCosmosDBSqlContainerThroughput` function calls within `SqlOperationsTests.ps1`. This change ensures proper parameter usage and consistency across test cases, including instances with empty `-ThroughputBuckets`.
Refactor throughput handling in Azure Cosmos DB management library. Introduce `PSThroughputBucket` class to replace `ThroughputBucketResource`. Modify `CreateThroughputSettingsObject` to accept an array of `PSThroughputBucket`. Update `ThroughputSettingsGetResults` to ensure consistent usage of the new type, improving type safety and aligning with the updated data model for throughput settings.
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Introduced `New-AzCosmosDBThroughputBucketObject` cmdlet to create CosmosDB Throughput Bucket objects, complete with documentation updates for synopsis, syntax, and examples. Enhanced existing CosmosDB cmdlets to support a new `-ThroughputBuckets` parameter, allowing users to specify multiple throughput buckets for better resource management. Updated documentation for all affected cmdlets to reflect these changes.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hey @msJinLei |
Enhanced the synopsis and description for the command by replacing placeholder text with a specific description. Added an example to illustrate usage, demonstrating how to create a new throughput bucket object with parameters. The parameters section remains unchanged.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
|
CI fails of build error
|
[Cmdlet(VerbsCommon.New, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "CosmosDBThroughputBucketObject"), OutputType(typeof(PSThroughputBucket))] | ||
public class NewAzCosmosDBThroughputBucketObject : AzureCosmosDBCmdletBase | ||
{ | ||
[Parameter(Mandatory = true, HelpMessage = Constants.ThroughputBucketIdHelpMessage)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compilation error says the definition of Constants is not able to be found.
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Updated the Azure Cosmos DB PowerShell module to replace all instances of "ThroughputBuckets" with "ThroughputBucketsObject". This change affects test scripts, helper classes, and model definitions, ensuring consistency in the API. Help messages related to these parameters have also been updated for clarity on throughput bucket usage in Cosmos DB operations.
…mmands Renamed `-ThroughputBuckets` to `-ThroughputBucketsObject` across multiple Azure CosmosDB command documentation files. This change clarifies the expected input type, indicating that the parameter accepts an array of `PSThroughputBucket` objects.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.