Add support to AppGw Exception feature #27863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Add support for Application Gateway WAF Exceptions by introducing a new exception cmdlet and wiring it through models, help, exports, and tests.
- Introduce
New-AzApplicationGatewayFirewallPolicyExceptioncmdlet and PS model - Extend managed rules cmdlets/models to accept exception entries
- Update help files, module exports, changelog, and add scenario tests
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Network/Network/help/New-AzApplicationGatewayFirewallPolicyManagedRule.md | Added -Exception parameter to syntax and documented it |
| src/Network/Network/help/New-AzApplicationGatewayFirewallPolicyException.md | Created help file for the new exception cmdlet |
| src/Network/Network/help/Az.Network.md | Added reference to the new exception cmdlet |
| src/Network/Network/Models/PSApplicationGatewayFirewallPolicyManagedRules.cs | Added Exceptions property to PS model |
| src/Network/Network/Models/PSApplicationGatewayFirewallPolicyException.cs | Introduced PS model for exception entries |
| src/Network/Network/FirewallPolicy/ManagedRules/Exception/NewAzureApplicationGatewayFirewallPolicyExceptionCommand.cs | Implemented the New-...Exception cmdlet |
| src/Network/Network/FirewallPolicy/ManagedRules/Exception/AzureApplicationGatewayFirewallPolicyException.cs | Defined base parameters and logic for exceptions |
| src/Network/Network/FirewallPolicy/ManagedRules/AzureApplicationGatewayFirewallPolicyManagedRules.cs | Added Exception parameter to managed rules cmdlet |
| src/Network/Network/ChangeLog.md | Logged the new exception cmdlet |
| src/Network/Network/Az.Network.psd1 | Exported the new exception cmdlet |
| src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1 | Added PowerShell scenario test for exceptions |
| src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.cs | Added C# test harness for exception scenario |
Comments suppressed due to low confidence (1)
src/Network/Network/FirewallPolicy/ManagedRules/AzureApplicationGatewayFirewallPolicyManagedRules.cs:40
- Rename the
Exceptionproperty toExceptions(plural) to match the PS model property and make the API consistent.
public PSApplicationGatewayFirewallPolicyException[] Exception { get; set; }
...allPolicy/ManagedRules/Exception/NewAzureApplicationGatewayFirewallPolicyExceptionCommand.cs
Outdated
Show resolved
Hide resolved
| Accept wildcard characters: False | ||
| ``` | ||
| ### -ProgressAction | ||
| {{ Fill ProgressAction Description }} |
There was a problem hiding this comment.
Replace the placeholder with a proper description for the -ProgressAction parameter or remove it if not needed.
Suggested change
| {{ Fill ProgressAction Description }} | |
| Specifies how the cmdlet responds to progress updates. The parameter accepts values such as `Continue`, `SilentlyContinue`, `Stop`, or `Inquire`, which determine whether progress updates are displayed, suppressed, or trigger user interaction. |
Copilot uses AI. Check for mistakes.
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
| ### -Values |
There was a problem hiding this comment.
The parameter is named -Value (singular) in the syntax and code; update this header to -Value to match.
Suggested change
| ### -Values | |
| ### -Value |
Copilot uses AI. Check for mistakes.
src/Network/Network/Models/PSApplicationGatewayFirewallPolicyException.cs
Outdated
Show resolved
Hide resolved
| @@ -15,7 +15,8 @@ Create ManagedRules for the firewall policy. | |||
| ``` | |||
| New-AzApplicationGatewayFirewallPolicyManagedRule | |||
| [-ManagedRuleSet <PSApplicationGatewayFirewallPolicyManagedRuleSet[]>] | |||
| [-Exclusion <PSApplicationGatewayFirewallPolicyExclusion[]>] [-DefaultProfile <IAzureContextContainer>] | |||
| [-Exclusion <PSApplicationGatewayFirewallPolicyExclusion[]>] | |||
There was a problem hiding this comment.
The -Exclusion parameter appears twice in the syntax line; remove the duplicate to avoid confusion.
Suggested change
| [-Exclusion <PSApplicationGatewayFirewallPolicyExclusion[]>] | |
| [-Exclusion <PSApplicationGatewayFirewallPolicyExclusion[]>] |
Copilot uses AI. Check for mistakes.
src/Network/Network/help/New-AzApplicationGatewayFirewallPolicyException.md
Outdated
Show resolved
Hide resolved
| ``` | ||
|
|
||
| ## DESCRIPTION | ||
| The **New-AzApplicationGatewayFirewallPolicyException** cmdlet a new exception rule list for firewall policy. |
There was a problem hiding this comment.
[nitpick] The synopsis is missing a verb (e.g., "creates"); consider rephrasing to "Creates a new exception rule list for the firewall policy."
Suggested change
| The **New-AzApplicationGatewayFirewallPolicyException** cmdlet a new exception rule list for firewall policy. | |
| The **New-AzApplicationGatewayFirewallPolicyException** cmdlet creates a new exception rule list for the firewall policy. |
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 27863 in repo Azure/azure-powershell |
isra-fel
requested review from
wyunchi-ms,
dolauli,
isra-fel,
VeryEarly,
YanaXu,
vidai-msft,
NoriZC,
notyashhh,
Pan-Qi,
msJinLei and
grizzlytheodore
as code owners
yanivha6
force-pushed
the
AppGw-Exceptions
branch
from
7c050d2 to
cc49340
Compare
yanivha6
force-pushed
the
AppGw-Exceptions
branch
from
cc49340 to
9e6fba7
Compare
yanivha6
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.