Skip to content

Conversation

@amih90
Copy link
Contributor

@amih90 amih90 commented Dec 28, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings December 28, 2025 08:46
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Microsoft.Security/privateLinks provider to use a stable API version instead of a preview version. The change promotes the service from preview status (2025-09-01-preview) to stable (2026-01-01) within the Private Link Common Cmdlets framework.

Key Changes:

  • Updated Microsoft.Security/privateLinks API version from preview to stable
  • Added changelog entry documenting the onboarding

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Network/Network/PrivateLinkService/PrivateLinkServiceProvider/ProviderConfiguration.cs Updated API version from "2025-09-01-preview" to "2026-01-01" for Microsoft.Security/privateLinks configuration
src/Network/Network/ChangeLog.md Added entry under "Upcoming Release" documenting the onboarding of Microsoft.Security/privateLinks to Private Link cmdlets

--->

## Upcoming Release
* Onboarded `Microsoft.Security/privateLinks` to Private Link Common Cmdlets
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry does not explain what changed from the user's perspective. According to the custom guidelines for ChangeLog.md files, entries should be written for Azure PowerShell users and explain what changed and how it affects their usage. Consider revising to something like: "Updated Microsoft.Security/privateLinks to stable API version 2026-01-01 for Private Link cmdlets" to clarify that this is an API version update that affects stability/support.

Copilot generated this review using guidance from repository custom instructions.
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants