Skip to content

Conversation

@JunKai-v
Copy link

@JunKai-v JunKai-v commented Jan 5, 2026

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JunKai-v
Copy link
Author

JunKai-v commented Jan 5, 2026

@microsoft-github-policy-service agree company="Microsoft"

Comment on lines 2 to 3
```powershell
{{ Add code here }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve these placeholder examples

@JunKai-v JunKai-v marked this pull request as draft January 6, 2026 02:09
Copilot AI review requested due to automatic review settings January 9, 2026 09:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the DataProtection module from AutoRest v3 to AutoRest v4. The migration includes regenerating help documentation files, updating module manifests, adding new cmdlets, updating tests, and modifying examples to align with the new API version.

Key Changes:

  • Added 3 new cmdlets: Update-AzDataProtectionBackupPolicy, Update-AzDataProtectionResourceGuardMapping, and Unlock-AzDataProtectionDppResourceGuardProxyDelete
  • Updated help documentation across ~80 files to reflect API changes (type namespace changes from Api20250201 to base types)
  • Updated module manifest with new required Az.Accounts version (5.3.1) and new exported functions
  • Modified parameter types from enum types to strings for better flexibility
  • Updated examples to use simplified syntax for user-assigned identities

Reviewed changes

Copilot reviewed 152 out of 152 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ChangeLog.md Added entry for breaking changes with link to migration guide
Az.DataProtection.psd1 Updated module version dependencies and exported functions
Help/*.md (80+ files) Updated documentation with API v4 changes, parameter type updates, and namespace changes
Test files Added placeholder tests for new cmdlets; updated existing test with namespace change
Example files Updated examples with simplified UAMI syntax
Solution files Updated project GUIDs for regenerated project
.gitignore Removed unnecessary ignore entries

@isra-fel
Copy link
Member

isra-fel commented Jan 9, 2026

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@JunKai-v
Copy link
Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI review requested due to automatic review settings January 13, 2026 09:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 151 out of 151 changed files in this pull request and generated 19 comments.


The first, second commands fetch the instance and recovery point for the instance.
The third and fourth command initializes the target container id and target storage account ARM id.
The third and fourthcommand initializes the target container id and target storage account ARM id.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "fourthcommand" should be "fourth command"

Copilot uses AI. Check for mistakes.
The last command triggers the restore for AzureDatabaseForPGFlexServer.

### Example 10: Trigger vaulted backup containers ItemLevelRestore with PrefixMatch for Azureblob.
### Example 10: Trigger vaulted backup conatiners ItemLevelRestore with PrefixMatch for Azureblob.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "conatiners" should be "containers"

Copilot uses AI. Check for mistakes.
```

This command creates an hourly schedule for Azure Backup Rule.
This command creates an hourly scheudle for Azure Backup Rule.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "scheudle" should be "schedule"

Copilot uses AI. Check for mistakes.
The sixth command assigns the necessary permissions for configure backup.

The seventh and eight command initializes custom tags and configure backup finally by creating a backup instance.
The sevnth and eight command initializes custom tags and configure backup finally by creating a backup instance.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "sevnth" should be "seventh"

Copilot uses AI. Check for mistakes.
This command adds a weekly tag to given backup policy

### Example 2: Remove Weekly tag from Backup Policy
### Example 2: Remove Weeky tag from Backup Policy
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "Weeky" should be "Weekly"

Copilot uses AI. Check for mistakes.
```

First command gets a specific vault by given vault name, subsequent three commands fetch the specified properties of encryption settings.
First command gets a specific vault by given vault name, subsequent three commands fetch the specity properites of encryption settings.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "specity" should be "specify"

Copilot uses AI. Check for mistakes.

The first command is used to fetch the resource guard to be updated.
The second and third command is used to fetch the critical operations user want to update.
The second and third command is used to fecth the critical operations user want to update.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "fecth" should be "fetch"

Copilot uses AI. Check for mistakes.
Fetch the backup instance.
Fetch valid time ranges for Backup Instance $instance[0].
Display RestorableTimeRange, note that this can be multiple discrete ranges.
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "Dispaly" should be "Display"

Copilot uses AI. Check for mistakes.
Fetch the backup instance.
Fetch valid time ranges for Backup Instance $instance[0].
Display RestorableTimeRange, note that this can be multiple discrete ranges.
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "dicrete" should be "discrete"

Copilot uses AI. Check for mistakes.
```

First command gets a specific vault by given vault name, subsequent three commands fetch the specified properties of encryption settings.
First command gets a specific vault by given vault name, subsequent three commands fetch the specity properites of encryption settings.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "properites" should be "properties"

Copilot uses AI. Check for mistakes.
@JunKai-v JunKai-v added Contains Breaking Change This PR contains breaking change autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 labels Jan 14, 2026
@github-actions
Copy link

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Copilot AI review requested due to automatic review settings January 14, 2026 06:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 148 out of 148 changed files in this pull request and generated 9 comments.


This command is used to change CmkIdentityType from SystemAssigned to UserAssigned.
CmkIdentityId is a required parameter.
This command is used to change CmkIdentityType from SystemAssigned to UserAssgined.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "UserAssgined" should be "UserAssigned"

Copilot uses AI. Check for mistakes.
This command is used to change CmkIdentityType from SystemAssigned to UserAssigned.
CmkIdentityId is a required parameter.
This command is used to change CmkIdentityType from SystemAssigned to UserAssgined.
CmkIdenityId is a required parameter.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "CmkIdenityId" should be "CmkIdentityId"

Copilot uses AI. Check for mistakes.

The first command is used to fetch the resource guard to be updated.
The second and third command is used to fetch the critical operations user want to update.
The second and third command is used to fecth the critical operations user want to update.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "fecth" should be "fetch"

Copilot uses AI. Check for mistakes.
The last command triggers the restore for AzureDatabaseForPGFlexServer.

### Example 10: Trigger vaulted backup containers ItemLevelRestore with PrefixMatch for Azureblob.
### Example 10: Trigger vaulted backup conatiners ItemLevelRestore with PrefixMatch for Azureblob.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "conatiners" should be "containers"

Copilot uses AI. Check for mistakes.
The seventh command updates the policy object with custom schedule.
The eighth, ninth, tenth commands update the Monthly retention rule with custom lifecycles.
The eleventh, twelfth commands create a tag criteria for Monthly policy.
The eleventh, twelth commands create a tag criteria for Monthly policy.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "twelth" should be "twelfth"

Copilot uses AI. Check for mistakes.
- Additional information about change #1
-->
## Upcoming Release
* Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249).
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ChangeLog entry should be written in the past tense to describe what was changed, not as a generic statement about user experience. Consider a more specific entry like: "Migrated module to AutoRest v4 for improved consistency. This introduces breaking changes documented at [link]."

Copilot uses AI. Check for mistakes.
This command adds a weekly tag to given backup policy

### Example 2: Remove Weekly tag from Backup Policy
### Example 2: Remove Weeky tag from Backup Policy
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "Weeky" should be "Weekly"

Copilot uses AI. Check for mistakes.
The sixth command assigns the necessary permissions for configure backup.

The seventh and eight command initializes custom tags and configure backup finally by creating a backup instance.
The sevnth and eight command initializes custom tags and configure backup finally by creating a backup instance.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "sevnth" should be "seventh"

Copilot uses AI. Check for mistakes.
Start-Sleep -Seconds 10
}
$backupinstanceCreate = New-AzDataProtectionBackupInstance -ResourceGroupName "resourceGroupName" -VaultName "vaultName" -SubscriptionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -BackupInstance $backupInstanceClientObject
$backupnstanceCreate = New-AzDataProtectionBackupInstance -ResourceGroupName "resourceGroupName" -VaultName "vaultName" -SubscriptionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -BackupInstance $backupInstanceClientObject
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "backupnstanceCreate" should be "backupInstanceCreate"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 15, 2026 04:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 154 out of 154 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Contains Breaking Change This PR contains breaking change customer-reported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants