Fixed SoftDeleteRetentionDays computation

[rambabu-yalla]

Description

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[Copilot]

Pull request overview

This PR fixes a bug in the computation of SoftDeleteRetentionDays for the Set-AzSqlServer cmdlet. Previously, when updating a server property without specifying SoftDeleteRetentionDays, the value would be inadvertently reset to 0 because the API returns 0 for both null and explicitly disabled states. The fix simplifies the logic to return null when neither parameter is specified, allowing the API to preserve the existing value.

Key Changes:

• Removed the existingValue parameter from ComputeSoftDeleteRetentionDays method
• Simplified the method logic to return null when neither SoftDeleteRetentionDays nor EnableSoftDelete is provided
• Updated the call site in SetAzureSqlServer.cs to not pass the existing value

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Sql/Sql/Server/Cmdlet/SetAzureSqlServer.cs	Updated to call ComputeSoftDeleteRetentionDays without passing existing value; added explanatory comments
src/Sql/Sql/Server/Cmdlet/AzureSqlServerCmdletBase.cs	Simplified ComputeSoftDeleteRetentionDays method to return null when no parameters are specified, removing the existingValue parameter

[wyunchi-ms]

/azp run azure-powershell - security-tools

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).