Fix network breaking change#29796
Draft
Pan-Qi wants to merge 6 commits into
Draft
Conversation
Apply autorest directives (from xiaogang) to address spec-level issues: - Strip LRO response headers (Location, Retry-After, Azure-AsyncOperation) from 201/202 to prevent header drift - Remove redundant 'tags' on DdosProtectionPlan - Rename Common.CloudError -> CloudError via x-ms-client-name - Move x-ms-azure-resource from CommonProxyResource/CommonTrackedResource and SecurityPerimeter* variants down to CommonResource and Common.SubResource pairs - Use spec commit 587a15661041e26ff8a3059a4886ff9e092adfda with full 16-file input set (including common.json and networkSecurityPerimeter.json) Patch hand-written Customizations/ConnectionMonitorOperation.cs to use the same SafeJsonConvert idiom the generator now emits for the Guid SubscriptionId (fixes 4 CS1503 errors). Result: build succeeds with 0 errors / 0 warnings, replacing the prior shim commits.
- Add wildcard x-ms-client-name directive in README.md to strip the 'Common.' prefix from all swagger definitions so generated C# classes keep their legacy names (RouteTable, SubResource, NetworkInterface, etc.), unblocking the handwritten Az.Network layer. - Add directive to delete 'format: uuid' on the subscriptionId parameter so NetworkManagementClient.SubscriptionId regenerates as string (was System.Guid in 2025-07-01). - Update final rename directive: the legacy ManagedServiceIdentityUserAssignedIdentities generated name is now retargeted to ManagedServiceIdentityUserAssignedIdentitiesValue. - Regenerate Network.Management.Sdk via autorest --use:@autorest/powershell@4.x. - Compatibility workaround for TypeSpec/common prefix drift; remove once the source spec drops the 'Common.' prefix.
…NSP regen) Resolved conflicts in NSP module by taking upstream: - AssemblyInfo.cs: 7.27.0 release version (was 0.1.0.0 placeholder) - README.md: commit a21a9d3f5f517648e29cde69e0fd5c0afb761902 (newer spec snapshot for Resource Associable API) - generate-info.json: restored with new GUID c293af16
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Pan-Qi
force-pushed
the
bernard-fix-network-breaking-change
branch
from
fcdb4f7 to
6b9c4b9
Compare
Pan-Qi
force-pushed
the
bernard-fix-network-breaking-change
branch
from
6b9c4b9 to
e01f09e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.