[ApiManagement] Add support for StandardV2 SKU in APIM Mappers.MapSku#29798
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Live test skipped⏭️ Skipping the live test for this revision because no changed test file was found under a The live-test pipeline runs only the scenario/xUnit test files a PR changes, so there is nothing to execute for this commit. This is informational — a regression test is encouraged where it makes sense, but not required. If a test file is added in a later commit, the live test will run automatically. Posted by agent-assist (autonomous bug-fix pipeline). |
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #29798 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
a0x1ab
left a comment
There was a problem hiding this comment.
Automated Review — Failures Found
This PR currently has failing checks that need to be addressed:
-
Live test (TestFx
Record) — the dispatched live-test run failed.
Run: https://github.com/Azure/issue-sentinel/actions/runs/28607831895 -
CI check
azure-powershell - powershell-core (Test linux)— failed.
Run: https://github.com/Azure/azure-powershell/runs/84835896240
Please investigate why the ApiManagement Mappers.MapSku changes for the
StandardV2 SKU are failing the Linux PowerShell Core test run and the record
live test, fix the underlying issue, and push an update. Make sure to:
- Re-run/record the affected
ApiManagement.Testscenarios with the new SKU
handling included. - Confirm the
ChangeLog.mdentry undersrc/ApiManagement/ApiManagement/
reflects the fix.
Once pushed, this PR will be automatically re-tested.
Posted by agent-assist (autonomous bug-fix pipeline).
Addressed in |
a0x1ab
left a comment
There was a problem hiding this comment.
Review Summary — PR #29798 fails CI and live test
This PR ([ApiManagement] Add support for StandardV2 SKU in APIM Mappers.MapSku) currently has failing checks and a failing live test. Please investigate and fix:
CI failures
- azure-powershell - windows-powershell — Build #20260702.9 failed: https://github.com/Azure/azure-powershell/runs/84843364354
- azure-powershell - windows-powershell (Analyze) — Analyze failed: https://github.com/Azure/azure-powershell/runs/84843360790
- azure-powershell - powershell-core — Build #20260702.9 failed: https://github.com/Azure/azure-powershell/runs/84843322376
- azure-powershell - powershell-core (Analyze) — Analyze failed: https://github.com/Azure/azure-powershell/runs/84843319088
Live test (TestFx Record)
- Live test run failed: https://github.com/Azure/issue-sentinel/actions/runs/28609214529
Please:
- Check the build output for compile errors introduced by the StandardV2 SKU mapping change in
Mappers.MapSku. - Fix the Analyze (style/lint) failures reported for both the Windows PowerShell and PowerShell Core builds.
- Re-run/update the affected
<Service>.Testlive test(s) so they pass after the fix. - Ensure the
ChangeLog.mdentry undersrc/ApiManagement/ApiManagement/is updated if required by the PR template.
Once pushed, this PR will be re-evaluated automatically.
Posted by agent-assist (autonomous bug-fix pipeline).
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #29798 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
Addressed in |
a0x1ab
left a comment
There was a problem hiding this comment.
Automated review — PR #29798
CI status: ✅ All 11 checks passed, 0 failed, 0 pending.
Live test (TestFx Record): The issue-sentinel dispatcher recorded this run
as failure, but that is an infrastructure issue in the issue-sentinel
workflow itself, not a problem with this PR's code:
gh: The 'Microsoft Open Source' enterprise forbids access via a personal
access tokens (classic) if the token's lifetime is greater than 8 days.
(HTTP 403)
The workflow failed while trying to fetch PR metadata (gh api repos/Azure/azure-powershell/pulls/29798) using an expired/non-compliant
classic PAT, before it could even determine which test files changed. The
workflow's own scope-limiting logic (visible later in the same job) resolved
to No changed test files — skipping live test (neutral), confirming this PR
does not touch a <Service>.Test project and the live test would have been a
no-op regardless.
Conclusion: No action needed from Copilot on this PR — CI is green and the
live-test failure is unrelated to the PR's content (a token-policy problem on
the Azure/issue-sentinel side). Flagging this separately so the tester
infra can be fixed independently.
Posted by agent-assist (autonomous bug-fix pipeline).
Set-AzApiManagementfails when round-tripping an API Management service on theStandardV2SKU because the ApiManagement SKU mapper rejects that value. This blocks common update flows that start withGet-AzApiManagementand then persist changes withSet-AzApiManagement.Problem
Mappers.MapSkuaccepted existing APIM SKU values but notStandardV2Set-AzApiManagement -InputObject $apimthrowsUnrecognized Sku 'StandardV2'before the request reaches the serviceCode changes
StandardV2handling inMicrosoft.Azure.Commands.ApiManagement.Helpers.Mappers.MapSkuSkuType.StandardV2in the SDK model constants so the new mapping follows the same pattern as the existing SKU casesCoverage
MapSkuhandling ofStandardV2MapPsApiManagementemittingStandardV2in the outgoing SDK model used bySet-AzApiManagementRelease notes
StandardV2update-path fixWith this change, the mapper preserves
StandardV2instead of rejecting it during the update flow.