-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix VcfLicense support in New-AzVMwarePrivateCloud #29907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anaarias-msft
wants to merge
7
commits into
Azure:main
Choose a base branch
from
anaarias-msft:anaarias/vcfLicenseFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
32c8bb3
Fix VcfLicense support in New-AzVMwarePrivateCloud
anaarias-msft 2e00793
Potential fix for pull request finding
anaarias-msft ab8fec2
Potential fix for pull request finding
anaarias-msft c2201d6
Revert unnecessary VMware.sln project GUID churn
anaarias-msft 0223449
Revert accidental generate-info.json id bump
anaarias-msft 959bd88
Bump VMware.Autorest generate_Id to force CI regeneration
anaarias-msft 6be080e
Replace CredScan-flagged sample license key with placeholder
anaarias-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 142 additions & 0 deletions
142
src/VMware/VMware.Autorest/docs/New-AzVMwareVcf5LicenseObject.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| --- | ||
| external help file: | ||
| Module Name: Az.VMware | ||
| online version: https://learn.microsoft.com/powershell/module/Az.VMware/new-azvmwarevcf5licenseobject | ||
| schema: 2.0.0 | ||
| --- | ||
|
|
||
| # New-AzVMwareVcf5LicenseObject | ||
|
|
||
| ## SYNOPSIS | ||
| Create an in-memory object for Vcf5License. | ||
|
|
||
| ## SYNTAX | ||
|
|
||
| ``` | ||
| New-AzVMwareVcf5LicenseObject -Core <Int32> -EndDate <DateTime> [-BroadcomContractNumber <String>] | ||
| [-BroadcomSiteId <String>] [-Label <ILabel[]>] [-LicenseKey <SecureString>] [<CommonParameters>] | ||
| ``` | ||
|
|
||
| ## DESCRIPTION | ||
| Create an in-memory object for Vcf5License. | ||
|
|
||
| ## EXAMPLES | ||
|
|
||
| ### Example 1: Create an in-memory object for Vcf5License. | ||
| ```powershell | ||
| New-AzVMwareVcf5LicenseObject -Core 16 -EndDate (Get-Date "2027-01-01") -LicenseKey (ConvertTo-SecureString "YOUR-LICENSE-KEY" -AsPlainText -Force) -BroadcomSiteId "site123" -BroadcomContractNumber "contract123" | ||
| ``` | ||
|
|
||
| ```output | ||
| Core EndDate Kind | ||
| ---- ------- ---- | ||
| 16 1/1/2027 12:00:00 AM vcf5 | ||
| ``` | ||
|
|
||
| Creates an in-memory VMware Cloud Foundation (VCF) 5.0 license object to pass to `New-AzVMwarePrivateCloud` via the `-VcfLicense` parameter. | ||
|
|
||
| ## PARAMETERS | ||
|
|
||
| ### -BroadcomContractNumber | ||
| The Broadcom contract number associated with the license. | ||
|
|
||
| ```yaml | ||
| Type: System.String | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -BroadcomSiteId | ||
| The Broadcom site ID associated with the license. | ||
|
|
||
| ```yaml | ||
| Type: System.String | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -Core | ||
| Number of cores included in the license. | ||
|
|
||
| ```yaml | ||
| Type: System.Int32 | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: True | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -EndDate | ||
| UTC datetime when the license expires. | ||
|
|
||
| ```yaml | ||
| Type: System.DateTime | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: True | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -Label | ||
| Additional labels passed through for license reporting. | ||
|
|
||
| ```yaml | ||
| Type: Microsoft.Azure.PowerShell.Cmdlets.VMware.Models.ILabel[] | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -LicenseKey | ||
| License key. | ||
|
|
||
| ```yaml | ||
| Type: System.Security.SecureString | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### CommonParameters | ||
| This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216). | ||
|
|
||
| ## INPUTS | ||
|
|
||
| ## OUTPUTS | ||
|
|
||
| ### Microsoft.Azure.PowerShell.Cmdlets.VMware.Models.Vcf5License | ||
|
|
||
| ## NOTES | ||
|
|
||
| ## RELATED LINKS | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/VMware/VMware.Autorest/examples/New-AzVMwareVcf5LicenseObject.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| ### Example 1: Create an in-memory object for Vcf5License. | ||
| ```powershell | ||
| New-AzVMwareVcf5LicenseObject -Core 16 -EndDate (Get-Date "2027-01-01") -LicenseKey (ConvertTo-SecureString "YOUR-LICENSE-KEY" -AsPlainText -Force) -BroadcomSiteId "site123" -BroadcomContractNumber "contract123" | ||
| ``` | ||
|
|
||
| ```output | ||
| Core EndDate Kind | ||
| ---- ------- ---- | ||
| 16 1/1/2027 12:00:00 AM vcf5 | ||
| ``` | ||
|
|
||
| Creates an in-memory VMware Cloud Foundation (VCF) 5.0 license object to pass to `New-AzVMwarePrivateCloud` via the `-VcfLicense` parameter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "generate_Id": "2726e206-da56-4c9d-8b45-65d0a875e579" | ||
| "generate_Id": "6b5fd672-539d-49db-a352-643b92fcf814" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.