Skip to content

[DO NOT MERGE] Add MySQL swagger files for GA stable version 2021-05-01 #15224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Suna-MS
Copy link
Contributor

@Suna-MS Suna-MS commented Jul 16, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Sorry, something went wrong.

@openapi-workflow-bot
Copy link

Hi, @Suna-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 16, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 10 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'Configurations_BatchUpdate' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L1148
    ⚠️ R1003 - ListInOperationName Since operation 'CheckVirtualNetworkSubnetUsage_Execute' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L1293
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'updateconfigurations' in:'Configurations_BatchUpdate'. Consider updating the operationId
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L1148
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'CheckVirtualNetworkSubnetUsage_Execute'. Consider updating the operationId
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L1293
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L1341
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getprivatednszonesuffix' in:'GetPrivateDnsZoneSuffix_Execute'. Consider updating the operationId
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L1389
    ⚠️ R4021 - DescriptionAndTitleMissing 'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: common-types/resource-management/v1/types.json#L163
    ⚠️ R4021 - DescriptionAndTitleMissing 'sku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: common-types/resource-management/v1/types.json#L170
    ⚠️ R4021 - DescriptionAndTitleMissing 'plan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: common-types/resource-management/v1/types.json#L177
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Restart a server
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L377


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L2538
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.DBforMySQL/stable/2021-05-01/mysql.json#L2461
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mysql/resource-manager/readme.md
    tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"mysql/resource-manager/readme.md",
    "tag":"package-flexibleserver-2021-05-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"mysql/resource-manager/readme.md",
    "tag":"package-flexibleserver-2021-05-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"mysql/resource-manager/readme.md",
    "tag":"package-flexibleserver-2021-05-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 16, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 668a39bcc4922fa6ab314888671538f278eb3a47. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MySQL [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 668a39bcc4922fa6ab314888671538f278eb3a47. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-rdbms [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation MySQLManagementClientOperationsMixin.reset_query_performance_insight_data
      info	[Changelog]   - Added operation group ServerBasedPerformanceTierOperations
      info	[Changelog]   - Added operation group ServerParametersOperations
      info	[Changelog]   - Added operation group RecoverableServersOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 668a39bcc4922fa6ab314888671538f278eb3a47. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-07-16 03:20:50 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-mysql;1.0.1;1.1.0-beta.1"
      cmderr	[generate.py] 2021-07-16 03:20:50 WARNING [VERSION][Not Implement] set to current version "1.1.0-beta.1" by default
      cmderr	[generate.py] 2021-07-16 03:20:50 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.32 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mysql/azure-resourcemanager-mysql --java.namespace=com.azure.resourcemanager.mysql   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-mysql
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [POM][Skip] pom already has module azure-resourcemanager-mysql
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [POM][Skip] pom already has module sdk/mysql
      cmderr	[generate.py] 2021-07-16 03:21:23 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-mysql [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG Got artifact_id: azure-resourcemanager-mysql
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG Got artifact: azure-resourcemanager-mysql-1.1.0-beta.1-sources.jar
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG Got artifact: azure-resourcemanager-mysql-1.1.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG Got artifact: azure-resourcemanager-mysql-1.1.0-beta.1.jar
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG Match jar package: azure-resourcemanager-mysql-1.1.0-beta.1.jar
      cmderr	[Inst] 2021-07-16 03:23:10 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15224/azure-sdk-for-java/azure-resourcemanager-mysql/azure-resourcemanager-mysql-1.1.0-beta.1.jar\" -o azure-resourcemanager-mysql-1.1.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mysql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mysql-1.1.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from 668a39bcc4922fa6ab314888671538f278eb3a47. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation] [ERROR] total 1 error(s):
      cmderr	[generator automation] [ERROR] failed in validation: validation failed in readme 'specification/mysql/resource-manager/readme.md' with 1 error(s):
      cmderr	[generator automation] [ERROR] the output-folder of a stable package 'package-flexibleserver-2021-05-01' must NOT be under the `preview` subdirectory
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 668a39bcc4922fa6ab314888671538f278eb3a47. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
    • ️✔️@azure/arm-mysql [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/mySQLManagementClient.js → ./dist/arm-mysql.js...
      cmderr	[npmPack] created ./dist/arm-mysql.js in 664ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 668a39bcc4922fa6ab314888671538f278eb3a47. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @Suna-MS your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @mentat9
    Copy link
    Member

    mentat9 commented Jul 17, 2021

    Please complete the missing requirements in order to get ARM review of your PR:

    1. Fill out the contribution checklist
    2. Make a new PR following this requirement (and check the box when you submit): Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently..
    3. Study the onboarding documentation linked in this item before your next PR (and check the box when you submit): Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

    @mentat9 mentat9 added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 17, 2021
    @Suna-MS
    Copy link
    Contributor Author

    Suna-MS commented Jul 21, 2021

    Created new RP: #15289

    @PhoenixHe-NV PhoenixHe-NV assigned jianyexi and unassigned PhoenixHe-NV Aug 2, 2021
    @ghost
    Copy link

    ghost commented Aug 22, 2021

    Hi, @Suna-MS. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Aug 22, 2021
    @Suna-MS
    Copy link
    Contributor Author

    Suna-MS commented Aug 23, 2021

    Created a new RP #15289, close this one.

    @Suna-MS Suna-MS closed this Aug 23, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review DoNotMerge <valid label in PR review process> use to hold merge after approval
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants