Skip to content

Compute New API version 2021-08-01 #16945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 50 commits into from
Closed

Conversation

haagha
Copy link
Member

@haagha haagha commented Dec 2, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

haagha and others added 30 commits May 13, 2020 13:56
adding greetings only when PR made to compute
first workflow
greetings2 because original didnt work
updating greeting to prettier
creating main yaml
updated
update
prettier
delete
delete
update
update
update custom docker
update checkout action
test checkout
1) Added "x-ms-pageable" property on get
2) Updated "POST" call input model
3) Added "type" property in input model.
4) Fixed typo.
Added missing comma in diagnostic.json
@haagha haagha changed the title Compute 2021-08-01 changes Compute New API version 2021-08-01 Dec 2, 2021
@haagha
Copy link
Member Author

haagha commented Dec 2, 2021

@ArcturusZhang breaking changes were approved in a previous PR #16099

@openapi-workflow-bot
Copy link

Hi @haagha, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

This reverts commit 76b5b13, reversing
changes made to 4fd5dcc.
@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 7, 2021
@haagha
Copy link
Member Author

haagha commented Dec 9, 2021

arm reviewer please review commits:
98f557a
7d73e23
3d9e9f6

@mentat9
Copy link
Member

mentat9 commented Dec 14, 2021

arm reviewer please review commits: 98f557a 7d73e23 3d9e9f6

@haagha, BreakingChangeReviewRequired label needs to be resolved before ARM review.

@haagha
Copy link
Member Author

haagha commented Dec 15, 2021

@mentat9 breaking changes were approved in a previous PR #16099

@mentat9
Copy link
Member

mentat9 commented Dec 16, 2021

@haagha, thank-you for the breaking change context, but you still are missing a couple of requirements:

  1. You need to complete the submission form. This is important to correctly drive the routing and automation of your PR. In particular, this item:
    Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest. and its sub-item. When adding a new API version your PR must include the correct base commit. Please create a new PR following this item (and check the box when you submit):
    [ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
    Ensure the files for the current API version are copied without modification to the new API version folder for the first commit, then apply changes in subsequent commits.
  2. You need to study the materials linked in the submission form and attest to that by checking the box. [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board. This is required for ARM review.

@mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 16, 2021
@haagha
Copy link
Member Author

haagha commented Dec 16, 2021

Moving to a new PR #17118

@haagha
Copy link
Member Author

haagha commented Dec 16, 2021

Moving to new PR #17118

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @haagha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@haagha haagha deleted the feature/cplat-2021-08-01 branch June 16, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review CI-BreakingChange-Go CI-FixRequiredOnFailure Compute WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants