Skip to content

Add properties to ExpressRoute gateway resource types to allow custom… #20831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

jjcv-msft
Copy link
Contributor

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: add three new properties to two already existing resources to grant customers the ability to enable/block traffic over ExpressRoute.
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    As soon as possible.

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    As soon as possible.

  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @jjcv-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 22, 2022

    Swagger Validation Report

    ️⚠️BreakingChange: 4 Warnings warning [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    2022-05-01 2022-05-01(303d202) 2022-05-01(main)
    Rule Message
    ⚠️ 1041 - AddedPropertyInResponse The new version has a new property 'allowNonVirtualWanTraffic' in response that was not found in the old version.
    New: azure-rest-api-specs/blob/303d20288df6748fcc1fb983d491c7d8b76cf860/null#Lnull:1
    Old: azure-rest-api-specs/blob/main/null#Lnull:1
    ⚠️ 1045 - AddedOptionalProperty The new version has a new optional property 'allowVirtualWanTraffic' that was not found in the old version.
    New: azure-rest-api-specs/blob/303d20288df6748fcc1fb983d491c7d8b76cf860/null#Lnull:1
    Old: azure-rest-api-specs/blob/main/null#Lnull:1
    ⚠️ 1045 - AddedOptionalProperty The new version has a new optional property 'allowRemoteVnetTraffic' that was not found in the old version.
    New: azure-rest-api-specs/blob/303d20288df6748fcc1fb983d491c7d8b76cf860/null#Lnull:1
    Old: azure-rest-api-specs/blob/main/null#Lnull:1
    ⚠️ 1045 - AddedOptionalProperty The new version has a new optional property 'allowNonVirtualWanTraffic' that was not found in the old version.
    New: azure-rest-api-specs/blob/303d20288df6748fcc1fb983d491c7d8b76cf860/null#Lnull:1
    Old: azure-rest-api-specs/blob/main/null#Lnull:1
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-05 package-2022-05(303d202) package-2022-05(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{VirtualWANName}'
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L37
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/GenerateVpnProfile'
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4112
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1141
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1210
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1741
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1810
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4220
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4287
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4346
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L8611
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L8615
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L8698
    R4017 - TopLevelResourcesListBySubscription The top-level resource 'VirtualNetworkGateway' does not have list by subscription operation, please add it.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3235
    R4017 - TopLevelResourcesListBySubscription The top-level resource 'VirtualNetworkGatewayConnection' does not have list by subscription operation, please add it.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3529
    R4017 - TopLevelResourcesListBySubscription The top-level resource 'LocalNetworkGateway' does not have list by subscription operation, please add it.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3909
    R4037 - MissingTypeObject The schema 'VirtualNetworkGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2571
    R4037 - MissingTypeObject The schema 'VirtualNetworkGatewayIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2598
    R4037 - MissingTypeObject The schema 'VirtualNetworkGatewayNatRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2622
    R4037 - MissingTypeObject The schema 'VirtualNetworkGatewayNatRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2674
    R4037 - MissingTypeObject The schema 'VirtualNetworkGatewayPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2703
    R4037 - MissingTypeObject The schema 'VpnClientRootCertificatePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2838
    R4037 - MissingTypeObject The schema 'VpnClientRootCertificate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2855
    R4037 - MissingTypeObject The schema 'VpnClientRevokedCertificatePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2882
    R4037 - MissingTypeObject The schema 'VpnClientRevokedCertificate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2896
    R4037 - MissingTypeObject The schema 'RadiusServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2920
    R4037 - MissingTypeObject The schema 'RadiusServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2920
    R4037 - MissingTypeObject The schema 'VpnClientConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2941
    R4037 - MissingTypeObject The schema 'VirtualNetworkGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3039
    R4037 - MissingTypeObject The schema 'BgpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3104
    R4037 - MissingTypeObject The schema 'BgpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3104
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️~[Staging] TrafficValidation succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/303d20288df6748fcc1fb983d491c7d8b76cf860/specification/network/resource-manager/readme.md#tag-package-2022-05">network/resource-manager/readme.md#package-2022-05
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ExpressRouteProviderPort' has a property 'id' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ExpressRouteProviderPort"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ExpressRouteProviderPort' has a property 'name' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ExpressRouteProviderPort"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ExpressRouteProviderPort' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ExpressRouteProviderPort"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'NetworkManagerConnection' has a property 'etag' that is already declared the parent schema 'ChildResource' but isn't significantly different. The property has been removed from NetworkManagerConnection"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ScopeConnection' has a property 'etag' that is already declared the parent schema 'ChildResource' but isn't significantly different. The property has been removed from ScopeConnection"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'RouteMap' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from RouteMap"
    ⚠️ UnkownSecurityScheme "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 22, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9997789. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Network [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9997789. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group NspAssociationReconcileOperations
      info	[Changelog]   - Model NspProfile has a new parameter diagnostic_settings_version
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Removed operation NetworkSecurityPerimetersOperations.check_members
      info	[Changelog]   - Removed operation NetworkSecurityPerimetersOperations.query
      info	[Changelog]   - Removed operation group NspAssociationsProxyOperations
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9997789. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New function `*RouteMapsClient.BeginDelete(context.Context, string, string, string, *RouteMapsClientBeginDeleteOptions) (*runtime.Poller[RouteMapsClientDeleteResponse], error)`
      info	[Changelog] - New function `PossibleSlotTypeValues() []SlotType`
      info	[Changelog] - New function `*VipSwapClient.Get(context.Context, string, string, *VipSwapClientGetOptions) (VipSwapClientGetResponse, error)`
      info	[Changelog] - New function `*RouteMapsClient.BeginCreateOrUpdate(context.Context, string, string, string, RouteMap, *RouteMapsClientBeginCreateOrUpdateOptions) (*runtime.Poller[RouteMapsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ApplicationGatewayWafDynamicManifestsDefaultClient.Get(context.Context, string, *ApplicationGatewayWafDynamicManifestsDefaultClientGetOptions) (ApplicationGatewayWafDynamicManifestsDefaultClientGetResponse, error)`
      info	[Changelog] - New function `*ApplicationGatewayWafDynamicManifestsClient.NewGetPager(string, *ApplicationGatewayWafDynamicManifestsClientGetOptions) *runtime.Pager[ApplicationGatewayWafDynamicManifestsClientGetResponse]`
      info	[Changelog] - New function `PossibleApplicationGatewayRuleSetStatusOptionsValues() []ApplicationGatewayRuleSetStatusOptions`
      info	[Changelog] - New function `PossibleCustomIPPrefixTypeValues() []CustomIPPrefixType`
      info	[Changelog] - New function `PossibleApplicationGatewayClientRevocationOptionsValues() []ApplicationGatewayClientRevocationOptions`
      info	[Changelog] - New function `*VipSwapClient.BeginCreate(context.Context, string, string, SwapResource, *VipSwapClientBeginCreateOptions) (*runtime.Poller[VipSwapClientCreateResponse], error)`
      info	[Changelog] - New function `PossibleRouteMapMatchConditionValues() []RouteMapMatchCondition`
      info	[Changelog] - New function `NewVipSwapClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VipSwapClient, error)`
      info	[Changelog] - New function `NewApplicationGatewayWafDynamicManifestsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ApplicationGatewayWafDynamicManifestsClient, error)`
      info	[Changelog] - New function `*VirtualHubsClient.BeginGetInboundRoutes(context.Context, string, string, GetInboundRoutesParameters, *VirtualHubsClientBeginGetInboundRoutesOptions) (*runtime.Poller[VirtualHubsClientGetInboundRoutesResponse], error)`
      info	[Changelog] - New function `PossibleNextStepValues() []NextStep`
      info	[Changelog] - New function `*VirtualHubsClient.BeginGetOutboundRoutes(context.Context, string, string, GetOutboundRoutesParameters, *VirtualHubsClientBeginGetOutboundRoutesOptions) (*runtime.Poller[VirtualHubsClientGetOutboundRoutesResponse], error)`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `*RouteMapsClient.NewListPager(string, string, *RouteMapsClientListOptions) *runtime.Pager[RouteMapsClientListResponse]`
      info	[Changelog] - New function `PossibleExpressRoutePortsBillingTypeValues() []ExpressRoutePortsBillingType`
      info	[Changelog] - New function `PossibleDdosSettingsProtectionModeValues() []DdosSettingsProtectionMode`
      info	[Changelog] - New function `*RouteMapsClient.Get(context.Context, string, string, string, *RouteMapsClientGetOptions) (RouteMapsClientGetResponse, error)`
      info	[Changelog] - New function `PossibleRouteMapActionTypeValues() []RouteMapActionType`
      info	[Changelog] - New function `*PublicIPAddressesClient.BeginDdosProtectionStatus(context.Context, string, string, *PublicIPAddressesClientBeginDdosProtectionStatusOptions) (*runtime.Poller[PublicIPAddressesClientDdosProtectionStatusResponse], error)`
      info	[Changelog] - New function `PossibleApplicationGatewayTierTypesValues() []ApplicationGatewayTierTypes`
      info	[Changelog] - New function `NewRouteMapsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*RouteMapsClient, error)`
      info	[Changelog] - New function `PossibleApplicationGatewayWafRuleStateTypesValues() []ApplicationGatewayWafRuleStateTypes`
      info	[Changelog] - New function `PossibleApplicationGatewayWafRuleActionTypesValues() []ApplicationGatewayWafRuleActionTypes`
      info	[Changelog] - New function `PossibleVnetLocalRouteOverrideCriteriaValues() []VnetLocalRouteOverrideCriteria`
      info	[Changelog] - New struct `Action`
      info	[Changelog] - New struct `ApplicationGatewayFirewallManifestRuleSet`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestPropertiesResult`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestResult`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestResultList`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestsClient`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestsClientGetOptions`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestsClientGetResponse`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestsDefaultClient`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestsDefaultClientGetOptions`
      info	[Changelog] - New struct `ApplicationGatewayWafDynamicManifestsDefaultClientGetResponse`
      info	[Changelog] - New struct `Criterion`
      info	[Changelog] - New struct `DefaultRuleSetPropertyFormat`
      info	[Changelog] - New struct `EffectiveRouteMapRoute`
      info	[Changelog] - New struct `GetInboundRoutesParameters`
      info	[Changelog] - New struct `GetOutboundRoutesParameters`
      info	[Changelog] - New struct `ListRouteMapsResult`
      info	[Changelog] - New struct `Parameter`
      info	[Changelog] - New struct `PublicIPAddressesClientBeginDdosProtectionStatusOptions`
      info	[Changelog] - New struct `PublicIPAddressesClientDdosProtectionStatusResponse`
      info	[Changelog] - New struct `PublicIPDdosProtectionStatusResult`
      info	[Changelog] - New struct `RouteMap`
      info	[Changelog] - New struct `RouteMapProperties`
      info	[Changelog] - New struct `RouteMapRule`
      info	[Changelog] - New struct `RouteMapsClient`
      info	[Changelog] - New struct `RouteMapsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `RouteMapsClientBeginDeleteOptions`
      info	[Changelog] - New struct `RouteMapsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `RouteMapsClientDeleteResponse`
      info	[Changelog] - New struct `RouteMapsClientGetOptions`
      info	[Changelog] - New struct `RouteMapsClientGetResponse`
      info	[Changelog] - New struct `RouteMapsClientListOptions`
      info	[Changelog] - New struct `RouteMapsClientListResponse`
      info	[Changelog] - New struct `StaticRoutesConfig`
      info	[Changelog] - New struct `SwapResource`
      info	[Changelog] - New struct `SwapResourceListResult`
      info	[Changelog] - New struct `SwapResourceProperties`
      info	[Changelog] - New struct `VipSwapClient`
      info	[Changelog] - New struct `VipSwapClientBeginCreateOptions`
      info	[Changelog] - New struct `VipSwapClientCreateResponse`
      info	[Changelog] - New struct `VipSwapClientGetOptions`
      info	[Changelog] - New struct `VipSwapClientGetResponse`
      info	[Changelog] - New struct `VipSwapClientListOptions`
      info	[Changelog] - New struct `VipSwapClientListResponse`
      info	[Changelog] - New struct `VirtualHubsClientBeginGetInboundRoutesOptions`
      info	[Changelog] - New struct `VirtualHubsClientBeginGetOutboundRoutesOptions`
      info	[Changelog] - New struct `VirtualHubsClientGetInboundRoutesResponse`
      info	[Changelog] - New struct `VirtualHubsClientGetOutboundRoutesResponse`
      info	[Changelog] - New struct `VirtualNetworkDdosProtectionStatusResult`
      info	[Changelog] - New struct `VirtualNetworkGatewayPolicyGroup`
      info	[Changelog] - New struct `VirtualNetworkGatewayPolicyGroupMember`
      info	[Changelog] - New struct `VirtualNetworkGatewayPolicyGroupProperties`
      info	[Changelog] - New struct `VirtualNetworksClientBeginListDdosProtectionStatusOptions`
      info	[Changelog] - New struct `VirtualNetworksClientListDdosProtectionStatusResponse`
      info	[Changelog] - New struct `VngClientConnectionConfiguration`
      info	[Changelog] - New struct `VngClientConnectionConfigurationProperties`
      info	[Changelog] - New field `VirtualNetworkGatewayPolicyGroups` in struct `VirtualNetworkGatewayPropertiesFormat`
      info	[Changelog] - New field `AllowRemoteVnetTraffic` in struct `VirtualNetworkGatewayPropertiesFormat`
      info	[Changelog] - New field `AllowVirtualWanTraffic` in struct `VirtualNetworkGatewayPropertiesFormat`
      info	[Changelog] - New field `Action` in struct `ManagedRuleOverride`
      info	[Changelog] - New field `Top` in struct `ManagementClientListActiveConnectivityConfigurationsOptions`
      info	[Changelog] - New field `Action` in struct `ApplicationGatewayFirewallRule`
      info	[Changelog] - New field `RuleIDString` in struct `ApplicationGatewayFirewallRule`
      info	[Changelog] - New field `State` in struct `ApplicationGatewayFirewallRule`
      info	[Changelog] - New field `EnablePrivateLinkFastPath` in struct `VirtualNetworkGatewayConnectionListEntityPropertiesFormat`
      info	[Changelog] - New field `VerifyClientRevocation` in struct `ApplicationGatewayClientAuthConfiguration`
      info	[Changelog] - New field `VngClientConnectionConfigurations` in struct `VPNClientConfiguration`
      info	[Changelog] - New field `AllowNonVirtualWanTraffic` in struct `ExpressRouteGatewayProperties`
      info	[Changelog] - New field `EnablePrivateLinkFastPath` in struct `ExpressRouteConnectionProperties`
      info	[Changelog] - New field `Tiers` in struct `ApplicationGatewayFirewallRuleSetPropertiesFormat`
      info	[Changelog] - New field `InboundRouteMap` in struct `RoutingConfiguration`
      info	[Changelog] - New field `OutboundRouteMap` in struct `RoutingConfiguration`
      info	[Changelog] - New field `DdosProtectionPlan` in struct `DdosSettings`
      info	[Changelog] - New field `ProtectionMode` in struct `DdosSettings`
      info	[Changelog] - New field `ColoLocation` in struct `ExpressRouteLinkPropertiesFormat`
      info	[Changelog] - New field `PublicIPAddresses` in struct `DdosProtectionPlanPropertiesFormat`
      info	[Changelog] - New field `DisableTCPStateTracking` in struct `InterfacePropertiesFormat`
      info	[Changelog] - New field `StaticRoutesConfig` in struct `VnetRoute`
      info	[Changelog] - New field `Top` in struct `ManagementClientListNetworkManagerEffectiveConnectivityConfigurationsOptions`
      info	[Changelog] - New field `RouteMaps` in struct `VirtualHubProperties`
      info	[Changelog] - New field `ProbeThreshold` in struct `ProbePropertiesFormat`
      info	[Changelog] - New field `Top` in struct `ManagementClientListNetworkManagerEffectiveSecurityAdminRulesOptions`
      info	[Changelog] - New field `Top` in struct `ManagementClientListActiveSecurityAdminRulesOptions`
      info	[Changelog] - New field `PrefixType` in struct `CustomIPPrefixPropertiesFormat`
      info	[Changelog] - New field `Asn` in struct `CustomIPPrefixPropertiesFormat`
      info	[Changelog] - New field `ExpressRouteAdvertise` in struct `CustomIPPrefixPropertiesFormat`
      info	[Changelog] - New field `Geo` in struct `CustomIPPrefixPropertiesFormat`
      info	[Changelog] - New field `BillingType` in struct `ExpressRoutePortPropertiesFormat`
      info	[Changelog] - New field `EnablePrivateLinkFastPath` in struct `VirtualNetworkGatewayConnectionPropertiesFormat`
      info	[Changelog] - New field `Top` in struct `ManagerDeploymentStatusClientListOptions`
      info	[Changelog]
      info	[Changelog] Total 23 breaking change(s), 247 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9997789. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface PublicIPAddressesDdosProtectionStatusOptionalParams
      info	[Changelog]   - Added Interface PublicIpDdosProtectionStatusResult
      info	[Changelog]   - Added Interface RouteMap
      info	[Changelog]   - Added Interface RouteMapRule
      info	[Changelog]   - Added Interface RouteMapsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface RouteMapsDeleteOptionalParams
      info	[Changelog]   - Added Interface RouteMapsGetOptionalParams
      info	[Changelog]   - Added Interface RouteMapsListNextOptionalParams
      info	[Changelog]   - Added Interface RouteMapsListOptionalParams
      info	[Changelog]   - Added Interface StaticRoutesConfig
      info	[Changelog]   - Added Interface SwapResource
      info	[Changelog]   - Added Interface SwapResourceListResult
      info	[Changelog]   - Added Interface SwapResourceProperties
      info	[Changelog]   - Added Interface VipSwapCreateOptionalParams
      info	[Changelog]   - Added Interface VipSwapGetOptionalParams
      info	[Changelog]   - Added Interface VipSwapListOptionalParams
      info	[Changelog]   - Added Interface VirtualHubsGetInboundRoutesOptionalParams
      info	[Changelog]   - Added Interface VirtualHubsGetOutboundRoutesOptionalParams
      info	[Changelog]   - Added Interface VirtualNetworkDdosProtectionStatusResult
      info	[Changelog]   - Added Interface VirtualNetworkGatewayPolicyGroup
      info	[Changelog]   - Added Interface VirtualNetworkGatewayPolicyGroupMember
      info	[Changelog]   - Added Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams
      info	[Changelog]   - Added Interface VirtualNetworksListDdosProtectionStatusOptionalParams
      info	[Changelog]   - Added Interface VngClientConnectionConfiguration
      info	[Changelog]   - Added Type Alias ActionType
      info	[Changelog]   - Added Type Alias ApplicationGatewayClientRevocationOptions
      info	[Changelog]   - Added Type Alias ApplicationGatewayRuleSetStatusOptions
      info	[Changelog]   - Added Type Alias ApplicationGatewayTierTypes
      info	[Changelog]   - Added Type Alias ApplicationGatewayWafDynamicManifestsDefaultGetResponse
      info	[Changelog]   - Added Type Alias ApplicationGatewayWafDynamicManifestsGetNextResponse
      info	[Changelog]   - Added Type Alias ApplicationGatewayWafDynamicManifestsGetResponse
      info	[Changelog]   - Added Type Alias ApplicationGatewayWafRuleActionTypes
      info	[Changelog]   - Added Type Alias ApplicationGatewayWafRuleStateTypes
      info	[Changelog]   - Added Type Alias CustomIpPrefixType
      info	[Changelog]   - Added Type Alias DdosSettingsProtectionMode
      info	[Changelog]   - Added Type Alias ExpressRoutePortsBillingType
      info	[Changelog]   - Added Type Alias Geo
      info	[Changelog]   - Added Type Alias IsWorkloadProtected
      info	[Changelog]   - Added Type Alias NextStep
      info	[Changelog]   - Added Type Alias PublicIPAddressesDdosProtectionStatusResponse
      info	[Changelog]   - Added Type Alias RouteMapActionType
      info	[Changelog]   - Added Type Alias RouteMapMatchCondition
      info	[Changelog]   - Added Type Alias RouteMapsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias RouteMapsGetResponse
      info	[Changelog]   - Added Type Alias RouteMapsListNextResponse
      info	[Changelog]   - Added Type Alias RouteMapsListResponse
      info	[Changelog]   - Added Type Alias SlotType
      info	[Changelog]   - Added Type Alias VipSwapGetResponse
      info	[Changelog]   - Added Type Alias VipSwapListResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListDdosProtectionStatusNextResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListDdosProtectionStatusResponse
      info	[Changelog]   - Added Type Alias VnetLocalRouteOverrideCriteria
      info	[Changelog]   - Interface ApplicationGatewayClientAuthConfiguration has a new optional parameter verifyClientRevocation
      info	[Changelog]   - Interface ApplicationGatewayFirewallRule has a new optional parameter action
      info	[Changelog]   - Interface ApplicationGatewayFirewallRule has a new optional parameter ruleIdString
      info	[Changelog]   - Interface ApplicationGatewayFirewallRule has a new optional parameter state
      info	[Changelog]   - Interface ApplicationGatewayFirewallRuleSet has a new optional parameter tiers
      info	[Changelog]   - Interface CustomIpPrefix has a new optional parameter asn
      info	[Changelog]   - Interface CustomIpPrefix has a new optional parameter expressRouteAdvertise
      info	[Changelog]   - Interface CustomIpPrefix has a new optional parameter geo
      info	[Changelog]   - Interface CustomIpPrefix has a new optional parameter prefixType
      info	[Changelog]   - Interface DdosProtectionPlan has a new optional parameter publicIpAddresses
      info	[Changelog]   - Interface DdosSettings has a new optional parameter ddosProtectionPlan
      info	[Changelog]   - Interface DdosSettings has a new optional parameter protectionMode
      info	[Changelog]   - Interface ExpressRouteConnection has a new optional parameter enablePrivateLinkFastPath
      info	[Changelog]   - Interface ExpressRouteGateway has a new optional parameter allowNonVirtualWanTraffic
      info	[Changelog]   - Interface ExpressRouteLink has a new optional parameter coloLocation
      info	[Changelog]   - Interface ExpressRoutePort has a new optional parameter billingType
      info	[Changelog]   - Interface ListActiveConnectivityConfigurationsOptionalParams has a new optional parameter top
      info	[Changelog]   - Interface ListActiveSecurityAdminRulesOptionalParams has a new optional parameter top
      info	[Changelog]   - Interface ListNetworkManagerEffectiveConnectivityConfigurationsOptionalParams has a new optional parameter top
      info	[Changelog]   - Interface ListNetworkManagerEffectiveSecurityAdminRulesOptionalParams has a new optional parameter top
      info	[Changelog]   - Interface ManagedRuleOverride has a new optional parameter action
      info	[Changelog]   - Interface NetworkInterface has a new optional parameter disableTcpStateTracking
      info	[Changelog]   - Interface NetworkManagerDeploymentStatusListOptionalParams has a new optional parameter top
      info	[Changelog]   - Interface Probe has a new optional parameter probeThreshold
      info	[Changelog]   - Interface RoutingConfiguration has a new optional parameter inboundRouteMap
      info	[Changelog]   - Interface RoutingConfiguration has a new optional parameter outboundRouteMap
      info	[Changelog]   - Interface VirtualHub has a new optional parameter routeMaps
      info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter allowRemoteVnetTraffic
      info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter allowVirtualWanTraffic
      info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter virtualNetworkGatewayPolicyGroups
      info	[Changelog]   - Interface VirtualNetworkGatewayConnection has a new optional parameter enablePrivateLinkFastPath
      info	[Changelog]   - Interface VirtualNetworkGatewayConnectionListEntity has a new optional parameter enablePrivateLinkFastPath
      info	[Changelog]   - Interface VnetRoute has a new optional parameter staticRoutesConfig
      info	[Changelog]   - Interface VpnClientConfiguration has a new optional parameter vngClientConnectionConfigurations
      info	[Changelog]   - Class NetworkManagementClient has a new parameter applicationGatewayWafDynamicManifests
      info	[Changelog]   - Class NetworkManagementClient has a new parameter applicationGatewayWafDynamicManifestsDefault
      info	[Changelog]   - Class NetworkManagementClient has a new parameter routeMaps
      info	[Changelog]   - Class NetworkManagementClient has a new parameter vipSwap
      info	[Changelog]   - Added Enum KnownActionType
      info	[Changelog]   - Added Enum KnownApplicationGatewayClientRevocationOptions
      info	[Changelog]   - Added Enum KnownApplicationGatewayRuleSetStatusOptions
      info	[Changelog]   - Added Enum KnownApplicationGatewayTierTypes
      info	[Changelog]   - Added Enum KnownApplicationGatewayWafRuleActionTypes
      info	[Changelog]   - Added Enum KnownApplicationGatewayWafRuleStateTypes
      info	[Changelog]   - Added Enum KnownCustomIpPrefixType
      info	[Changelog]   - Added Enum KnownDdosSettingsProtectionMode
      info	[Changelog]   - Added Enum KnownExpressRoutePortsBillingType
      info	[Changelog]   - Added Enum KnownGeo
      info	[Changelog]   - Added Enum KnownIsWorkloadProtected
      info	[Changelog]   - Added Enum KnownNextStep
      info	[Changelog]   - Added Enum KnownRouteMapActionType
      info	[Changelog]   - Added Enum KnownRouteMapMatchCondition
      info	[Changelog]   - Added Enum KnownVnetLocalRouteOverrideCriteria
      info	[Changelog]   - Enum KnownCommissionedState has a new value Deprovisioned
      info	[Changelog]   - Enum KnownManagedRuleEnabledState has a new value Enabled
      info	[Changelog]   - Enum KnownNetworkIntentPolicyBasedService has a new value AllowRulesOnly
      info	[Changelog]   - Enum KnownWebApplicationFirewallTransform has a new value Uppercase
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface DdosCustomPolicy no longer has parameter protocolCustomSettings
      info	[Changelog]   - Interface DdosCustomPolicy no longer has parameter publicIPAddresses
      info	[Changelog]   - Interface DdosSettings no longer has parameter ddosCustomPolicy
      info	[Changelog]   - Interface DdosSettings no longer has parameter protectedIP
      info	[Changelog]   - Interface DdosSettings no longer has parameter protectionCoverage
      info	[Changelog]   - Removed Enum KnownDdosCustomPolicyProtocol
      info	[Changelog]   - Removed Enum KnownDdosCustomPolicyTriggerSensitivityOverride
      info	[Changelog]   - Removed Enum KnownDdosSettingsProtectionCoverage
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 9997789. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.network [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 22, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/network/armnetwork Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-network-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @jjcv-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants