-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add properties to ExpressRoute gateway resource types to allow custom… #20831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ers to control traffic flow
Hi, @jjcv-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
2022-05-01 | 2022-05-01(303d202) | 2022-05-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-05 | package-2022-05(303d202) | package-2022-05(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{VirtualWANName}' Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L37 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/GenerateVpnProfile' Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4112 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1141 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1210 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1741 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L1810 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4220 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4287 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L4346 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L8611 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L8615 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2022-05-01/virtualWan.json#L8698 |
R4017 - TopLevelResourcesListBySubscription |
The top-level resource 'VirtualNetworkGateway' does not have list by subscription operation, please add it. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3235 |
R4017 - TopLevelResourcesListBySubscription |
The top-level resource 'VirtualNetworkGatewayConnection' does not have list by subscription operation, please add it. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3529 |
R4017 - TopLevelResourcesListBySubscription |
The top-level resource 'LocalNetworkGateway' does not have list by subscription operation, please add it. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3909 |
R4037 - MissingTypeObject |
The schema 'VirtualNetworkGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2571 |
R4037 - MissingTypeObject |
The schema 'VirtualNetworkGatewayIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2598 |
R4037 - MissingTypeObject |
The schema 'VirtualNetworkGatewayNatRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2622 |
R4037 - MissingTypeObject |
The schema 'VirtualNetworkGatewayNatRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2674 |
R4037 - MissingTypeObject |
The schema 'VirtualNetworkGatewayPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2703 |
R4037 - MissingTypeObject |
The schema 'VpnClientRootCertificatePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2838 |
R4037 - MissingTypeObject |
The schema 'VpnClientRootCertificate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2855 |
R4037 - MissingTypeObject |
The schema 'VpnClientRevokedCertificatePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2882 |
R4037 - MissingTypeObject |
The schema 'VpnClientRevokedCertificate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2896 |
R4037 - MissingTypeObject |
The schema 'RadiusServer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2920 |
R4037 - MissingTypeObject |
The schema 'RadiusServer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2920 |
R4037 - MissingTypeObject |
The schema 'VpnClientConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L2941 |
R4037 - MissingTypeObject |
The schema 'VirtualNetworkGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3039 |
R4037 - MissingTypeObject |
The schema 'BgpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3104 |
R4037 - MissingTypeObject |
The schema 'BgpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/virtualNetworkGateway.json#L3104 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️
~[Staging] TrafficValidation succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/303d20288df6748fcc1fb983d491c7d8b76cf860/specification/network/resource-manager/readme.md#tag-package-2022-05">network/resource-manager/readme.md#package-2022-05
Rule | Message |
---|---|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'ExpressRouteProviderPort' has a property 'id' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ExpressRouteProviderPort" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'ExpressRouteProviderPort' has a property 'name' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ExpressRouteProviderPort" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'ExpressRouteProviderPort' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ExpressRouteProviderPort" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'NetworkManagerConnection' has a property 'etag' that is already declared the parent schema 'ChildResource' but isn't significantly different. The property has been removed from NetworkManagerConnection" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'ScopeConnection' has a property 'etag' that is already declared the parent schema 'ChildResource' but isn't significantly different. The property has been removed from ScopeConnection" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Schema 'RouteMap' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from RouteMap" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2022-05", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @jjcv-msft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Changelog
Add a changelog entry for this PR by answering the following questions:
What's the purpose of the update?
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
As soon as possible.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
As soon as possible.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.