Skip to content

Release recoveryservicesbackup microsoft.recovery services 2022 09 01 preview #20969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pratimaupadhyay02
Copy link
Contributor

@pratimaupadhyay02 pratimaupadhyay02 commented Oct 3, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @pratimaupadhyay02 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 3, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-09-preview package-2022-09-preview(fcbb4a3) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 3 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/fcbb4a3f41c506e84b92080e25871d17b9c0910c/specification/recoveryservicesbackup/resource-manager/readme.md#tag-package-2022-09-preview">recoveryservicesbackup/resource-manager/readme.md#package-2022-09-preview
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-09-preview",
    "details":"Schema 'RecoveryPointTierInformationV2' has a property 'type' that is already declared the parent schema 'RecoveryPointTierInformation' but isn't significantly different. The property has been removed from RecoveryPointTierInformationV2"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-09-preview",
    "details":"Schema 'RecoveryPointTierInformationV2' has a property 'status' that is already declared the parent schema 'RecoveryPointTierInformation' but isn't significantly different. The property has been removed from RecoveryPointTierInformationV2"
    ⚠️ UnkownSecurityScheme "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-09-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 3, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-js - @azure/arm-recoveryservicesbackup - Approved - 10.0.0-beta.1
    +	Enum KnownContainerType no longer has value AzureWorkloadContainer
    +	Enum KnownContainerType no longer has value MicrosoftClassicComputeVirtualMachines
    +	Enum KnownContainerType no longer has value MicrosoftComputeVirtualMachines
    +	Operation ResourceGuardProxy.put has a new signature
    azure-sdk-for-go - sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup - Approved - 2.0.0-beta.1
    +	Const `ContainerTypeAzureWorkloadContainer` has been removed
    +	Const `ContainerTypeMicrosoftClassicComputeVirtualMachines` has been removed
    +	Const `ContainerTypeMicrosoftComputeVirtualMachines` has been removed
    +	Struct `CloudErrorBody` has been removed
    +	Struct `CloudError` has been removed
    +	Type of `AzureBackupServerContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureIaaSClassicComputeVMContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureIaaSComputeVMContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureSQLAGWorkloadContainerProtectionContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureSQLContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureStorageContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureStorageProtectableContainer.ProtectableContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureVMAppContainerProtectableContainer.ProtectableContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureVMAppContainerProtectionContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `AzureWorkloadContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `DpmContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `GenericContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `IaaSVMContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `MabContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `ProtectableContainer.ProtectableContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    +	Type of `ProtectionContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from ab1aa33c1572712736274b8266753f1393ef511c. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-recoveryservicesbackup [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group DeletedProtectionContainersOperations
      info	[Changelog]   - Model AzureVmWorkloadSAPHanaDBInstanceProtectedItem has a new parameter soft_delete_retention_period
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ab1aa33c1572712736274b8266753f1393ef511c. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `DpmContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureIaaSComputeVMContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `ProtectableContainer.ProtectableContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `ProtectionContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `GenericContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureStorageContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureSQLAGWorkloadContainerProtectionContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureWorkloadContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureIaaSClassicComputeVMContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureBackupServerContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `IaaSVMContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureSQLContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureVMAppContainerProtectableContainer.ProtectableContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureStorageProtectableContainer.ProtectableContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `AzureVMAppContainerProtectionContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Type of `MabContainer.ContainerType` has been changed from `*ContainerType` to `*ProtectableContainerType`
      info	[Changelog] - Const `ContainerTypeAzureWorkloadContainer` has been removed
      info	[Changelog] - Const `ContainerTypeMicrosoftClassicComputeVirtualMachines` has been removed
      info	[Changelog] - Const `ContainerTypeMicrosoftComputeVirtualMachines` has been removed
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Struct `CloudErrorBody` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ContainerTypeHanaHSRContainer`
      info	[Changelog] - New const `ProtectableContainerTypeStorageContainer`
      info	[Changelog] - New const `PolicyTypeSnapshotFull`
      info	[Changelog] - New const `ProtectableContainerTypeAzureBackupServerContainer`
      info	[Changelog] - New const `ProtectableContainerTypeAzureSQLContainer`
      info	[Changelog] - New const `BackupItemTypeSAPHanaDBInstance`
      info	[Changelog] - New const `ProtectableContainerTypeCluster`
      info	[Changelog] - New const `TieringModeTierAfter`
      info	[Changelog] - New const `ProtectableContainerTypeWindows`
      info	[Changelog] - New const `ProtectableContainerTypeInvalid`
      info	[Changelog] - New const `BackupTypeSnapshotCopyOnlyFull`
      info	[Changelog] - New const `ProtectableContainerTypeUnknown`
      info	[Changelog] - New const `RestorePointQueryTypeSnapshotCopyOnlyFull`
      info	[Changelog] - New const `ProtectableContainerTypeIaasVMServiceContainer`
      info	[Changelog] - New const `WorkloadTypeSAPHanaDBInstance`
      info	[Changelog] - New const `DataSourceTypeSAPHanaDBInstance`
      info	[Changelog] - New const `TieringModeDoNotTier`
      info	[Changelog] - New const `TieringModeInvalid`
      info	[Changelog] - New const `TieringModeTierRecommended`
      info	[Changelog] - New const `BackupTypeSnapshotFull`
      info	[Changelog] - New const `RestorePointTypeSnapshotFull`
      info	[Changelog] - New const `ProtectableContainerTypeVCenter`
      info	[Changelog] - New const `ProtectableContainerTypeSQLAGWorkLoadContainer`
      info	[Changelog] - New const `ProtectableContainerTypeMicrosoftClassicComputeVirtualMachines`
      info	[Changelog] - New const `WorkloadItemTypeSAPHanaDBInstance`
      info	[Changelog] - New const `ProtectableContainerTypeGenericContainer`
      info	[Changelog] - New const `ProtectableContainerTypeMABContainer`
      info	[Changelog] - New const `ProtectableContainerTypeIaasVMContainer`
      info	[Changelog] - New const `ProtectableContainerTypeAzureWorkloadContainer`
      info	[Changelog] - New const `ProtectableContainerTypeDPMContainer`
      info	[Changelog] - New const `RestorePointTypeSnapshotCopyOnlyFull`
      info	[Changelog] - New const `PolicyTypeSnapshotCopyOnlyFull`
      info	[Changelog] - New const `RestorePointQueryTypeSnapshotFull`
      info	[Changelog] - New const `ProtectableContainerTypeVMAppContainer`
      info	[Changelog] - New const `ProtectableContainerTypeMicrosoftComputeVirtualMachines`
      info	[Changelog] - New type alias `TieringMode`
      info	[Changelog] - New type alias `ProtectableContainerType`
      info	[Changelog] - New function `NewDeletedProtectionContainersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DeletedProtectionContainersClient, error)`
      info	[Changelog] - New function `*DeletedProtectionContainersClient.NewListPager(string, string, *DeletedProtectionContainersClientListOptions) *runtime.Pager[DeletedProtectionContainersClientListResponse]`
      info	[Changelog] - New function `PossibleProtectableContainerTypeValues() []ProtectableContainerType`
      info	[Changelog] - New function `*AzureVMWorkloadSAPHanaHSR.GetAzureVMWorkloadProtectableItem() *AzureVMWorkloadProtectableItem`
      info	[Changelog] - New function `*AzureVMWorkloadSAPHanaDBInstance.GetAzureVMWorkloadProtectableItem() *AzureVMWorkloadProtectableItem`
      info	[Changelog] - New function `*AzureVMWorkloadSAPHanaDBInstanceProtectedItem.GetProtectedItem() *ProtectedItem`
      info	[Changelog] - New function `*AzureVMWorkloadSAPHanaDBInstance.GetWorkloadProtectableItem() *WorkloadProtectableItem`
      info	[Changelog] - New function `*AzureVMWorkloadSAPHanaHSR.GetWorkloadProtectableItem() *WorkloadProtectableItem`
      info	[Changelog] - New function `PossibleTieringModeValues() []TieringMode`
      info	[Changelog] - New function `*AzureVMWorkloadSAPHanaDBInstanceProtectedItem.GetAzureVMWorkloadProtectedItem() *AzureVMWorkloadProtectedItem`
      info	[Changelog] - New struct `AzureVMWorkloadSAPHanaDBInstance`
      info	[Changelog] - New struct `AzureVMWorkloadSAPHanaDBInstanceProtectedItem`
      info	[Changelog] - New struct `AzureVMWorkloadSAPHanaHSR`
      info	[Changelog] - New struct `DeletedProtectionContainersClient`
      info	[Changelog] - New struct `DeletedProtectionContainersClientListOptions`
      info	[Changelog] - New struct `DeletedProtectionContainersClientListResponse`
      info	[Changelog] - New struct `TieringPolicy`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `DPMProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureVMWorkloadSQLDatabaseProtectedItem`
      info	[Changelog] - New field `TieringPolicy` in struct `AzureIaaSVMProtectionPolicy`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureFileshareProtectedItem`
      info	[Changelog] - New field `TieringPolicy` in struct `SubProtectionPolicy`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `ProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureIaaSClassicComputeVMProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureIaaSComputeVMProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureVMWorkloadSAPAseDatabaseProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `GenericProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureIaaSVMProtectedItem`
      info	[Changelog] - New field `NewestRecoveryPointInArchive` in struct `AzureVMWorkloadProtectedItemExtendedInfo`
      info	[Changelog] - New field `OldestRecoveryPointInArchive` in struct `AzureVMWorkloadProtectedItemExtendedInfo`
      info	[Changelog] - New field `OldestRecoveryPointInVault` in struct `AzureVMWorkloadProtectedItemExtendedInfo`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureVMWorkloadProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `MabFileFolderProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureVMWorkloadSAPHanaDatabaseProtectedItem`
      info	[Changelog] - New field `SoftDeleteRetentionPeriod` in struct `AzureSQLProtectedItem`
      info	[Changelog] - New field `NewestRecoveryPointInArchive` in struct `AzureIaaSVMProtectedItemExtendedInfo`
      info	[Changelog] - New field `OldestRecoveryPointInArchive` in struct `AzureIaaSVMProtectedItemExtendedInfo`
      info	[Changelog] - New field `OldestRecoveryPointInVault` in struct `AzureIaaSVMProtectedItemExtendedInfo`
      info	[Changelog]
      info	[Changelog] Total 23 breaking change(s), 78 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ab1aa33c1572712736274b8266753f1393ef511c. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-recoveryservicesbackup [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface AzureWorkloadRecoveryPoint
      info	[Changelog]   - Added Interface AzureWorkloadRestoreRequest
      info	[Changelog]   - Added Interface AzureWorkloadSAPHanaPointInTimeRecoveryPoint
      info	[Changelog]   - Added Interface AzureWorkloadSAPHanaPointInTimeRestoreRequest
      info	[Changelog]   - Added Interface AzureWorkloadSAPHanaPointInTimeRestoreWithRehydrateRequest
      info	[Changelog]   - Added Interface AzureWorkloadSAPHanaRecoveryPoint
      info	[Changelog]   - Added Interface AzureWorkloadSAPHanaRestoreRequest
      info	[Changelog]   - Added Interface AzureWorkloadSAPHanaRestoreWithRehydrateRequest
      info	[Changelog]   - Added Interface AzureWorkloadSQLAutoProtectionIntent
      info	[Changelog]   - Added Interface AzureWorkloadSQLPointInTimeRecoveryPoint
      info	[Changelog]   - Added Interface AzureWorkloadSQLPointInTimeRestoreRequest
      info	[Changelog]   - Added Interface AzureWorkloadSQLPointInTimeRestoreWithRehydrateRequest
      info	[Changelog]   - Added Interface AzureWorkloadSQLRecoveryPoint
      info	[Changelog]   - Added Interface AzureWorkloadSQLRestoreRequest
      info	[Changelog]   - Added Interface AzureWorkloadSQLRestoreWithRehydrateRequest
      info	[Changelog]   - Added Interface BackupEngineBaseResource
      info	[Changelog]   - Added Interface BackupEngineBaseResourceList
      info	[Changelog]   - Added Interface BackupRequestResource
      info	[Changelog]   - Added Interface BackupResourceConfigResource
      info	[Changelog]   - Added Interface BackupResourceEncryptionConfigExtended
      info	[Changelog]   - Added Interface BackupResourceEncryptionConfigExtendedResource
      info	[Changelog]   - Added Interface BackupResourceEncryptionConfigResource
      info	[Changelog]   - Added Interface BackupResourceVaultConfigResource
      info	[Changelog]   - Added Interface DeletedProtectionContainersListNextOptionalParams
      info	[Changelog]   - Added Interface DeletedProtectionContainersListOptionalParams
      info	[Changelog]   - Added Interface DpmBackupEngine
      info	[Changelog]   - Added Interface DpmContainer
      info	[Changelog]   - Added Interface DpmJob
      info	[Changelog]   - Added Interface DPMProtectedItem
      info	[Changelog]   - Added Interface ExportJobsOperationResultInfo
      info	[Changelog]   - Added Interface GenericContainer
      info	[Changelog]   - Added Interface GenericProtectedItem
      info	[Changelog]   - Added Interface GenericProtectionPolicy
      info	[Changelog]   - Added Interface GenericRecoveryPoint
      info	[Changelog]   - Added Interface IaasVMBackupRequest
      info	[Changelog]   - Added Interface IaaSVMContainer
      info	[Changelog]   - Added Interface IaasVmilrRegistrationRequest
      info	[Changelog]   - Added Interface IaaSVMProtectableItem
      info	[Changelog]   - Added Interface IaasVMRecoveryPoint
      info	[Changelog]   - Added Interface IaasVMRestoreRequest
      info	[Changelog]   - Added Interface IaasVMRestoreWithRehydrationRequest
      info	[Changelog]   - Added Interface ILRRequestResource
      info	[Changelog]   - Added Interface JobResource
      info	[Changelog]   - Added Interface JobResourceList
      info	[Changelog]   - Added Interface LogSchedulePolicy
      info	[Changelog]   - Added Interface LongTermRetentionPolicy
      info	[Changelog]   - Added Interface LongTermSchedulePolicy
      info	[Changelog]   - Added Interface MabContainer
      info	[Changelog]   - Added Interface MabFileFolderProtectedItem
      info	[Changelog]   - Added Interface MabJob
      info	[Changelog]   - Added Interface MabProtectionPolicy
      info	[Changelog]   - Added Interface OperationResultInfo
      info	[Changelog]   - Added Interface OperationResultInfoBaseResource
      info	[Changelog]   - Added Interface OperationStatusJobExtendedInfo
      info	[Changelog]   - Added Interface OperationStatusJobsExtendedInfo
      info	[Changelog]   - Added Interface OperationStatusProvisionILRExtendedInfo
      info	[Changelog]   - Added Interface OperationStatusValidateOperationExtendedInfo
      info	[Changelog]   - Added Interface PrepareDataMoveResponse
      info	[Changelog]   - Added Interface PrivateEndpointConnectionResource
      info	[Changelog]   - Added Interface ProtectableContainerResource
      info	[Changelog]   - Added Interface ProtectableContainerResourceList
      info	[Changelog]   - Added Interface ProtectedItemResource
      info	[Changelog]   - Added Interface ProtectedItemResourceList
      info	[Changelog]   - Added Interface ProtectionContainerResource
      info	[Changelog]   - Added Interface ProtectionContainerResourceList
      info	[Changelog]   - Added Interface ProtectionIntentResource
      info	[Changelog]   - Added Interface ProtectionIntentResourceList
      info	[Changelog]   - Added Interface ProtectionPolicyResource
      info	[Changelog]   - Added Interface ProtectionPolicyResourceList
      info	[Changelog]   - Added Interface RecoveryPointResource
      info	[Changelog]   - Added Interface RecoveryPointResourceList
      info	[Changelog]   - Added Interface RecoveryPointTierInformationV2
      info	[Changelog]   - Added Interface ResourceGuardProxyBaseResource
      info	[Changelog]   - Added Interface ResourceGuardProxyBaseResourceList
      info	[Changelog]   - Added Interface RestoreRequestResource
      info	[Changelog]   - Added Interface SimpleRetentionPolicy
      info	[Changelog]   - Added Interface SimpleSchedulePolicy
      info	[Changelog]   - Added Interface SimpleSchedulePolicyV2
      info	[Changelog]   - Added Interface TieringPolicy
      info	[Changelog]   - Added Interface ValidateIaasVMRestoreOperationRequest
      info	[Changelog]   - Added Interface ValidateRestoreOperationRequest
      info	[Changelog]   - Added Interface VaultJob
      info	[Changelog]   - Added Interface WorkloadItemResource
      info	[Changelog]   - Added Interface WorkloadItemResourceList
      info	[Changelog]   - Added Interface WorkloadProtectableItemResource
      info	[Changelog]   - Added Interface WorkloadProtectableItemResourceList
      info	[Changelog]   - Added Type Alias DeletedProtectionContainersListNextResponse
      info	[Changelog]   - Added Type Alias DeletedProtectionContainersListResponse
      info	[Changelog]   - Added Type Alias ProtectableContainerType
      info	[Changelog]   - Added Type Alias TieringMode
      info	[Changelog]   - Interface AzureIaaSVMProtectedItemExtendedInfo has a new optional parameter newestRecoveryPointInArchive
      info	[Changelog]   - Interface AzureIaaSVMProtectedItemExtendedInfo has a new optional parameter oldestRecoveryPointInArchive
      info	[Changelog]   - Interface AzureIaaSVMProtectedItemExtendedInfo has a new optional parameter oldestRecoveryPointInVault
      info	[Changelog]   - Interface AzureVmWorkloadProtectedItemExtendedInfo has a new optional parameter newestRecoveryPointInArchive
      info	[Changelog]   - Interface AzureVmWorkloadProtectedItemExtendedInfo has a new optional parameter oldestRecoveryPointInArchive
      info	[Changelog]   - Interface AzureVmWorkloadProtectedItemExtendedInfo has a new optional parameter oldestRecoveryPointInVault
      info	[Changelog]   - Interface ProtectedItem has a new optional parameter softDeleteRetentionPeriod
      info	[Changelog]   - Interface SubProtectionPolicy has a new optional parameter tieringPolicy
      info	[Changelog]   - Class RecoveryServicesBackupClient has a new parameter deletedProtectionContainers
      info	[Changelog]   - Added Enum KnownTieringMode
      info	[Changelog]   - Enum KnownBackupItemType has a new value SAPHanaDBInstance
      info	[Changelog]   - Enum KnownBackupType has a new value SnapshotCopyOnlyFull
      info	[Changelog]   - Enum KnownBackupType has a new value SnapshotFull
      info	[Changelog]   - Enum KnownContainerType has a new value HanaHSRContainer
      info	[Changelog]   - Enum KnownDataSourceType has a new value SAPHanaDBInstance
      info	[Changelog]   - Enum KnownPolicyType has a new value SnapshotCopyOnlyFull
      info	[Changelog]   - Enum KnownPolicyType has a new value SnapshotFull
      info	[Changelog]   - Enum KnownRestorePointQueryType has a new value SnapshotCopyOnlyFull
      info	[Changelog]   - Enum KnownRestorePointQueryType has a new value SnapshotFull
      info	[Changelog]   - Enum KnownRestorePointType has a new value SnapshotCopyOnlyFull
      info	[Changelog]   - Enum KnownRestorePointType has a new value SnapshotFull
      info	[Changelog]   - Enum KnownWorkloadItemType has a new value SAPHanaDBInstance
      info	[Changelog]   - Enum KnownWorkloadType has a new value SAPHanaDBInstance
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Operation ResourceGuardProxy.put has a new signature
      info	[Changelog]   - Enum KnownContainerType no longer has value AzureWorkloadContainer
      info	[Changelog]   - Enum KnownContainerType no longer has value MicrosoftClassicComputeVirtualMachines
      info	[Changelog]   - Enum KnownContainerType no longer has value MicrosoftComputeVirtualMachines
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from ab1aa33c1572712736274b8266753f1393ef511c. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️recoveryservicesbackup [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from ab1aa33c1572712736274b8266753f1393ef511c. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.recoveryservicesbackup [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 3, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-recoveryservicesbackup Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-recoveryservicesbackup Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-recoveryservicesbackup Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @pratimaupadhyay02, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @@ -28,7 +28,7 @@ These are the global settings for the RecoveryServicesBackup API.
    title: Recovery Services Backup Client
    description: Open API 2.0 Specs for Azure RecoveryServices Backup service
    openapi-type: arm
    tag: package-2022-06-01-preview
    tag: package-preview-2022-09
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Why not follow previous convention package-2022-06-01-preview?

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi @raych1 the tool that we used to generate the new version on top of previous followed this convention. Should I update it to the older format ?

    @dw511214992
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @@ -57,9 +57,9 @@ message-format: json

    ### Tag: package-preview-2022-09
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    package-2022-09-preview

    @msyyc msyyc requested a review from Wzb123456789 as a code owner October 13, 2022 10:07
    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Oct 14, 2022
    @tadelesh
    Copy link
    Member

    Approved for Go breaking changes because it is a preview version.

    @jianyexi
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @dw511214992
    Copy link
    Member

    close this PR as the duplicated one #21142 has been merged.

    @hiaga
    Copy link
    Member

    hiaga commented Oct 17, 2022

    merged by - #21142

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants