Skip to content

[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version preview/2022-05-01-privatepreview #21223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PurnaChandraRaoK
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @PurnaChandraRaoK Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @ghost ghost added the PostgreSQL label Oct 21, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 21, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 11 Errors, 26 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.1)] new version base version
    Databases.json 2022-05-01-privatepreview(e005c57) 2021-06-01(main)
    Databases.json 2022-05-01-privatepreview(e005c57) 2022-03-08-preview(main)
    Migrations.json 2022-05-01-privatepreview(e005c57) 2021-06-15-privatepreview(main)
    PrivateDnsZone.json 2022-05-01-privatepreview(e005c57) 2021-06-01(main)
    PrivateDnsZone.json 2022-05-01-privatepreview(e005c57) 2022-03-08-preview(main)
    postgresql.json 2022-05-01-privatepreview(e005c57) 2021-06-01(main)
    postgresql.json 2022-05-01-privatepreview(e005c57) 2022-01-20-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1815:9
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1745:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1824:9
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1762:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1560:9
    Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1489:9


    The following breaking changes are detected by comparison with the latest preview version:

    Only 18 items are listed, please refer to log for more details.

    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AADApp' removed or renamed?
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L340:3
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L337:3
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'aadApp' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L577:7
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L523:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'userAssignedIdentityResourceId' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L363:7
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L360:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'userAssignedIdentityResourceId' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L495:7
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L466:7
    1036 - ConstraintChanged The new version has a different 'maxItems' value than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L405:9
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L399:9
    1036 - ConstraintChanged The new version has a different 'maxItems' value than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L508:9
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L476:9
    1037 - ConstraintIsWeaker The new version has a less constraining 'maxItems' value than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L405:9
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L399:9
    1037 - ConstraintIsWeaker The new version has a less constraining 'maxItems' value than the previous one.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L508:9
    Old: Microsoft.DBforPostgreSQL/preview/2021-06-15-privatepreview/Migrations.json#L476:9
    ⚠️ 1014 - RemovingHeader The new version removs a required header 'Location'.
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L91:15
    ⚠️ 1014 - RemovingHeader The new version removs a required header 'Location'.
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L143:15
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L93:13
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L98:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L294:9
    Old: common-types/resource-management/v3/types.json#L305:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v1/types.json#L308:11
    Old: common-types/resource-management/v3/types.json#L280:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L140:13
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L153:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L184:13
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L200:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L226:13
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/Databases.json#L242:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/PrivateDnsZone.json#L63:13
    Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/PrivateDnsZone.json#L63:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/PrivateDnsZone.json#L80:9
    Old: common-types/resource-management/v3/types.json#L305:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 4 Errors, 42 Warnings failed [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-05-01-privatepreview package-2022-05-01-privatepreview(e005c57) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Only 18 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'DBsToTiggerCutoverOn', for definition: 'MigrationResourceProperties' must follow camelCase style. Example: 'dBsToTiggerCutoverOn'.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L432
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'DBsToCancelMigrationOn', for definition: 'MigrationResourceProperties' must follow camelCase style. Example: 'dBsToCancelMigrationOn'.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L443
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'DBsToTiggerCutoverOn', for definition: 'MigrationResourcePropertiesForPatch' must follow camelCase style. Example: 'dBsToTiggerCutoverOn'.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L535
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'DBsToCancelMigrationOn', for definition: 'MigrationResourcePropertiesForPatch' must follow camelCase style. Example: 'dBsToCancelMigrationOn'.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L546
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MigrationResourceProperties' for property 'migrationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L364
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: setupLogicalReplicationOnSourceDBIfNeeded
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L415
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: overwriteDBsInTarget
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L418
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startDataMigration
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L425
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: triggerCutover
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L428
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cancel
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L439
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: setupLogicalReplicationOnSourceDBIfNeeded
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L518
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: overwriteDBsInTarget
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L521
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startDataMigration
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L528
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: triggerCutover
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L531
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cancel
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L542
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L775
    ⚠️ R3027 - TrackedResourceListByResourceGroup The tracked resource, 'MigrationResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L341
    ⚠️ R3028 - TrackedResourceListBySubscription The tracked resource, 'MigrationResource', must have a list by subscriptions operation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L341


    The following errors/warnings exist before current PR submission:

    Only 18 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'LocationBasedCapabilitiesExecute' response has model definition 'x-ms-pageable', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1006
    ⚠️ R1005 - GetInOperationName 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1006
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'Configurations_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L903
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1092
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L961
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'VirtualNetworkSubnetUsage_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1048
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getprivatednszonesuffix' in:'GetPrivateDnsZoneSuffix_Execute'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/PrivateDnsZone.json#L42
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: geoBackupSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1401
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundantHaSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1406
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundantHaAndGeoBackupSupported
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1411
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDynamicConfig
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L2066
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isReadOnly
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L2071
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isConfigPendingRestart
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L2076
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L2171
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L2245
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: restartWithFailover
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L2279
    ⚠️ R4021 - DescriptionAndTitleMissing 'delegatedSubnetsUsage' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1139
    ⚠️ R4021 - DescriptionAndTitleMissing 'supportedVcores' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L1247
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌ModelValidation: 20 Errors, 0 Warnings failed [Detail]

    Only 18 items are listed, please refer to log for more details.

    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L128:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/DatabaseDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L137:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerUpdate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L137:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerUpdateWithCustomerMaintenanceWindow.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L181:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L362:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerRestart.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L362:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerRestartWithFailover.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L405:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerStart.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L448:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerStop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L646:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/FirewallRuleDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L880:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ConfigurationUpdate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Databases.json#L128:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/DatabaseDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L137:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerUpdate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L137:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerUpdateWithCustomerMaintenanceWindow.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L181:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L362:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerRestart.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L362:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerRestartWithFailover.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L405:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerStart.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/postgresql.json#L448:22
    ExampleUrl: preview/2022-05-01-privatepreview/examples/ServerStop.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️❌SpellCheck: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Unknown word (Tigger), please fix the error or add words to ./custom-words.txt
    path: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L432:15
    HowToFix Unknown word (Tigger), please fix the error or add words to ./custom-words.txt
    path: Microsoft.DBforPostgreSQL/preview/2022-05-01-privatepreview/Migrations.json#L535:15
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 21, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from bb79e012b8356534e502f09706296a7ff9f7e3ce. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.PostgreSql [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from bb79e012b8356534e502f09706296a7ff9f7e3ce. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group AdministratorsOperations
      info	[Changelog]   - Added operation group CheckNameAvailabilityWithLocationOperations
      info	[Changelog]   - Model CapabilityProperties has a new parameter fast_provisioning_supported
      info	[Changelog]   - Model CapabilityProperties has a new parameter supported_fast_provisioning_editions
      info	[Changelog]   - Model ErrorResponse has a new parameter error
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model Server has a new parameter auth_config
      info	[Changelog]   - Model Server has a new parameter data_encryption
      info	[Changelog]   - Model Server has a new parameter identity
      info	[Changelog]   - Model Server has a new parameter replica_capacity
      info	[Changelog]   - Model Server has a new parameter replication_role
      info	[Changelog]   - Model ServerForUpdate has a new parameter auth_config
      info	[Changelog]   - Model ServerForUpdate has a new parameter data_encryption
      info	[Changelog]   - Model ServerForUpdate has a new parameter identity
      info	[Changelog]   - Model ServerForUpdate has a new parameter version
      info	[Changelog]   - Model ServerVersionCapability has a new parameter supported_versions_to_upgrade
      info	[Changelog]   - Model Sku has a new parameter capacity
      info	[Changelog]   - Model Sku has a new parameter family
      info	[Changelog]   - Model Sku has a new parameter size
      info	[Changelog]   - Model StorageMBCapability has a new parameter supported_upgradable_tier_list
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]   - Model UserAssignedIdentity has a new parameter user_assigned_identities
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model DataEncryption no longer has parameter geo_backup_key_uri
      info	[Changelog]   - Model DataEncryption no longer has parameter geo_backup_user_assigned_identity_id
      info	[Changelog]   - Model ErrorResponse no longer has parameter additional_info
      info	[Changelog]   - Model ErrorResponse no longer has parameter code
      info	[Changelog]   - Model ErrorResponse no longer has parameter details
      info	[Changelog]   - Model ErrorResponse no longer has parameter message
      info	[Changelog]   - Model ErrorResponse no longer has parameter target
      info	[Changelog]   - Model ServerForUpdate no longer has parameter location
      info	[Changelog]   - Model UserAssignedIdentity has a new required parameter type
      info	[Changelog]   - Model UserAssignedIdentity no longer has parameter client_id
      info	[Changelog]   - Model UserAssignedIdentity no longer has parameter principal_id
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from bb79e012b8356534e502f09706296a7ff9f7e3ce. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '�[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/postgresql/armpostgresql�[0m
      cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/postgresql/armpostgresql, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/postgresql/armpostgresql
      cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/postgresql/armpostgresql
      cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/postgresql/armpostgresql
      cmderr	[generator automation-v2] [ERROR] autorest --version=3.8.2 --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/postgresql/armpostgresql --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
      cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v14.20.1]
      cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
      cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
      cmderr	[generator automation-v2] [ERROR] info    | AutoRest core version selected from configuration: 3.8.2.
      cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.6.2).
      cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.8.2)
      cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.44 -> 4.0.0-preview.44)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.44->4.0.0-preview.44)
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.23.1 -> 4.23.1)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.23.1->4.23.1)
      cmderr	[generator automation-v2] [ERROR] error   | [Exception] No input files provided.
      cmderr	[generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation
      cmderr	[generator automation-v2] [ERROR] error   |   Error: [Exception] No input files provided.
      cmderr	[generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation
      cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
      cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
      cmderr	[generator automation-v2] [ERROR] ': exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from bb79e012b8356534e502f09706296a7ff9f7e3ce. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from bb79e012b8356534e502f09706296a7ff9f7e3ce. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️postgresql [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from bb79e012b8356534e502f09706296a7ff9f7e3ce. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.PostgreSql [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 21, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-rdbms Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-postgresqlflexibleserver Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.PostgreSql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @PurnaChandraRaoK
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Oct 21, 2022
    @openapi-workflow-bot
    Copy link

    Hi @PurnaChandraRaoK, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PostgreSQL resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants