Skip to content

Fixing Documentation +Bugs on PublicIPAddress & DdosProtectionPlan Resources #21300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 6 commits into from
Nov 2, 2022
Merged

Fixing Documentation +Bugs on PublicIPAddress & DdosProtectionPlan Resources #21300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0cedaa
small fix
Oct 26, 2022
cf9b7ec
bug fix
Oct 28, 2022
e4ca209
some model validation fixes
Oct 31, 2022
1cf1d1c
more model validation fixes?
Oct 31, 2022
bea517c
more fixes
Oct 31, 2022
9ae0172
fixed prettier
Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...tion/network/resource-manager/Microsoft.Network/stable/2022-07-01/ddosProtectionPlan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@
"description": "Request successful. Resource does not exist."
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URL of the resource used to check the status of the asynchronous operation.",
"type": "string"
}
}
},
"200": {
"description": "Delete successful."
Expand Down Expand Up @@ -404,7 +410,7 @@
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the DDoS protection plan resource."
},
"publicIpAddresses": {
"publicIPAddresses": {
"readOnly": true,
"type": "array",
"items": {
Expand Down
4 changes: 2 additions & 2 deletions ...source-manager/Microsoft.Network/stable/2022-07-01/examples/DdosProtectionPlanCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [],
"publicIPAddresses": [],
"virtualNetworks": []
}
}
Expand All @@ -33,7 +33,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [],
"publicIPAddresses": [],
"virtualNetworks": []
}
}
Expand Down
6 changes: 5 additions & 1 deletion ...source-manager/Microsoft.Network/stable/2022-07-01/examples/DdosProtectionPlanDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/SampleRG/providers/Microsoft.Network/locations/tempLocation/operationResults/00000000-0000-0000-0000-000000000000?api-version=2022-07-01"
}
},
"204": {}
}
}
2 changes: 1 addition & 1 deletion .../resource-manager/Microsoft.Network/stable/2022-07-01/examples/DdosProtectionPlanGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [
"publicIPAddresses": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/test-pip"
}
Expand Down
4 changes: 2 additions & 2 deletions ...resource-manager/Microsoft.Network/stable/2022-07-01/examples/DdosProtectionPlanList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [
"publicIPAddresses": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/test-pip"
}
Expand All @@ -36,7 +36,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [
"publicIPAddresses": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/test-pip"
}
Expand Down
4 changes: 2 additions & 2 deletions ...ource-manager/Microsoft.Network/stable/2022-07-01/examples/DdosProtectionPlanListAll.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [
"publicIPAddresses": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/test-pip"
}
Expand All @@ -35,7 +35,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [
"publicIPAddresses": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/publicIPAddresses/test-pip2"
},
Expand Down
2 changes: 1 addition & 1 deletion ...ce-manager/Microsoft.Network/stable/2022-07-01/examples/DdosProtectionPlanUpdateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-000000000000",
"publicIpAddresses": [],
"publicIPAddresses": [],
"virtualNetworks": []
}
}
Expand Down
6 changes: 5 additions & 1 deletion .../resource-manager/Microsoft.Network/stable/2022-07-01/examples/PublicIpAddressDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/SampleRG/providers/Microsoft.Network/locations/tempLocation/operationResults/00000000-0000-0000-0000-000000000000?api-version=2022-07-01"
}
},
"204": {}
}
}
6 changes: 5 additions & 1 deletion .../Microsoft.Network/stable/2022-07-01/examples/PublicIpAddressGetDdosProtectionStatus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"ddosProtectionPlanId": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/ddosProtectionPlans/test-plan"
}
},
"202": {}
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/SampleRG/providers/Microsoft.Network/locations/tempLocation/operationResults/00000000-0000-0000-0000-000000000000?api-version=2022-07-01"
}
}
}
}
21 changes: 18 additions & 3 deletions ...ication/network/resource-manager/Microsoft.Network/stable/2022-07-01/publicIpAddress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@
"description": "Request successful. Resource does not exist."
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URL of the resource used to check the status of the asynchronous operation.",
"type": "string"
}
}
},
"200": {
"description": "Delete successful."
Expand Down Expand Up @@ -363,7 +369,10 @@
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/publicIPAddresses/{publicIpAddressName}/ddosProtectionStatus": {
"post": {
"operationId": "PublicIpAddresses_DdosProtectionStatus",
"tags": [
"PublicIPAddresses"
],
"operationId": "PublicIPAddresses_DdosProtectionStatus",
"description": "Gets the Ddos Protection Status of a Public IP Address",
"parameters": [
{
Expand Down Expand Up @@ -395,7 +404,13 @@
}
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URL of the resource used to check the status of the asynchronous operation.",
"type": "string"
}
}
},
"default": {
"description": "Error response describing why the operation failed.",
Expand Down