-
Notifications
You must be signed in to change notification settings - Fork 5.3k
mgmt release planner test #22119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dw511214992
wants to merge
2
commits into
main
Choose a base branch
from
dw/test-relase-planner-mgmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
mgmt release planner test #22119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @dw511214992 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
databoxedge.json | 2022-03-01(7931313) | 2022-03-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2022-03-01 | package-2022-03-01(7931313) | package-2022-03-01(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L188 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L189 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L236 |
DeleteOperationAsyncResponseValidation |
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L292 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L292 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L320 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L340 |
PatchSkuProperty |
The patch operation body parameter schema should contains property 'sku'. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L354 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L394 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L395 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L443 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L444 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L496 |
ParametersOrder |
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L497 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L545 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L546 |
CreateOperationAsyncResponseValidation |
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L597 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L597 |
CreateOperationAsyncResponseValidation |
An async PUT operation must return 201. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L637 |
CreateOperationAsyncResponseValidation |
Only 201 is the supported response code for PUT async response. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L644 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L644 |
DeleteOperationAsyncResponseValidation |
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L661 |
ParametersOrder |
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L661 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L696 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L717 |
PostOperationAsyncResponseValidation |
An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L718 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L759 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L783 |
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'DeviceCapacityInfo' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L789 |
ResourceNameRestriction |
The resource name parameter 'deviceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L829 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
~[Staging] CadlAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 27 Errors, 0 Warnings failed [Detail]
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jan 10, 2023
[AutoPR track2_azure-mgmt-databoxedge] mgmt release planner test
azure-sdk/azure-sdk-for-python#2502
Closed
suppress model validation |
This was referenced Jan 10, 2023
Suppression for model validation |
test |
This was referenced Jan 12, 2023
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APIStewardshipBoard-SignedOff
The Azure API Stewardship team has reviewed and approved the changes.
Approved-OkToMerge
<valid label in PR review process>add this label when assignee approve to merge the updates
Approved-SdkBreakingChange-Go
Approve the breaking change tracking for azure-sdk-for-go
Approved-SdkBreakingChange-JavaScript
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
CI-BreakingChange-Go
CI-BreakingChange-JavaScript
commitAfterSignedOff
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.