Skip to content

Release Dev sql microsoft.sql 2022 08 01 preview #22598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0ac66b9
Create 2022-08-01-preview dev branch (#20891)
ericshape Sep 28, 2022
9877f88
generate swagger file for replicationLink V20220801 (#20945)
chozhou Oct 12, 2022
fa38f89
Swagger changes for managed database with ledger (#21576)
paramsiva1 Nov 23, 2022
62f6362
Adding Managed Instance ServerConfigurationOptions API (#21415)
OgnjenArsenijevic Nov 28, 2022
3f40b0a
add a field to create update api getter (#21621)
guptanitish-ms Dec 1, 2022
f788787
Swagger Validations for API Changes in Serverless elastic pool (#21699)
Yashu1818 Dec 5, 2022
2395d23
Swagger fix for ledger in MI (#21902)
paramsiva1 Dec 16, 2022
7cb4f33
Swagger changes for new ledgerDigestUploads API for Managed Instance …
vaibhaot Dec 16, 2022
27164e6
Update errors (#21893)
OgnjenArsenijevic Dec 19, 2022
766c12c
Swagger API changes to support manual-cutover in Hyperscale Migration…
mohitagarwal-sql Dec 20, 2022
eb945f8
Adding availability zone & zone pinning parameters (#21958)
athreya-geetha Dec 22, 2022
4c09514
SQL MI Manual and Scheduled Start/Stop APIs (#21376)
mmaricic-microsoft Dec 22, 2022
95fcf44
[2022-08-01] Elastic Pool ARM API swagger changes for vbs enclaves (#…
vidit-msft Dec 24, 2022
edf870e
[TDE] Swagger changes for Per Database CMK apis (#21973)
viparek Dec 24, 2022
3194301
Add API action to refresh external governance status. (#21946)
guptanitish-ms Jan 6, 2023
e545930
Update readme.md (#22057)
viparek Jan 10, 2023
c0dd599
Carry all minor changes to dev sql microsoft.sql 2022 08 01 preview (…
ericshape Feb 10, 2023
c8fe1ba
Sync main branch to Dev sql microsoft.sql 2022 08 01 preview (no chan…
ericshape Feb 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion .azure-pipelines/azure-pipelines-data-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ schedules:
always: true

pool:
vmImage: 'Ubuntu-20.04'
vmImage: 'Ubuntu-22.04'

variables:
IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]
Expand Down
32 changes: 31 additions & 1 deletion .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@
openapiHub: https://portal.azure-devex-tools.com
onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you want to know the production traffic statistic, please see [ARM Traffic statistic](${openapiHub}/api/pr/query-traffic?pr=${owner}/${repo}/${PRNumber}&days=5). </br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. </br> **Note**: To avoid breaking change, you can refer to [Shift Left Solution](https://aka.ms/shiftleft) for detecting breaking change in early phase at your service code repository."

- rule:
type: label
label: SuppressionReviewRequired
onLabeledComments: "Hi @${PRAuthor}, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the [Swagger-Suppression-Process](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process) to get approval."

- rule:
type: label
label: "CI-MissingBaseCommit"
onLabeledComments: "Hi, @${PRAuthor}, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version). Or you could onboard [API spec pipeline](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/606/Enable-API-Spec-Pipeline)"

- rule:
type: label
repoAllowList:
Expand All @@ -31,6 +41,21 @@
label: NewApiVersionRequired
onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features. "

- rule:
type: label
label: CI-NewRPNamespaceWithoutRPaaS
onLabeledComments: "Hi @${PRAuthor} This PR was flagged for introducing a new RP namespace that is not being onboarded with [RPaaS](https://armwiki.azurewebsites.net/rpaas/overview.html). Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please [use RPaaS to onboard the new RP](https://armwiki.azurewebsites.net/rpaas/gettingstarted.html)."

- rule:
type: label
label: CI-RpaaSRPNotInPrivateRepo
onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main."

- rule:
type: label
label: ArcReview
onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected]."

- rule:
type: label
label: CI-FixRequiredOnFailure
Expand All @@ -43,6 +68,11 @@
<tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md#linter-validation)</td><td>high</td></tr></table>
If you need further help, please feedback via [swagger feedback](https://aka.ms/swaggerfeedback).

- rule:
type: label
label: new-rp-namespace
onLabeledComments: "Hi, @{PRAuthor}, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. </br> <b>Action Required</b>: <li> Follow this guidance [Naming for new initial management or client libraries (new SDKs) - Overview (azure.com)](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/821/Naming-for-new-initial-management-or-client-libraries-(new-SDKs)) to create an issue for management client library name arch board review. </li> <li>Paste the issue link that you created in step 1 in this PR</li> </br> <b> Impact</b>: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed."

- rule:
type: PROpen
variables:
Expand Down Expand Up @@ -81,7 +111,7 @@
- rule:
type: label
label: Approved-BreakingChange
booleanFilterExpression: !(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview
booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

Expand Down
51 changes: 49 additions & 2 deletions .github/fabricbot.json
Original file line number Diff line number Diff line change
Expand Up @@ -2362,7 +2362,6 @@
"Search"
],
"mentionees": [
"brjohnstmsft",
"bleroy",
"tjacobhi",
"markheff",
Expand Down Expand Up @@ -3123,6 +3122,12 @@
"label": "no-recent-activity"
}
},
{
"name": "noLabel",
"parameters": {
"label": "customer-reported"
}
},
{
"name": "isPr",
"parameters": {}
Expand Down Expand Up @@ -3225,6 +3230,12 @@
"parameters": {
"days": 14
}
},
{
"name": "noLabel",
"parameters": {
"label": "customer-reported"
}
}
],
"taskName": "Close stale PR (no update for 30 days)",
Expand Down Expand Up @@ -4163,6 +4174,33 @@
""
]
},
{
"label": "Load Test Service",
"pathFilter": [
"specification/loadtestservice/"
],
"exclude": [
""
]
},
{
"label": "Maps",
"pathFilter": [
"specification/maps/"
],
"exclude": [
""
]
},
{
"label": "Purview",
"pathFilter": [
"specification/purview/"
],
"exclude": [
""
]
},
{
"label": "TimeseriesInsights",
"pathFilter": [
Expand Down Expand Up @@ -4198,6 +4236,15 @@
"exclude": [
""
]
},
{
"label": "ArcReview",
"pathFilter": [
"specification/hybridcompute/resource-manager/",
"specification/connectedvmware/resource-manager/",
"specification/azurestackhci/resource-manager/",
"specification/scvmm/resource-manager/"
]
}
],
"taskName": "Auto PR based on folder paths "
Expand Down Expand Up @@ -4874,4 +4921,4 @@
]
}
]
}
}
36 changes: 31 additions & 5 deletions .github/pull_request_assignment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,28 @@
- "specification/cognitiveservices/data-plane/TranslatorText/**"
reviewers:
- kristapratico
- maririos

- rule:
# Cognitive Services - Language pillar data-plane PR
paths:
- "specification/cognitiveservices/data-plane/Language/**"
reviewers:
- kristapratico
- heaths

- rule:
# Key Vault data-plane PR
paths:
- "specification/keyvault/data-plane/**"
reviewers:
- heaths

- rule:
paths:
- "specification/confidentialledger/data-plane/**"
reviewers:
- christothes


- rule:
# eventgrid data-plane PR
paths:
Expand Down Expand Up @@ -74,11 +87,25 @@


- rule:
paths: "specification/@(providerhub|sql|appplatform|deviceupdate|servicelinker|imagebuilder|throttling|secretmanagementtestsvc)/**"
paths: "specification/@(providerhub|sql|appplatform|deviceupdate|servicelinker|imagebuilder|throttling|secretmanagementtestsvc|containerservice|azure-kusto)/**"
reviewers:
- raych1
- xiaoxuqi-ms

- rule:
paths: "specification/voiceservices/**"
reviewers:
- raych1
- xiaoxuqi-ms

- rule:
paths: "specification/@(financialdataservices|standbypool)/**"
reviewers:
- jianyexi
- xiaoxuqi-ms
branches:
- RPSaaSDev

- rule:
paths: "specification/sql/**"
reviewers:
Expand Down Expand Up @@ -200,7 +227,6 @@

- rule:
paths:
- "**/package.json"
- ".github/**"
- "**/azure-pipelines.yml"
- ".azure-pipelines/**"
Expand Down Expand Up @@ -229,6 +255,6 @@
- dw511214992
- honghr
- tianxchen-ms
- tadelesh
- xiaoxuqi-ms
- live1206
- tadelesh
16 changes: 16 additions & 0 deletions .github/sla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,22 @@
- ${AUTHOR}
- ${ASSIGNEE}


- scheduleTask:
action: sendEmail
scope: pull_request
name: "send email to Arc review board"
trigger:
- label
args:
booleanFilterExpression: "ArcReview"
message: "<p>Hi, Arc review board,</p><p>Please review the PR ${URL} . You receive the email because the PR is labeled with ArcReview. <br> One or more change(s) have been detected in your Arc enabled VM or Arc enabled Server RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), add the label ArcSignedOff.</p>"
subject: "Action Required ArcReview: Please review PR ${URL}"
to: [email protected]
cc:
- ${AUTHOR}
- ${ASSIGNEE}

- scheduleTask:
action: sendEmail
scope: pull_request
Expand Down
Loading