-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[DO NOT MERGE] Some changes to network/2022-01-01 #22731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ZengTaoxu
wants to merge
1
commit into
Azure:main
Choose a base branch
from
ZengTaoxu:network
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @ZengTaoxu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
expressRoutePort.json | 2022-01-01(a6205ce) | 2022-01-01(main) |
privateEndpoint.json | 2022-01-01(a6205ce) | 2022-01-01(main) |
virtualNetworkGateway.json | 2022-01-01(a6205ce) | 2022-01-01(main) |
Rule | Message |
---|---|
1025 - RequiredStatusChange |
The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.Network/stable/2022-01-01/virtualNetworkGateway.json#L1115:11 Old: Microsoft.Network/stable/2022-01-01/virtualNetworkGateway.json#L1115:11 |
1025 - RequiredStatusChange |
The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.Network/stable/2022-01-01/virtualNetworkGateway.json#L1715:11 Old: Microsoft.Network/stable/2022-01-01/virtualNetworkGateway.json#L1715:11 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2022-01 | package-2022-01(a6205ce) | package-2022-01(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Network/ExpressRoutePortsLocations' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L37 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Network/ExpressRoutePortsLocations/{locationName}' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L76 |
ResourceNameRestriction |
The resource name parameter 'locationName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L76 |
TrackedResourcePatchOperation |
Tracked resource 'ExpressRoutePortsLocation' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L76 |
TrackedResourcesMustHavePut |
The tracked resource ExpressRoutePortsLocation does not have a corresponding put operation. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L76 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ExpressRoutePorts/{expressRoutePortName}' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L119 |
ResourceNameRestriction |
The resource name parameter 'expressRoutePortName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L119 |
LongRunningResponseStatusCode |
A 'delete' operation 'ExpressRoutePorts_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L120 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L152 |
PatchIdentityProperty |
The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L320 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ExpressRoutePorts' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L351 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Network/ExpressRoutePorts' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L397 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ExpressRoutePorts/{expressRoutePortName}/links/{linkName}' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L436 |
ResourceNameRestriction |
The resource name parameter 'expressRoutePortName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L436 |
ResourceNameRestriction |
The resource name parameter 'linkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L436 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ExpressRoutePorts/{expressRoutePortName}/links' Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L493 |
ResourceNameRestriction |
The resource name parameter 'expressRoutePortName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L493 |
ResourceNameRestriction |
The resource name parameter 'expressRoutePortName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L546 |
ResourceNameRestriction |
The resource name parameter 'expressRoutePortName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L605 |
ResourceNameRestriction |
The resource name parameter 'authorizationName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L605 |
LongRunningResponseStatusCode |
A 'delete' operation 'ExpressRoutePortAuthorizations_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L606 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L645 |
ResourceNameRestriction |
The resource name parameter 'expressRoutePortName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L798 |
MissingTypeObject |
The schema 'ExpressRoutePortsLocationBandwidths' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L853 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L862 |
MissingTypeObject |
The schema 'ExpressRoutePortsLocationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L869 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L883 |
MissingTypeObject |
The schema 'ExpressRoutePortsLocation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L897 |
RequiredPropertiesMissingInResourceModel |
Model definition 'ExpressRoutePortsLocation' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L897 |
MissingTypeObject |
The schema 'ExpressRoutePortsLocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-01-01/expressRoutePort.json#L913 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 49 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
PrettierCheck: 3 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Code style issues found path: Microsoft.Network/stable/2022-01-01/expressRoutePort.json |
HowToFix |
Code style issues found path: Microsoft.Network/stable/2022-01-01/privateEndpoint.json |
HowToFix |
Code style issues found path: Microsoft.Network/stable/2022-01-01/virtualNetworkGateway.json |
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=348119&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Unable to load the service index for source https://apidrop.pkgs.visualstudio.com/_packaging/ReferenceAutomationTool/nuget/v3/index.json." |
️❌
SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌
azure-sdk-for-js - @azure/arm-network - 31.0.0+ Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken + Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top + Interface AdminRulesListNextOptionalParams no longer has parameter skipToken + Interface AdminRulesListNextOptionalParams no longer has parameter top + Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken + Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top + Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken + Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top + Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken + Interface NetworkGroupsListNextOptionalParams no longer has parameter top + Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand + Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken + Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top + Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken + Interface NetworkManagersListNextOptionalParams no longer has parameter top + Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken + Interface ScopeConnectionsListNextOptionalParams no longer has parameter top + Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken + Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top + Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes + Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName + Interface StaticMembersListNextOptionalParams no longer has parameter skipToken + Interface StaticMembersListNextOptionalParams no longer has parameter top + Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken + Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top + Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken + Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top
️️✔️
azure-sdk-for-net succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from ce4215175bab521e562117468007cca06eebe4c0. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️
Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
️️✔️
azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from ce4215175bab521e562117468007cca06eebe4c0. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️
Azure.ResourceManager.Network [View full logs] [Preview SDK Changes]info [Changelog]
️🔄
azure-sdk-for-python-track2 inProgress [Detail]
️️✔️
azure-sdk-for-java succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from ce4215175bab521e562117468007cca06eebe4c0. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️
azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from ce4215175bab521e562117468007cca06eebe4c0. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from ce4215175bab521e562117468007cca06eebe4c0. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️
@azure/arm-network [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface AdminRulesListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AdminRulesListNextOptionalParams no longer has parameter top info [Changelog] - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top info [Changelog] - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkGroupsListNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand info [Changelog] - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkManagersListNextOptionalParams no longer has parameter top info [Changelog] - Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ScopeConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top info [Changelog] - Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes info [Changelog] - Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName info [Changelog] - Interface StaticMembersListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface StaticMembersListNextOptionalParams no longer has parameter top info [Changelog] - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top
️🔄
azure-resource-manager-schemas inProgress [Detail]
️❌
azure-powershell failed [Detail]
❌
Failed [Logs] Generate from ce4215175bab521e562117468007cca06eebe4c0. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌
Az.network [View full logs] [Preview SDK Changes]
Generated ApiView
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.