Skip to content

User/tarsharm/off azure20221027 #22740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 85 commits into
base: main
Choose a base branch
from
Draft

Conversation

tarsharm
Copy link
Contributor

@tarsharm tarsharm commented Feb 22, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tarsharm Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 22, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 123 Errors, 32 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    migrate.json 2023-06-06(366b9a8) 2020-07-07(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L44:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L188:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L256:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L400:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs/{jobName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L468:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L534:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines/{machineName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L596:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L662:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/operationsStatus/{operationStatusName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L752:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/runAsAccounts/{accountName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L818:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/runAsAccounts' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L884:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L946:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/refresh' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1210:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/healthSummary' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1272:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/jobs/{jobName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1334:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/jobs' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1400:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines/{machineName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1462:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1528:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines/{machineName}/stop' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1618:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines/{machineName}/start' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1687:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/runAsAccounts/{accountName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1756:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/runAsAccounts' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1822:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1884:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/refresh' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2148:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/healthSummary' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2210:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/vCenters/{vcenterName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2272:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/vCenters' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2480:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/operationsStatus/{operationStatusName}' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2548:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/summary' removed or restructured?
    Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2614:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-06 package-2023-06(366b9a8) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[NotRequired_Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️❌TypeSpecAPIView: 0 Errors, 2 Warnings failed [Detail]
    Rule Message
    ⚠️ Failed to generate TypeSpec APIView. Please check the detail log and make sure TypeSpec compiler version is the latest. "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR."
    ⚠️ Failed to generate TypeSpec APIView. Please check the detail log and make sure TypeSpec compiler version is the latest. "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR."
    ️❌ModelValidation: 124 Errors, 0 Warnings failed [Detail]

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15532:19
    ExampleUrl: stable/2023-06-06/examples/HypervSites_ListBySubscription_MinimumSet_Gen.json#L12:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16462:19
    ExampleUrl: stable/2023-06-06/examples/ImportSitesController_ListBySubscription_MinimumSet_Gen.json#L12:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16852:19
    ExampleUrl: stable/2023-06-06/examples/MasterSitesController_ListBySubscription_MinimumSet_Gen.json#L12:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L18114:27
    ExampleUrl: stable/2023-06-06/examples/ServerSitesController_ListBySubscription_MinimumSet_Gen.json#L12:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L21843:19
    ExampleUrl: stable/2023-06-06/examples/SitesController_ListBySubscription_MinimumSet_Gen.json#L12:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15532:19
    ExampleUrl: stable/2023-06-06/examples/HypervSites_ListByResourceGroup_MinimumSet_Gen.json#L13:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15532:19
    ExampleUrl: stable/2023-06-06/examples/HypervSitesController_Get_MinimumSet_Gen.json#L12:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15532:19
    ExampleUrl: stable/2023-06-06/examples/HypervSitesController_Create_MinimumSet_Gen.json#L15:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15532:19
    ExampleUrl: stable/2023-06-06/examples/HypervSitesController_Create_MinimumSet_Gen.json#L20:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L14736:22
    ExampleUrl: stable/2023-06-06/examples/HypervClusterController_ListByHypervSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L14873:19
    ExampleUrl: stable/2023-06-06/examples/HypervHostController_ListByHypervSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L14958:18
    ExampleUrl: stable/2023-06-06/examples/HypervJobs_ListByHypervSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15001:22
    ExampleUrl: stable/2023-06-06/examples/HypervMachinesController_ListByHypervSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15645:34
    ExampleUrl: stable/2023-06-06/examples/HypervSoftwareInventoriesController_ListByHypervMachine_MinimumSet_Gen.json#L15:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L15489:35
    ExampleUrl: stable/2023-06-06/examples/HypervRunAsAccountsController_ListByHypervSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16462:19
    ExampleUrl: stable/2023-06-06/examples/ImportSitesController_ListByResourceGroup_MinimumSet_Gen.json#L13:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16462:19
    ExampleUrl: stable/2023-06-06/examples/ImportSitesController_Get_MinimumSet_Gen.json#L12:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16462:19
    ExampleUrl: stable/2023-06-06/examples/ImportSitesController_Create_MinimumSet_Gen.json#L15:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16462:19
    ExampleUrl: stable/2023-06-06/examples/ImportSitesController_Create_MinimumSet_Gen.json#L20:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16115:18
    ExampleUrl: stable/2023-06-06/examples/ImportJobsController_ListByImportSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16158:22
    ExampleUrl: stable/2023-06-06/examples/ImportMachinesController_ListByImportSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16852:19
    ExampleUrl: stable/2023-06-06/examples/MasterSitesController_ListByResourceGroup_MinimumSet_Gen.json#L13:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16852:19
    ExampleUrl: stable/2023-06-06/examples/MasterSitesController_Get_MinimumSet_Gen.json#L12:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16852:19
    ExampleUrl: stable/2023-06-06/examples/MasterSitesController_Create_MinimumSet_Gen.json#L15:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L16852:19
    ExampleUrl: stable/2023-06-06/examples/MasterSitesController_Create_MinimumSet_Gen.json#L23:15
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L17250:34
    ExampleUrl: stable/2023-06-06/examples/PrivateEndpointConnectionController_ListByMasterSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L17322:28
    ExampleUrl: stable/2023-06-06/examples/PrivateLinkResourcesController_ListByMasterSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L20120:16
    ExampleUrl: stable/2023-06-06/examples/SqlSitesController_ListByMasterSite_MinimumSet_Gen.json#L14:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L19363:35
    ExampleUrl: stable/2023-06-06/examples/SqlDiscoverySiteDataSourceController_ListBySqlSite_MinimumSet_Gen.json#L15:11
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️❌PrettierCheck: 788 Errors, 0 Warnings failed [Detail]

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_ClientGroupMembers_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_ClientGroupMembers_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_ExportDependencies_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_ExportDependencies_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_GenerateCoarseMap_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_GenerateCoarseMap_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_GenerateDetailedMap_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_GenerateDetailedMap_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_ServerGroupMembers_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/DependencyMapController_ServerGroupMembers_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_CreateCluster_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_CreateCluster_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_Delete_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_Delete_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_GetCluster_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_GetCluster_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_ListByHypervSite_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervClusterController_ListByHypervSite_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_ClientGroupMembers_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_ClientGroupMembers_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_ExportDependencies_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_ExportDependencies_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_GenerateCoarseMap_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_GenerateCoarseMap_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_GenerateDetailedMap_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_GenerateDetailedMap_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_ServerGroupMembers_MaximumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_ServerGroupMembers_MinimumSet_Gen.json
    HowToFix Code style issues found
    path: Migrate.Management/discovery/examples/HypervDependencyMapController_UpdateDependencyMapStatus_MaximumSet_Gen.json
    ️❌SpellCheck: 5 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Unknown word (Unsynchronized), please fix the error or add words to ./custom-words.txt
    path: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L19044:10
    HowToFix Unknown word (Unsynchronized), please fix the error or add words to ./custom-words.txt
    path: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L19061:22
    HowToFix Unknown word (Unsynchronized), please fix the error or add words to ./custom-words.txt
    path: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L19062:23
    HowToFix Unknown word (Unsynchronized), please fix the error or add words to ./custom-words.txt
    path: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L19063:29
    HowToFix Unknown word (Veriguration), please fix the error or add words to ./custom-words.txt
    path: Microsoft.OffAzure/stable/2023-06-06/migrate.json#L20712:40
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 22, 2023

    Swagger Generation Artifacts

    ️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=377760&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from 9b2ce3a. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn		specification/migrate/Migrate.Management/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
      warn		specification/migrate/Migrate.Management/discovery/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Migrate [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️❌ azure-sdk-for-go failed [Detail]
    • Code Generator Failed [Logs] Generate from 9b2ce3a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/migrate/Migrate.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
      warn		specification/migrate/Migrate.Management/discovery/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '�[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate�[0m
      cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/migrate/armmigrate, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
      cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
      cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate
      cmderr	[generator automation-v2] [ERROR] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
      cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v16.20.1]
      cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
      cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
      cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.6.3).
      cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.9.7)
      cmderr	[generator automation-v2] [ERROR] error   | [OperationAbortedException] Error occurred. Exiting.
      cmderr	[generator automation-v2] [ERROR] error   |   Error: [OperationAbortedException] Error occurred. Exiting.
      cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md:143:1
      cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md:142:1
      cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md:144:1
      cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md:142:1
      cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md:144:1
      cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: duplicate key
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md:143:1
      cmderr	[generator automation-v2] [ERROR] fatal   | Failed to acquire 'require'd configuration 'file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/migrate/resource-manager/readme.md'
      cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
      cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
      cmderr	[generator automation-v2] [ERROR] ': exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 9b2ce3a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cannot force update branch 'sdkAuto/22740/migrate_resource-manager' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/22740/migrate_resource-manager' as it is the current HEAD of the repository.
    • migrate/resource-manager [View full logs]  [Preview Schema Changes]
    • migrate/resource-manager [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/22740/migrate_resource-manager' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		migrate/resource-manager
      error		migrate/resource-manager
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 9b2ce3a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      warn		specification/migrate/Migrate.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
      warn		specification/migrate/Migrate.Management/discovery/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.migrate.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.migrate.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 22, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.OffAzure https://apiview.dev/Assemblies/Review/6327b7715fb24575bd56f96433d1a342

    @openapi-workflow-bot
    Copy link

    Hi @tarsharm, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @tarsharm, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @tarsharm, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @openapi-workflow-bot
    Copy link

    Hi @tarsharm This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP.

    @openapi-workflow-bot
    Copy link

    Hi, @{PRAuthor}, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved.
    Action Required:

  • Follow this guidance Naming for new initial management or client libraries (new SDKs) - Overview (azure.com) to create an issue for management client library name arch board review.
  • Paste the issue link that you created in step 1 in this PR

  • Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed.

    @tarsharm tarsharm marked this pull request as draft February 23, 2023 09:34
    @dw511214992
    Copy link
    Member

    dw511214992 commented Feb 24, 2023

    Please remove package.json and package-lock.json because we will use the common one specification/package.json. Thanks

    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Aug 2, 2023
    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Aug 3, 2023
    @openapi-workflow-bot
    Copy link

    Hi @tarsharm! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants