-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[Hub Generated] Review request for Microsoft.Migrate to add version stable/2023-03-03 #22803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Hub Generated] Review request for Microsoft.Migrate to add version stable/2023-03-03 #22803
Conversation
Hi, @kuchatur-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/9cc24f3a5a79c3166475b5c4849a7a118edb4c29/specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/stable/2019-10-01/migrate.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.56/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Schema violation: Data does not match any schemas from 'oneOf'\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json:3348:8 ( |
The following breaking changes are detected by comparison with the latest preview version:
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/9cc24f3a5a79c3166475b5c4849a7a118edb4c29/specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2017-11-11-preview/migrate.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.56/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Schema violation: Data does not match any schemas from 'oneOf'\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json:3348:8 ( |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
LintDiff succeeded [Detail]
Rule | Message |
---|---|
LintDiffToolException |
"details":""stack":"ResolverError: Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"\n at onError (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.56/common/temp/node_modules/.pnpm/@APIDevTools[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/parse.js:92:16)\n at processTicksAndRejections (internal/process/task_queues.js:95:5)", "code":"ERESOLVER", "message":"Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"", "source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json", "path":null, "name":"ResolverError", "footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json+ERESOLVER+Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\""" |
️❌
Avocado: 13 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Migrate/assessmentProjects is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessmentOptions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessmentOptions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/assessments is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/groups/{}/assessments/{}/downloadUrl is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/importcollectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentProjects/{}/importcollectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateEndpointConnections is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateEndpointConnections/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateLinkResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Migrate/assessmentprojects/{}/privateLinkResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/migrate/resource-manager/readme.md json: AssessmentProjects/stable/2019-10-01/migrate.json |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 34 Errors, 0 Warnings failed [Detail]
Only 23 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
PrettierCheck: 139 Errors, 0 Warnings failed [Detail]
Only 23 items are listed, please refer to log for more details.
️❌
SpellCheck: 37 Errors, 0 Warnings failed [Detail]
Only 23 items are listed, please refer to log for more details.
Rule | Message |
---|---|
HowToFix |
Unknown word (valus), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L488:68 |
HowToFix |
Unknown word (assessement), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L1292:37 |
HowToFix |
Unknown word (assessement), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L1821:33 |
HowToFix |
Unknown word (assessement), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L2350:33 |
HowToFix |
Unknown word (assessement), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L2506:33 |
HowToFix |
Unknown word (Assessible), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L3441:29 |
HowToFix |
Unknown word (sqlcollectors), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L4249:134 |
HowToFix |
Unknown word (sqlcollectors), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L4301:134 |
HowToFix |
Unknown word (wheter), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L5495:32 |
HowToFix |
Unknown word (wheter), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L5499:32 |
HowToFix |
Unknown word (Reasonings), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L5617:27 |
HowToFix |
Unknown word (Overcommit), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7004:13 |
HowToFix |
Unknown word (overcommit), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7007:34 |
HowToFix |
Unknown word (SSDE), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7378:30 |
HowToFix |
Unknown word (SSDE), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7382:30 |
HowToFix |
Unknown word (SSDE), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7386:30 |
HowToFix |
Unknown word (SSDE), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7390:30 |
HowToFix |
Unknown word (Recieved), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7648:25 |
HowToFix |
Unknown word (Recieved), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L7649:25 |
HowToFix |
Unknown word (Paas), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L8012:14 |
HowToFix |
Unknown word (PAAS), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L8060:52 |
HowToFix |
Unknown word (Ebds), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L8190:10 |
HowToFix |
Unknown word (Ebds), please fix the error or add words to ./custom-words.txt path: Microsoft.Migrate/stable/2023-03-03/migrate.json#L8401:22 |
️️✔️
Lint(RPaaS) succeeded [Detail]
Rule | Message |
---|---|
LintRpaasToolException |
"details":""stack":"ResolverError: Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"\n at onError (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.56/common/temp/node_modules/.pnpm/@APIDevTools[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/parse.js:92:16)", "code":"ERESOLVER", "message":"Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"", "source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json", "path":null, "name":"ResolverError", "footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json+ERESOLVER+Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\""" |
️❌
CadlValidation: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MissingCadlFile |
"details":"The swagger specification/migrate/resource-manager/Microsoft.Migrate/stable/2023-03-03/migrate.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️❌
PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️
All merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
/azp run unifiedPipeline |
No commit pushedDate could be found for PR 22803 in repo Azure/azure-rest-api-specs |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.