[Hub Generated] Publish private branch 'security/dahandaniel/seurityOperators' #23323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5849) * copy folder * Add autoAdd field * update readme * Add operation example * fix style Co-authored-by: Peter Shen <[email protected]>
…b.com/Azure/azure-rest-api-specs-pr into security/dahandaniel/seurityOperators
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/10406 |
|
Hi, @kerend Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-composite-v3 | package-composite-v3(6225b13) | package-composite-v3(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
The path for 'put' operation must be under a subscription and resource group. Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L76 |
RPC-Put-V1-01 |
| Based on the response model schema, operation 'SecurityOperators_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L38 |
||
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L49 |
||
| The response of operation:'SecurityOperators_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L77 |
||
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L88 |
||
| The response of operation:'SecurityOperators_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L117 |
||
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L128 |
||
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Security/preview/2023-01-01-preview/securityOperators.json#L168 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
This is a publish of a private PR - https://github.com/Azure/azure-rest-api-specs-pr/pull/10406 |
|
Hi @kerend, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 28, 2023
ruowan
approved these changes
Mar 28, 2023
chunyu3
reviewed
Mar 28, 2023
| @@ -85,6 +85,9 @@ tag: package-composite-v3 | |||
|
|
|||
| The following packages may be composed from multiple api-versions. | |||
|
|
|||
| ### Tag: package-preview-2023-01 | |||
|
|
|||
| These settings apply only when `--tag=package-preview-2023-01` is specified on the command line. | |||
There was a problem hiding this comment.
Why define an tag without any content?
chunyu3
added
Approved-SdkBreakingChange-Go
|
Hello @kerend .Net SDK generation failed because of 'Duplicate Schema' see https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2660098&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437&l=328. |
It published from private repo which is reviewed by arm, it does not need |
chunyu3
removed
WaitForARMFeedback
AzureRestAPISpecReview
added
the
WaitForARMFeedback
chunyu3
removed
the
WaitForARMFeedback
chunyu3
deleted the
published/Azure/azure-rest-api-specs-pr/security/dahandaniel/seurityOperators
branch
This was referenced Mar 28, 2023
Closed
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…perators' (Azure#23323) * Add autoAdd field to indicate sku should be included during creation (Azure#5849) * copy folder * Add autoAdd field * update readme * Add operation example * fix style Co-authored-by: Peter Shen <[email protected]> * Add previour Private PR for 2021-10-15-preview as a baseline * Update EventGrid.json with new features to be part of 2021-10-15-preview API * update readme file and add missing example files * fix typo * fix operation name for unauthorize * fix tag * New API version to Microsoft.Security 2023-01-01-preview * refactoring * Update readme * fix syntax error * Refactoring * Add pattern restriction * Fix readme * npm run prettier * Update naming in the examples * fix merge * merge fix * fix merge * fix merge * Update readme.md * Update readme.md --------- Co-authored-by: Peter Shen <[email protected]> Co-authored-by: Peter Shen <[email protected]> Co-authored-by: Ashraf Hamad <[email protected]> Co-authored-by: Daniel Dahan <[email protected]> Co-authored-by: Sivan Manor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.