Skip to content

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-04-01 #24111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weidongxu-microsoft merged 5 commits into from
May 26, 2023
Merged

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-04-01 #24111

weidongxu-microsoft merged 5 commits into from
May 26, 2023

Conversation

@ankur741999
Copy link
Contributor

@ankur741999 ankur741999 commented May 23, 2023 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented May 23, 2023

Hi, @ankur741999 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    registeredidentities.json 2023-04-01(0648a3f) 2023-02-01(main)
    registeredidentities.json 2023-04-01(0648a3f) 2022-09-30-preview(main)
    replicationusages.json 2023-04-01(0648a3f) 2023-02-01(main)
    replicationusages.json 2023-04-01(0648a3f) 2022-09-30-preview(main)
    vaults.json 2023-04-01(0648a3f) 2023-02-01(main)
    vaults.json 2023-04-01(0648a3f) 2022-09-30-preview(main)
    vaultusages.json 2023-04-01(0648a3f) 2023-02-01(main)
    vaultusages.json 2023-04-01(0648a3f) 2022-09-30-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-04 package-2023-04(0648a3f) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName} is missing.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L20
    ❌ ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L20
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/certificates/{certificateName}'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L21
    ❌ ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L21
    ❌ ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L21
    ❌ SubscriptionsAndResourceGroupCasing The path segment Subscriptions should be subscriptions.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L21
    ❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'VaultCertificates_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L22
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L64
    ❌ PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L64
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L64
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/registeredIdentities/{identityName}'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L80
    ❌ ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L80
    ❌ ResourceNameRestriction The resource name parameter 'identityName' should be defined with a 'pattern' restriction.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L80
    ❌ SubscriptionsAndResourceGroupCasing The path segment Subscriptions should be subscriptions.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L80
    ❌ DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L108
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L108
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L108
    ❌ NestedResourcesMustHaveListOperation The nested resource 'VaultCertificateResponse' does not have list operation, please add it.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L300
    ❌ XmsParameterLocation The parameter 'SubscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L327
    ❌ XmsParameterLocation The parameter 'ApiVersion' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/registeredidentities.json#L350
    ❌ PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/replicationUsages'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L21
    ❌ ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L21
    ❌ SubscriptionsAndResourceGroupCasing The path segment Subscriptions should be subscriptions.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L21
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L45
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L45
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L48
    ❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L70
    ❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L74
    ❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L78
    ❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.RecoveryServices/stable/2023-04-01/replicationusages.json#L88
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 29 Errors, 0 Warnings failed [Detail]

    Tag package-2023-04; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 20, untested: 0, failed: 11, passed: 9

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'locations/checkNameAvailability' could not be found in the namespace 'Microsoft.RecoveryServices' for api version '2023-04-01'. The supported api-versions are '2018-01-10'.
    Source: runtime
    OperationId: RecoveryServices_CheckNameAvailability
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identity
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sku
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Source: response
    OperationId: VaultExtendedInfo_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Source: response
    OperationId: VaultExtendedInfo_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identity
    Source: response
    OperationId: VaultExtendedInfo_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sku
    Source: response
    OperationId: VaultExtendedInfo_Get
    ❌ CLIENT_ERROR statusCode: 412,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: VaultExtendedInfo_Update
    ❌ INVALID_RESPONSE_BODY Body is required in response but not provided
    Source: response
    OperationId: VaultExtendedInfo_Update
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: VaultCertificates_Create
    ❌ INVALID_RESPONSE_CODE The swagger file does not define '400' response code
    Source: response
    OperationId: VaultCertificates_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: Could not perform the operation as VM no longer exists. Stop protecting virtual machine without deleting backup data. More details at http://go.microsoft.com/fwlink/?LinkId=808124
    Source: runtime
    OperationId: RegisteredIdentities_Delete
    ❌ INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: RegisteredIdentities_Delete
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: monitoringSummary
    Source: response
    OperationId: ReplicationUsages_List
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: jobsSummary
    Source: response
    OperationId: ReplicationUsages_List
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: protectedItemsSummary
    Source: response
    OperationId: ReplicationUsages_List
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: storageAccountsCountSummary
    Source: response
    OperationId: ReplicationUsages_List
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: protectedItemCount
    Source: response
    OperationId: ReplicationUsages_List
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: registeredServersCount
    Source: response
    OperationId: ReplicationUsages_List
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: recoveryPlanCount
    Source: response
    OperationId: ReplicationUsages_List
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.RecoveryServices/locations/capabilities/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: RecoveryServices_Capabilities
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: CloudInvalidInputError,
    errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support.
    Source: runtime
    OperationId: GetOperationResult
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: innerError
    Source: response
    OperationId: GetOperationResult
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: CloudInvalidInputError,
    errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support.
    Source: runtime
    OperationId: GetOperationStatus
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: innerError
    Source: response
    OperationId: GetOperationStatus
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkResources_Get
    ❌ INVALID_RESPONSE_BODY Body is required in response but not provided
    Source: response
    OperationId: PrivateLinkResources_Get
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e5b3623. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-recoveryservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model VaultProperties has a new parameter secure_score
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5b3623. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `CrossSubscriptionRestoreState` with values `CrossSubscriptionRestoreStateDisabled`, `CrossSubscriptionRestoreStateEnabled`, `CrossSubscriptionRestoreStatePermanentlyDisabled`
info	[Changelog] - New enum type `SecureScoreLevel` with values `SecureScoreLevelAdequate`, `SecureScoreLevelMaximum`, `SecureScoreLevelMinimum`, `SecureScoreLevelNone`
info	[Changelog] - New struct `CrossSubscriptionRestoreSettings`
info	[Changelog] - New struct `RestoreSettings`
info	[Changelog] - New field `RestoreSettings`, `SecureScore` in struct `VaultProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 14 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5b3623. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-recoveryservices [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface CrossSubscriptionRestoreSettings
info	[Changelog]   - Added Interface RestoreSettings
info	[Changelog]   - Added Type Alias CrossSubscriptionRestoreState
info	[Changelog]   - Added Type Alias SecureScoreLevel
info	[Changelog]   - Interface VaultProperties has a new optional parameter restoreSettings
info	[Changelog]   - Interface VaultProperties has a new optional parameter secureScore
info	[Changelog]   - Added Enum KnownCrossSubscriptionRestoreState
info	[Changelog]   - Added Enum KnownSecureScoreLevel
    ️❌ azure-resource-manager-schemas failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from e5b3623. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
Server Error
HttpError: Server Error
    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@[email protected][email protected]/node_modules/@octokit/request/dist-node/index.js:86:21
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async workflowPkgUpdatePR (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:377:9)
    at async Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:63:5)
    at async workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:216:9)
    at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:98:13)
    at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:191:13)
    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️recoveryservices [View full logs]  
      error	Fatal error: Server Error
error	The following packages are still pending:
error		recoveryservices
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from e5b3623. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.recoveryservices.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.recoveryservices.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the RecoveryServices label May 23, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/recoveryservices/armrecoveryservices https://apiview.dev/Assemblies/Review/130ae9ab95c84aefa89d95b2e60773b2
    Java azure-resourcemanager-recoveryservices https://apiview.dev/Assemblies/Review/715463c26b884d059e9bb3b13a04433f
    .Net Azure.ResourceManager.RecoveryServices https://apiview.dev/Assemblies/Review/70b657c1b04f4601a3e0e03e3e132a68
    JavaScript @azure/arm-recoveryservices https://apiview.dev/Assemblies/Review/8fbec89855ce4cc295e2f14172f6bec3

    @ankur741999 ankur741999 marked this pull request as ready for review May 23, 2023 13:15
    @azure-sdk azure-sdk mentioned this pull request May 23, 2023
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 23, 2023
    @azure-sdk azure-sdk mentioned this pull request May 23, 2023
    Closed
    This was referenced May 23, 2023
    Closed
    Closed
    @openapi-workflow-bot
    Copy link

    openapi-workflow-bot bot commented May 23, 2023

    Hi, @ankur741999 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    This was referenced May 23, 2023
    Closed
    Closed
    @visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 23, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 23, 2023
    @v-jiaodi v-jiaodi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 24, 2023
    @weidongxu-microsoft weidongxu-microsoft merged commit e5b3623 into main May 26, 2023
    @weidongxu-microsoft weidongxu-microsoft deleted the ankur741999-recoveryservices-Microsoft.RecoveryServices-2023-04-01 branch May 26, 2023 02:27
    This was referenced May 26, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @v-jiaodi v-jiaodi v-jiaodi approved these changes

    Assignees

    @v-jiaodi v-jiaodi

    Labels

    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test RecoveryServices resource-manager

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    6 participants

    @ankur741999 @v-jiaodi @weidongxu-microsoft @AzureRestAPISpecReview @visingla-ms