[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-06-01-preview #24388

jeevan-gaikwad · 2023-06-10T10:29:57Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…2023-04-01-preview to version 2023-06-01-preview

openapi-workflow-bot · 2023-06-10T10:30:00Z

Hi, @jeevan-gaikwad Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-06-10T10:30:02Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 3 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
dataprotection.json	2023-06-01-preview(e4a92d6)	2023-05-01(main)
dataprotection.json	2023-06-01-preview(e4a92d6)	2023-04-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L6029:11 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5920:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v4/managedidentity.json#L27:9 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5932:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v4/managedidentity.json#L21:9 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5937:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 3 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-preview-2023-06	package-preview-2023-06(e4a92d6)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'fetchsecondaryrecoverypoints' in:'SecondaryRPs_Fetch'. Consider updating the operationId Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L1552
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'fetchcrossregionrestorejob' in:'CrossRegionRestoreJob_Get'. Consider updating the operationId Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L1782
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'fetchcrossregionrestorejobs' in:'CrossRegionRestoreJobs_List'. Consider updating the operationId Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L1838

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ParametersOrder	The parameters:operationId,location should be kept in the same order as they present in the path. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L64
`❌` MissingTypeObject	The schema 'AzureBackupFindRestorableTimeRangesRequestResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L4339
`❌` MissingTypeObject	The schema 'AzureBackupFindRestorableTimeRangesResponseResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L4370
`❌` MissingTypeObject	The schema 'AzureBackupRecoveryPointResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L4670
`❌` MissingTypeObject	The schema 'BackupInstanceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L5113
`❌` MissingTypeObject	The schema 'BackupVaultResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L5301
`❌` MissingTypeObject	The schema 'BaseBackupPolicyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L5361
`❌` MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L5597
`❌` MissingTypeObject	The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L6314
`❌` MissingTypeObject	The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L6352
`❌` MissingTypeObject	The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L6618
`❌` MissingTypeObject	The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L6666
⚠️ DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L6
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get OperationStatus Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L228
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get OperationStatus Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L276
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'validaterestore' in:'BackupInstances_ValidateForRestore'. Consider updating the operationId Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L2427
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'findrestorabletimeranges' in:'RestorableTimeRanges_Find'. Consider updating the operationId Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L2553
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'exportbackupjobs' in:'ExportJobs_Trigger'. Consider updating the operationId Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L2662
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List OperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3324
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List OperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3376
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List OperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3428
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List OperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3480
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List OperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3532
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get DefaultOperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3642
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get DefaultOperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3697
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get DefaultOperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3752
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get DefaultOperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3807
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get DefaultOperationsRequestObject Location: Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json#L3862

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-10T10:30:03Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/dataprotection/armdataprotection - Approved - 3.0.0-beta.1

+	Type of `BaseResourceProperties.ObjectType` has been changed from `*string` to `*ResourcePropertiesObjectType`

❌azure-sdk-for-js - @azure/arm-dataprotection - Approved - 2.0.0-beta.1

+	Type of parameter objectType of interface BaseResourceProperties is changed from "BaseResourceProperties" to "DefaultResourceProperties"
+	Type of parameter resourceProperties of interface Datasource is changed from BaseResourceProperties to BaseResourcePropertiesUnion
+	Type of parameter resourceProperties of interface DatasourceSet is changed from BaseResourceProperties to BaseResourcePropertiesUnion

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7b6f247. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.DataProtectionBackup [View full logs] [Release SDK Changes]
- Azure.ResourceManager.DataProtectionBackup.1.3.0-alpha.20230925.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 7b6f247. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-dataprotection [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation BackupInstancesOperations.begin_trigger_cross_region_restore
info	[Changelog]   - Added operation BackupInstancesOperations.begin_validate_cross_region_restore
info	[Changelog]   - Added operation group BackupInstancesExtensionRoutingOperations
info	[Changelog]   - Added operation group CrossRegionRestoreJobOperations
info	[Changelog]   - Added operation group CrossRegionRestoreJobsOperations
info	[Changelog]   - Added operation group SecondaryRPsOperations
info	[Changelog]   - Model SecuritySettings has a new parameter encryption_settings

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 7b6f247. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-dataprotection [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7b6f247. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/dataprotection/armdataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `BaseResourceProperties.ObjectType` has been changed from `*string` to `*ResourcePropertiesObjectType`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `EncryptionState` with values `EncryptionStateDisabled`, `EncryptionStateEnabled`, `EncryptionStateInconsistent`
info	[Changelog] - New enum type `IdentityType` with values `IdentityTypeSystemAssigned`, `IdentityTypeUserAssigned`
info	[Changelog] - New enum type `InfrastructureEncryptionState` with values `InfrastructureEncryptionStateDisabled`, `InfrastructureEncryptionStateEnabled`
info	[Changelog] - New enum type `ResourcePropertiesObjectType` with values `ResourcePropertiesObjectTypeDefaultResourceProperties`
info	[Changelog] - New function `*BackupInstancesClient.BeginTriggerCrossRegionRestore(context.Context, string, string, CrossRegionRestoreRequestObject, *BackupInstancesClientBeginTriggerCrossRegionRestoreOptions) (*runtime.Poller[BackupInstancesClientTriggerCrossRegionRestoreResponse], error)`
info	[Changelog] - New function `*BackupInstancesClient.BeginValidateCrossRegionRestore(context.Context, string, string, ValidateCrossRegionRestoreRequestObject, *BackupInstancesClientBeginValidateCrossRegionRestoreOptions) (*runtime.Poller[BackupInstancesClientValidateCrossRegionRestoreResponse], error)`
info	[Changelog] - New function `NewBackupInstancesExtensionRoutingClient(azcore.TokenCredential, *arm.ClientOptions) (*BackupInstancesExtensionRoutingClient, error)`
info	[Changelog] - New function `*BackupInstancesExtensionRoutingClient.NewListPager(string, *BackupInstancesExtensionRoutingClientListOptions) *runtime.Pager[BackupInstancesExtensionRoutingClientListResponse]`
info	[Changelog] - New function `*ClientFactory.NewBackupInstancesExtensionRoutingClient() *BackupInstancesExtensionRoutingClient`
info	[Changelog] - New function `*ClientFactory.NewCrossRegionRestoreJobClient() *CrossRegionRestoreJobClient`
info	[Changelog] - New function `*ClientFactory.NewCrossRegionRestoreJobsClient() *CrossRegionRestoreJobsClient`
info	[Changelog] - New function `*ClientFactory.NewSecondaryRPsClient() *SecondaryRPsClient`
info	[Changelog] - New function `NewCrossRegionRestoreJobClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CrossRegionRestoreJobClient, error)`
info	[Changelog] - New function `*CrossRegionRestoreJobClient.Get(context.Context, string, string, CrossRegionRestoreJobRequest, *CrossRegionRestoreJobClientGetOptions) (CrossRegionRestoreJobClientGetResponse, error)`
info	[Changelog] - New function `NewCrossRegionRestoreJobsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CrossRegionRestoreJobsClient, error)`
info	[Changelog] - New function `*CrossRegionRestoreJobsClient.NewListPager(string, string, CrossRegionRestoreJobsRequest, *CrossRegionRestoreJobsClientListOptions) *runtime.Pager[CrossRegionRestoreJobsClientListResponse]`
info	[Changelog] - New function `*DefaultResourceProperties.GetBaseResourceProperties() *BaseResourceProperties`
info	[Changelog] - New function `NewSecondaryRPsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SecondaryRPsClient, error)`
info	[Changelog] - New function `*SecondaryRPsClient.NewFetchPager(string, string, FetchSecondaryRPsRequestParameters, *SecondaryRPsClientFetchOptions) *runtime.Pager[SecondaryRPsClientFetchResponse]`
info	[Changelog] - New struct `CmkKekIdentity`
info	[Changelog] - New struct `CmkKeyVaultProperties`
info	[Changelog] - New struct `CrossRegionRestoreDetails`
info	[Changelog] - New struct `CrossRegionRestoreJobRequest`
info	[Changelog] - New struct `CrossRegionRestoreJobsRequest`
info	[Changelog] - New struct `CrossRegionRestoreRequestObject`
info	[Changelog] - New struct `DefaultResourceProperties`
info	[Changelog] - New struct `EncryptionSettings`
info	[Changelog] - New struct `FetchSecondaryRPsRequestParameters`
info	[Changelog] - New struct `ValidateCrossRegionRestoreRequestObject`
info	[Changelog] - New field `EncryptionSettings` in struct `SecuritySettings`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 48 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7b6f247. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-dataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-dataprotection-2.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group BackupInstancesExtensionRouting
info	[Changelog]   - Added operation group CrossRegionRestoreJob
info	[Changelog]   - Added operation group CrossRegionRestoreJobs
info	[Changelog]   - Added operation group SecondaryRPs
info	[Changelog]   - Added operation BackupInstances.beginTriggerCrossRegionRestore
info	[Changelog]   - Added operation BackupInstances.beginTriggerCrossRegionRestoreAndWait
info	[Changelog]   - Added operation BackupInstances.beginValidateCrossRegionRestore
info	[Changelog]   - Added operation BackupInstances.beginValidateCrossRegionRestoreAndWait
info	[Changelog]   - Added Interface BackupInstancesExtensionRoutingListNextOptionalParams
info	[Changelog]   - Added Interface BackupInstancesExtensionRoutingListOptionalParams
info	[Changelog]   - Added Interface BackupInstancesTriggerCrossRegionRestoreHeaders
info	[Changelog]   - Added Interface BackupInstancesTriggerCrossRegionRestoreOptionalParams
info	[Changelog]   - Added Interface BackupInstancesValidateCrossRegionRestoreHeaders
info	[Changelog]   - Added Interface BackupInstancesValidateCrossRegionRestoreOptionalParams
info	[Changelog]   - Added Interface CmkKekIdentity
info	[Changelog]   - Added Interface CmkKeyVaultProperties
info	[Changelog]   - Added Interface CrossRegionRestoreDetails
info	[Changelog]   - Added Interface CrossRegionRestoreJobGetOptionalParams
info	[Changelog]   - Added Interface CrossRegionRestoreJobRequest
info	[Changelog]   - Added Interface CrossRegionRestoreJobsListNextOptionalParams
info	[Changelog]   - Added Interface CrossRegionRestoreJobsListOptionalParams
info	[Changelog]   - Added Interface CrossRegionRestoreJobsRequest
info	[Changelog]   - Added Interface CrossRegionRestoreRequestObject
info	[Changelog]   - Added Interface DefaultResourceProperties
info	[Changelog]   - Added Interface EncryptionSettings
info	[Changelog]   - Added Interface FetchSecondaryRPsRequestParameters
info	[Changelog]   - Added Interface SecondaryRPsFetchNextOptionalParams
info	[Changelog]   - Added Interface SecondaryRPsFetchOptionalParams
info	[Changelog]   - Added Interface ValidateCrossRegionRestoreRequestObject
info	[Changelog]   - Added Type Alias BackupInstancesExtensionRoutingListNextResponse
info	[Changelog]   - Added Type Alias BackupInstancesExtensionRoutingListResponse
info	[Changelog]   - Added Type Alias BackupInstancesTriggerCrossRegionRestoreResponse
info	[Changelog]   - Added Type Alias BackupInstancesValidateCrossRegionRestoreResponse
info	[Changelog]   - Added Type Alias BaseResourcePropertiesUnion
info	[Changelog]   - Added Type Alias CrossRegionRestoreJobGetResponse
info	[Changelog]   - Added Type Alias CrossRegionRestoreJobsListNextResponse
info	[Changelog]   - Added Type Alias CrossRegionRestoreJobsListResponse
info	[Changelog]   - Added Type Alias EncryptionState
info	[Changelog]   - Added Type Alias IdentityType
info	[Changelog]   - Added Type Alias InfrastructureEncryptionState
info	[Changelog]   - Added Type Alias ResourcePropertiesObjectType
info	[Changelog]   - Added Type Alias SecondaryRPsFetchNextResponse
info	[Changelog]   - Added Type Alias SecondaryRPsFetchResponse
info	[Changelog]   - Interface SecuritySettings has a new optional parameter encryptionSettings
info	[Changelog]   - Added Enum KnownEncryptionState
info	[Changelog]   - Added Enum KnownIdentityType
info	[Changelog]   - Added Enum KnownInfrastructureEncryptionState
info	[Changelog]   - Added Enum KnownResourcePropertiesObjectType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter objectType of interface BaseResourceProperties is changed from "BaseResourceProperties" to "DefaultResourceProperties"
info	[Changelog]   - Type of parameter resourceProperties of interface Datasource is changed from BaseResourceProperties to BaseResourcePropertiesUnion
info	[Changelog]   - Type of parameter resourceProperties of interface DatasourceSet is changed from BaseResourceProperties to BaseResourcePropertiesUnion

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 7b6f247. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.dataprotection.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.dataprotection.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-10T10:30:04Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/dataprotection/armdataprotection	https://apiview.dev/Assemblies/Review/9698ae48d23945b288f3b8693546d917
Java	azure-resourcemanager-dataprotection	https://apiview.dev/Assemblies/Review/c318473222f84bc68eb5b4f627dc0c3c
JavaScript	@azure/arm-dataprotection	https://apiview.dev/Assemblies/Review/b2133b85ad4543f8ba2a0bb8955bf143
.Net	Azure.ResourceManager.DataProtectionBackup	https://apiview.dev/Assemblies/Review/92aaf3f666c3483c89c5ea73151d7079

jeevan-gaikwad · 2023-06-10T11:05:02Z

This PR is created on top of existing approved PR #22359 with new api-version 2023-06-01-preview. We're also rolling out our resource provider Backup Vault manifest with this version. Added DoNotMerge label.

openapi-workflow-bot · 2023-06-10T11:29:10Z

Hi, @jeevan-gaikwad your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

jeevan-gaikwad · 2023-06-25T09:12:08Z

/azp run unifiedPipeline

azure-pipelines · 2023-06-25T09:12:13Z

No pipelines are associated with this pull request.

visingla-ms · 2023-09-21T13:20:26Z

      "$ref": "#/definitions/BaseResourceProperties",

I didn't understand the purpose of this field? What is being added as part of resourceProperties? I already see an objectType and resourceType fields here? #Resolved

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json:5756 in e4a92d6. [](commit_id = e4a92d6, deletion_comment = False)

jeevan-gaikwad · 2023-09-22T03:31:45Z

      "$ref": "#/definitions/BaseResourceProperties",
I didn't understand the purpose of this field? What is being added as part of resourceProperties? I already see an objectType and resourceType fields here?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json:5756 in e4a92d6. [](commit_id = e4a92d6, deletion_comment = False)

This change is part of stable API version 2023-05-01
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json
So not sure why it was added.

jeevan-gaikwad · 2023-09-22T03:37:27Z

      "type": "string"
Please respond to this comment.

In reply to: 1728095105

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/preview/2023-06-01-preview/dataprotection.json:4090 in c5829d7. [](commit_id = c5829d7, deletion_comment = False)

This change is also part of stable API version 2023-05-01

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json

visingla-ms · 2023-09-22T15:31:17Z

BaseResourceProperties

In that case, this PR should have been created with most recent stable API version as base, not last preview API Version.

jeevan-gaikwad · 2023-09-22T17:59:39Z

@rkmanda please guide about the following required labels:

jeevan-gaikwad · 2023-09-25T11:11:39Z

/pr RequestMerge

openapi-pipeline-app · 2023-09-25T12:58:23Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…rsion preview/2023-06-01-preview (#24388) * Adds base for updating Microsoft.DataProtection from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Updated Encryption Settings for Backup Vault specs * Prettier fix * synced with stable version 2023-05-01 * prettier fix * resynced with preview 2023-04-01-preview --------- Co-authored-by: Jeevan Gaikwad <[email protected]>

jeevan-gaikwad and others added 4 commits June 10, 2023 15:47

Adds base for updating Microsoft.DataProtection from version preview/…

0d73ef4

…2023-04-01-preview to version 2023-06-01-preview

Updates readme

f64349c

Updates API version in new specs and examples

0ef6679

Updated Encryption Settings for Backup Vault specs

bfc3b73

AzureRestAPISpecReview added new-api-version resource-manager labels Jun 10, 2023

jeevan-gaikwad marked this pull request as ready for review June 10, 2023 10:59

openapi-assignment-bot bot assigned Wzb123456789 Jun 10, 2023

jeevan-gaikwad requested a review from amchandn June 10, 2023 10:59

jeevan-gaikwad added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 10, 2023

Prettier fix

c8b2318

jeevan-gaikwad added the ARMReview label Jun 10, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2023

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jun 10, 2023

zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 12, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 12, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jun 25, 2023

visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 21, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 21, 2023

jeevan-gaikwad added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 22, 2023

kazrael2119 removed the Approved-SdkBreakingChange-JavaScript label Sep 22, 2023

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 22, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023

msyyc added the Approved-SdkBreakingChange-Python label Sep 25, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 25, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Sep 25, 2023

github-actions bot added the MergeRequested label Sep 25, 2023

visingla-ms approved these changes Sep 25, 2023

View reviewed changes

visingla-ms merged commit 7b6f247 into main Sep 25, 2023

visingla-ms deleted the jeevan-gaikwad-dataprotection-Microsoft.DataProtection-2023-06-01-preview-cmk branch September 25, 2023 12:58

openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 25, 2023

jeevan-gaikwad mentioned this pull request Feb 21, 2024

Adding new API version for Microsoft.DataProtection (2024-03-01) #27833

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-06-01-preview #24388

[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-06-01-preview #24388

jeevan-gaikwad commented Jun 10, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jun 10, 2023

openapi-pipeline-app bot commented Jun 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 10, 2023 •

edited

Loading

jeevan-gaikwad commented Jun 10, 2023

openapi-workflow-bot bot commented Jun 10, 2023

jeevan-gaikwad commented Jun 25, 2023

azure-pipelines bot commented Jun 25, 2023

visingla-ms commented Sep 21, 2023 •

edited

Loading

jeevan-gaikwad commented Sep 22, 2023 •

edited

Loading

jeevan-gaikwad commented Sep 22, 2023

visingla-ms commented Sep 22, 2023

jeevan-gaikwad commented Sep 22, 2023

jeevan-gaikwad commented Sep 25, 2023

openapi-pipeline-app bot commented Sep 25, 2023

[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-06-01-preview #24388

[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-06-01-preview #24388

Conversation

jeevan-gaikwad commented Jun 10, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 10, 2023

openapi-pipeline-app bot commented Jun 10, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 10, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 10, 2023 • edited Loading

Generated ApiView

jeevan-gaikwad commented Jun 10, 2023

openapi-workflow-bot bot commented Jun 10, 2023

jeevan-gaikwad commented Jun 25, 2023

azure-pipelines bot commented Jun 25, 2023

visingla-ms commented Sep 21, 2023 • edited Loading

jeevan-gaikwad commented Sep 22, 2023 • edited Loading

jeevan-gaikwad commented Sep 22, 2023

visingla-ms commented Sep 22, 2023

jeevan-gaikwad commented Sep 22, 2023

jeevan-gaikwad commented Sep 25, 2023

openapi-pipeline-app bot commented Sep 25, 2023

jeevan-gaikwad commented Jun 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2023 •

edited

Loading

visingla-ms commented Sep 21, 2023 •

edited

Loading

jeevan-gaikwad commented Sep 22, 2023 •

edited

Loading