Skip to content

convert overlay vpa enabled from bool to enum #24761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huizhifan wants to merge 1 commit into from
Closed

convert overlay vpa enabled from bool to enum #24761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...ce/resource-manager/Microsoft.ContainerService/aks/stable/2023-06-01/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6239,9 +6239,25 @@
"description": "VPA (Vertical Pod Autoscaler) settings for the workload auto-scaler profile.",
"properties": {
"enabled": {
"type": "boolean",
"type": "string",
"enum": [
"true",
"false"
],
"x-ms-enum": {
Copy link
Member

@matthchr matthchr Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO there is no value in doing this in an enum. Just tell the Swagger reviewer we have a pattern of using boolean for addon enablement and they will let us through.

"name": "Enabled",
"modelAsString": true,
"values": [
{
"value": "true"
},
{
"value": "false"
}
]
},
"description": "Whether to enable VPA. Default value is false.",
"default": false
"default": "false"
}
},
"required": [
Expand Down