GalleryRP 2022-08-03 release branch #25524

Sandido · 2023-08-24T20:51:41Z

ARM (Control Plane) API Specification Update Pull Request

Moved the release code from this PR: #24661

This PR has the CI-MissingBaseCommit because the tool that creates the release PRs automatically cannot handle an API with multiple RPs as it only migrates one of them. I manually made the base commits.
These new features are going into this release. They have been previously reviewed by ARM, but please go ahead and re-review:

Edits based on ARM comments:

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-24T20:51:44Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-08-24T20:51:45Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 19 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
communityGallery.json	2022-08-03(de0750e)	2022-03-03(main)
gallery.json	2022-08-03(de0750e)	2022-03-03(main)
gallery.json	2022-08-03(de0750e)	2020-09-30(main)
galleryRPCommon.json	2022-08-03(de0750e)	2022-03-03(main)
sharedGallery.json	2022-08-03(de0750e)	2022-03-03(main)
sharedGallery.json	2022-08-03(de0750e)	2020-09-30(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'LocationNameParamter' removed or renamed? New: azure-rest-api-specs/blob/de0750ef914c893a7ce2a7d4185153e5362a87f4/revision#L1087:2 Old: GalleryRP/preview/2020-09-30/sharedGallery.json#L762:3
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L1780:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L1736:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2364:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2106:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2422:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2251:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2729:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2439:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2078:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L1917:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: GalleryRP/stable/2022-08-03/gallery.json#L2729:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2439:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'uri' renamed or removed? New: GalleryRP/stable/2022-08-03/gallery.json#L2750:7 Old: GalleryRP/preview/2020-09-30/gallery.json#L2456:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'uri' renamed or removed? New: GalleryRP/stable/2022-08-03/gallery.json#L2764:7 Old: GalleryRP/preview/2020-09-30/gallery.json#L2456:7
⚠️ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: GalleryRP/stable/2022-08-03/gallery.json#L1780:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L1736:9
⚠️ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: GalleryRP/stable/2022-08-03/gallery.json#L2364:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2106:9
⚠️ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: GalleryRP/stable/2022-08-03/gallery.json#L2422:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2251:9
⚠️ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: GalleryRP/stable/2022-08-03/gallery.json#L2078:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L1917:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2022-08-03	package-2022-08-03(de0750e)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'publicGalleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'publicGalleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L79
`❌` ResourceNameRestriction	The resource name parameter 'galleryImageName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L79
`❌` ResourceNameRestriction	The resource name parameter 'publicGalleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L124
`❌` ResourceNameRestriction	The resource name parameter 'galleryImageName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L124
`❌` ResourceNameRestriction	The resource name parameter 'galleryImageVersionName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L124
`❌` ResourceNameRestriction	The resource name parameter 'publicGalleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L172
`❌` ResourceNameRestriction	The resource name parameter 'publicGalleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L217
`❌` ResourceNameRestriction	The resource name parameter 'galleryImageName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L217
`❌` MissingTypeObject	The schema 'PirCommunityGalleryResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L267
`❌` MissingTypeObject	The schema 'CommunityGalleryIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L309
`❌` MissingTypeObject	The schema 'CommunityGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L353
`❌` MissingTypeObject	The schema 'CommunityGalleryImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L403
`❌` MissingTypeObject	The schema 'CommunityGalleryImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L417
`❌` MissingTypeObject	The schema 'CommunityGalleryImageVersion' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L528
`❌` MissingTypeObject	The schema 'CommunityGalleryImageVersionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L542
`❌` MissingTypeObject	The schema 'CommunityGalleryImageIdentifier' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: GalleryRP/stable/2022-08-03/communityGallery.json#L571
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/gallery.json#L37
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: GalleryRP/stable/2022-08-03/gallery.json#L38
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-08-03/gallery.json#L84
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: GalleryRP/stable/2022-08-03/gallery.json#L93
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: GalleryRP/stable/2022-08-03/gallery.json#L113
`❌` LroPatch202	The async patch operation should return 202. Location: GalleryRP/stable/2022-08-03/gallery.json#L146
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: GalleryRP/stable/2022-08-03/gallery.json#L156
`❌` ParametersInPointGet	Query parameter $select should be removed. Point Get's MUST not have query parameters other than api version. Location: GalleryRP/stable/2022-08-03/gallery.json#L173
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: GalleryRP/stable/2022-08-03/gallery.json#L173
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: GalleryRP/stable/2022-08-03/gallery.json#L237
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: GalleryRP/stable/2022-08-03/gallery.json#L265
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: GalleryRP/stable/2022-08-03/gallery.json#L274
`❌` ResourceNameRestriction	The resource name parameter 'galleryName' should be defined with a 'pattern' restriction. Location: GalleryRP/stable/2022-08-03/gallery.json#L286

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-08-03

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-24T20:51:45Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 14836c9f8a1b6dcd9169c9156ffc7aa80f0ba684. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Compute [View full logs] [Preview SDK Changes] Breaking Change Detected

Azure.ResourceManager.Compute.1.3.0-alpha.20231011.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.CommunityGalleryImageVersionData Azure.ResourceManager.Compute.Models.ArmComputeModelFactory.CommunityGalleryImageVersionData(System.String, System.Nullable<Azure.Core.AzureLocation>, System.Nullable<Azure.Core.ResourceType>, System.String, System.Nullable<System.DateTimeOffset>, System.Nullable<System.DateTimeOffset>, System.Nullable<System.Boolean>, Azure.ResourceManager.Compute.Models.SharedGalleryImageVersionStorageProfile)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.GalleryImageVersionData Azure.ResourceManager.Compute.Models.ArmComputeModelFactory.GalleryImageVersionData(Azure.Core.ResourceIdentifier, System.String, Azure.Core.ResourceType, Azure.ResourceManager.Models.SystemData, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.Core.AzureLocation, Azure.ResourceManager.Compute.Models.GalleryImageVersionPublishingProfile, System.Nullable<Azure.ResourceManager.Compute.Models.GalleryProvisioningState>, Azure.ResourceManager.Compute.Models.GalleryImageVersionStorageProfile, Azure.ResourceManager.Compute.Models.GalleryImageVersionSafetyProfile, Azure.ResourceManager.Compute.Models.ReplicationStatus)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.SharedGalleryData Azure.ResourceManager.Compute.Models.ArmComputeModelFactory.SharedGalleryData(System.String, System.Nullable<Azure.Core.AzureLocation>, System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.SharedGalleryImageData Azure.ResourceManager.Compute.Models.ArmComputeModelFactory.SharedGalleryImageData(System.String, System.Nullable<Azure.Core.AzureLocation>, System.String, System.Nullable<Azure.ResourceManager.Compute.Models.SupportedOperatingSystemType>, System.Nullable<Azure.ResourceManager.Compute.Models.OperatingSystemStateType>, System.Nullable<System.DateTimeOffset>, Azure.ResourceManager.Compute.Models.GalleryImageIdentifier, Azure.ResourceManager.Compute.Models.RecommendedMachineConfiguration, System.Collections.Generic.IEnumerable<System.String>, System.Nullable<Azure.ResourceManager.Compute.Models.HyperVGeneration>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Compute.Models.GalleryImageFeature>, Azure.ResourceManager.Compute.Models.ImagePurchasePlan, System.Nullable<Azure.ResourceManager.Compute.Models.ArchitectureType>, System.Uri, System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.SharedGalleryImageVersionData Azure.ResourceManager.Compute.Models.ArmComputeModelFactory.SharedGalleryImageVersionData(System.String, System.Nullable<Azure.Core.AzureLocation>, System.String, System.Nullable<System.DateTimeOffset>, System.Nullable<System.DateTimeOffset>, System.Nullable<System.Boolean>, Azure.ResourceManager.Compute.Models.SharedGalleryImageVersionStorageProfile)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 14836c9f8a1b6dcd9169c9156ffc7aa80f0ba684. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation

️⌛ azure-sdk-for-java pending [Detail]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 14836c9f8a1b6dcd9169c9156ffc7aa80f0ba684. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]

azure-arm-compute-21.3.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface CommunityGalleryMetadata
info	[Changelog]   - Added Interface GalleryImageVersionUefiSettings
info	[Changelog]   - Added Interface ImageVersionSecurityProfile
info	[Changelog]   - Added Interface UefiKey
info	[Changelog]   - Added Interface UefiKeySignatures
info	[Changelog]   - Added Type Alias UefiKeyType
info	[Changelog]   - Added Type Alias UefiSignatureTemplateName
info	[Changelog]   - Interface CommunityGallery has a new optional parameter artifactTags
info	[Changelog]   - Interface CommunityGallery has a new optional parameter communityMetadata
info	[Changelog]   - Interface CommunityGallery has a new optional parameter disclaimer
info	[Changelog]   - Interface CommunityGalleryImage has a new optional parameter artifactTags
info	[Changelog]   - Interface CommunityGalleryImage has a new optional parameter disclaimer
info	[Changelog]   - Interface CommunityGalleryImageVersion has a new optional parameter artifactTags
info	[Changelog]   - Interface CommunityGalleryImageVersion has a new optional parameter disclaimer
info	[Changelog]   - Interface GalleryImageVersion has a new optional parameter securityProfile
info	[Changelog]   - Interface GalleryImageVersionUpdate has a new optional parameter securityProfile
info	[Changelog]   - Interface SharedGallery has a new optional parameter artifactTags
info	[Changelog]   - Interface SharedGalleryImage has a new optional parameter artifactTags
info	[Changelog]   - Interface SharedGalleryImageVersion has a new optional parameter artifactTags
info	[Changelog]   - Added Enum KnownUefiKeyType
info	[Changelog]   - Added Enum KnownUefiSignatureTemplateName
info	[Changelog]   - Enum KnownConfidentialVMEncryptionType has a new value NonPersistedTPM
info	[Changelog]   - Enum KnownReplicationStatusTypes has a new value UefiSettings

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 14836c9f8a1b6dcd9169c9156ffc7aa80f0ba684. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ConfidentialVMEncryptionTypeNonPersistedTPM` added to enum type `ConfidentialVMEncryptionType`
info	[Changelog] - New value `ReplicationStatusTypesUefiSettings` added to enum type `ReplicationStatusTypes`
info	[Changelog] - New enum type `UefiKeyType` with values `UefiKeyTypeSHA256`, `UefiKeyTypeX509`
info	[Changelog] - New enum type `UefiSignatureTemplateName` with values `UefiSignatureTemplateNameMicrosoftUefiCertificateAuthorityTemplate`, `UefiSignatureTemplateNameMicrosoftWindowsTemplate`, `UefiSignatureTemplateNameNoSignatureTemplate`
info	[Changelog] - New struct `CommunityGalleryMetadata`
info	[Changelog] - New struct `CommunityGalleryProperties`
info	[Changelog] - New struct `GalleryImageVersionUefiSettings`
info	[Changelog] - New struct `ImageVersionSecurityProfile`
info	[Changelog] - New struct `SharedGalleryProperties`
info	[Changelog] - New struct `UefiKey`
info	[Changelog] - New struct `UefiKeySignatures`
info	[Changelog] - New field `Properties` in struct `CommunityGallery`
info	[Changelog] - New field `ArtifactTags`, `Disclaimer` in struct `CommunityGalleryImageProperties`
info	[Changelog] - New field `ArtifactTags`, `Disclaimer` in struct `CommunityGalleryImageVersionProperties`
info	[Changelog] - New field `SecurityProfile` in struct `GalleryImageVersionProperties`
info	[Changelog] - New field `Properties` in struct `SharedGallery`
info	[Changelog] - New field `ArtifactTags` in struct `SharedGalleryImageProperties`
info	[Changelog] - New field `ArtifactTags` in struct `SharedGalleryImageVersionProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 30 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 14836c9f8a1b6dcd9169c9156ffc7aa80f0ba684. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Preview Schema Changes]

️🔄 azure-powershell inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-24T20:51:46Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	https://apiview.dev/Assemblies/Review/cffaffe0ee4543eebe9f42a669d7151e
.Net	Azure.ResourceManager.Compute	https://apiview.dev/Assemblies/Review/611f52f435ed4d6380996ccf841c908e
JavaScript	@azure/arm-compute	Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Swagger	Microsoft.Compute	https://apiview.dev/Assemblies/Review/a4acee61b1a549618c3c7c793a41b5d6

openapi-workflow-bot · 2023-08-24T20:58:54Z

Hi @Sandido! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

* changes * prettier

…unity gallery (#25659) * all discalimer and previous arm updates * cleanup * prettier

...compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/communityGallery.json

tiregan · 2023-09-21T18:31:14Z

    "type": {
This helps avoid confusion with the common 'type' property appearing on most ARM resources.

In reply to: 1718451158

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/gallery.json:3234 in b602206. [](commit_id = b602206, deletion_comment = False)

This would require code changes

tiregan · 2023-09-21T18:32:52Z

      "x-ms-identifiers": []
doesn't 'dbx' imply a list of unique items with distinct names or ids?

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/gallery.json:3226 in b602206. [](commit_id = b602206, deletion_comment = False)

This type doesn't really have that. The value would be unique but it is an array of strings so I don't think it belongs in x-ms-identifiers

tiregan · 2023-09-21T18:37:03Z

    "dbx": {
is there some reason for calling them 'pk', 'kek', 'db', 'dbx' instead of more friendly names?

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/gallery.json:3220 in d22af1c. [](commit_id = d22af1c, deletion_comment = False)

This is how their specified in APIs across other services as well and they're commonly referred to in this way in documentation.

TimLovellSmith · 2023-09-26T16:02:12Z

/azp run

azure-pipelines · 2023-09-26T16:02:26Z

Azure Pipelines successfully started running 2 pipeline(s).

TimLovellSmith · 2023-09-26T16:02:50Z

      "x-ms-identifiers": []

shouldn't you specify an identifying property here?

In reply to: 1718452994

Refers to: specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/gallery.json:3218 in d22af1c. [](commit_id = d22af1c, deletion_comment = False)

.../compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/galleryRPCommon.json

* update * update

openapi-pipeline-app · 2023-10-11T18:49:27Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.

TimLovellSmith

Sandido · 2023-10-18T17:20:54Z

Adding ARMSignedOff label since Tim approved the PR, and mentioned it in our email thread.

Sandido · 2023-11-28T15:34:12Z

/pr RequestMerge

Sandido added 2 commits August 24, 2023 16:33

copied over old api version

6d00fad

api version update

b602206

azure-sdk mentioned this pull request Aug 24, 2023

[AutoPR sdk/resourcemanager/compute/armcompute] GalleryRP 2022-08-03 release branch azure-sdk/azure-sdk-for-go#7073

Closed

AzureRestAPISpecReview added CI-MissingBaseCommit new-api-version resource-manager labels Aug 24, 2023

Sandido added 3 commits August 24, 2023 17:19

modelvalidation and br cleanup

1a4f2dd

CVM TDX and Custom UEFI Keys (#25661)

7a11a69

* changes * prettier

Add 'artifactTags' and 'disclaimer' field for shared gallery and comm…

d22af1c

…unity gallery (#25659) * all discalimer and previous arm updates * cleanup * prettier

Sandido marked this pull request as ready for review September 5, 2023 23:02

Sandido requested review from dkulkarni-ms, haagha, MS-syh2qs and grizzlytheodore as code owners September 5, 2023 23:02

openapi-assignment-bot bot assigned rkmanda Sep 5, 2023

AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 5, 2023

mentat9 reviewed Sep 7, 2023

View reviewed changes

...compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/communityGallery.json Show resolved Hide resolved

mentat9 reviewed Sep 7, 2023

View reviewed changes

...compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/communityGallery.json Show resolved Hide resolved

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2023

Sandido mentioned this pull request Sep 14, 2023

Add uri format to CommunityGalleryMetadata #25794

Merged

6 tasks

kangsun-ctrl and others added 2 commits September 14, 2023 11:14

'update' (#25769)

d7076e7

uri format (#25794)

79a8753

Sandido added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Sep 14, 2023

Sandido mentioned this pull request Sep 14, 2023

Addressing ARM comments for TDX and UEFI features #25800

Draft

6 tasks

rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 16, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2023

TimLovellSmith reviewed Sep 26, 2023

View reviewed changes

.../compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-08-03/galleryRPCommon.json Show resolved Hide resolved

Address ARM reviewer comment for community gallery (#25803)

de0750e

* update * update

TimLovellSmith approved these changes Oct 11, 2023

View reviewed changes

Sandido added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 18, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 18, 2023

microsoft-github-policy-service bot added no-recent-activity labels Nov 6, 2023

Sandido removed the no-recent-activity label Nov 16, 2023

microsoft-github-policy-service bot added the MergeRequested label Nov 28, 2023

rkmanda approved these changes Nov 28, 2023

View reviewed changes

rkmanda merged commit a4d77e0 into main Nov 28, 2023

rkmanda deleted the feature/cplat-2022-08-03-merge branch November 28, 2023 19:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GalleryRP 2022-08-03 release branch #25524

GalleryRP 2022-08-03 release branch #25524

Sandido commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 24, 2023

tiregan commented Sep 21, 2023

tiregan commented Sep 21, 2023

tiregan commented Sep 21, 2023

TimLovellSmith commented Sep 26, 2023

azure-pipelines bot commented Sep 26, 2023

TimLovellSmith commented Sep 26, 2023

openapi-pipeline-app bot commented Oct 11, 2023

TimLovellSmith left a comment

Sandido commented Oct 18, 2023

Sandido commented Nov 28, 2023

GalleryRP 2022-08-03 release branch #25524

GalleryRP 2022-08-03 release branch #25524

Conversation

Sandido commented Aug 24, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Aug 24, 2023

tiregan commented Sep 21, 2023

tiregan commented Sep 21, 2023

tiregan commented Sep 21, 2023

TimLovellSmith commented Sep 26, 2023

azure-pipelines bot commented Sep 26, 2023

TimLovellSmith commented Sep 26, 2023

openapi-pipeline-app bot commented Oct 11, 2023

Next Steps to Merge

TimLovellSmith left a comment

Choose a reason for hiding this comment

Sandido commented Oct 18, 2023

Sandido commented Nov 28, 2023

Sandido commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading