Meja/swagger changes for mi #25790

jmegha123 · 2023-09-14T09:38:02Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-14T09:38:06Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

openapi-pipeline-app · 2023-09-14T09:38:07Z

Swagger Validation Report

️❌BreakingChange: 9 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
networkWatcher.json	2023-05-01(bf8b5fa)	2023-05-01(main)

Rule	Message
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'FlowLogInformation' removed or renamed? New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L2343:3 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L2343:3
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1140:13 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1140:13
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1155:13 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1155:13
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1161:13 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1161:13
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1225:13 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1225:13
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1231:13 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1231:13
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L3341:7 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L3250:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L3168:7 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L3107:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'identity' that was not found in the old version. New: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L3168:7 Old: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L3107:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-05	package-2023-05(bf8b5fa)	package-2023-05(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 14 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L177:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L769:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherPacketCaptureDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L830:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherPacketCaptureStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1704:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherConnectionMonitorDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1829:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherConnectionMonitorStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1890:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherConnectionMonitorStart.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L2264:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherFlowLogDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L177:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L769:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherPacketCaptureDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L830:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherPacketCaptureStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1704:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherConnectionMonitorDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1829:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherConnectionMonitorStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L1890:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherConnectionMonitorStart.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2023-05-01/networkWatcher.json#L2264:22 ExampleUrl: stable/2023-05-01/examples/NetworkWatcherFlowLogDelete.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-14T09:38:08Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/network/armnetwork - 5.0.0

+	Field `FlowLogInformation` of struct `WatchersClientGetFlowLogStatusResponse` has been removed
+	Field `FlowLogInformation` of struct `WatchersClientSetFlowLogConfigurationResponse` has been removed
+	Function `*WatchersClient.BeginSetFlowLogConfiguration` parameter(s) have been changed from `(context.Context, string, string, FlowLogInformation, *WatchersClientBeginSetFlowLogConfigurationOptions)` to `(context.Context, string, string, FlowLogInformationRequest, *WatchersClientBeginSetFlowLogConfigurationOptions)`
+	Struct `FlowLogInformation` has been removed

❌azure-sdk-for-js - @azure/arm-network - 33.0.0

+	Operation NetworkWatchers.beginSetFlowLogConfiguration has a new signature
+	Operation NetworkWatchers.beginSetFlowLogConfigurationAndWait has a new signature

️❌ azure-sdk-for-net failed [Detail]

❌Code Generator Failed [Logs] Generate from c29c339. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ResourceIdentityType' and different values: UserAssigned,None vs. SystemAssigned,UserAssigned,SystemAssigned, UserAssigned,None
cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
cmderr	[Autorest]    at NewPlugin.<Process>d15.MoveNext()
cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from c29c339. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes] Breaking Change Detected

Azure.ResourceManager.Network.1.5.0-alpha.20230915.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.FlowLogInformation> Azure.ResourceManager.Network.NetworkWatcherResource.SetFlowLogConfiguration(Azure.WaitUntil, Azure.ResourceManager.Network.Models.FlowLogInformation, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.FlowLogInformation>> Azure.ResourceManager.Network.NetworkWatcherResource.SetFlowLogConfigurationAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.FlowLogInformation, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.BastionHostData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.BastionHostData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, System.Nullable<Azure.ETag>, System.Nullable<Azure.ResourceManager.Network.Models.BastionHostSkuName>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.BastionHostIPConfiguration>, System.String, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<System.Int32>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.FirewallPolicyData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.FirewallPolicyData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, System.Nullable<Azure.ETag>, Azure.ResourceManager.Models.ManagedServiceIdentity, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Nullable<Azure.ResourceManager.Network.Models.AzureFirewallThreatIntelMode>, Azure.ResourceManager.Network.Models.FirewallPolicyThreatIntelWhitelist, Azure.ResourceManager.Network.Models.FirewallPolicyInsights, Azure.ResourceManager.Network.Models.FirewallPolicySnat, System.Nullable<System.Boolean>, Azure.ResourceManager.Network.Models.DnsSettings, Azure.ResourceManager.Network.Models.FirewallPolicyExplicitProxy, Azure.ResourceManager.Network.Models.FirewallPolicyIntrusionDetection, Azure.ResourceManager.Network.Models.FirewallPolicyCertificateAuthority, System.Nullable<Azure.ResourceManager.Network.Models.FirewallPolicySkuTier>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.FirewallPolicyRuleCollectionGroupData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.FirewallPolicyRuleCollectionGroupData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.Nullable<System.Int32>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.FirewallPolicyRuleCollectionInfo>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.FlowLogData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.FlowLogData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, System.Nullable<Azure.ETag>, Azure.Core.ResourceIdentifier, System.Nullable<System.Guid>, Azure.Core.ResourceIdentifier, System.Nullable<System.Boolean>, Azure.ResourceManager.Network.Models.RetentionPolicyParameters, Azure.ResourceManager.Network.Models.FlowLogProperties, Azure.ResourceManager.Network.Models.TrafficAnalyticsConfigurationProperties, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.SubnetData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.SubnetData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.String, System.Collections.Generic.IEnumerable<System.String>, Azure.ResourceManager.Network.NetworkSecurityGroupData, Azure.ResourceManager.Network.RouteTableData, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceEndpointProperties>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.ServiceEndpointPolicyData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.PrivateEndpointData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfiguration>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfigurationProfile>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ResourceNavigationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceAssociationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceDelegation>, System.String, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateEndpointNetworkPolicy>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateLinkServiceNetworkPolicy>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ApplicationGatewayIPConfiguration>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.VirtualNetworkGatewayData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.VirtualNetworkGatewayData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.ResourceManager.Resources.Models.ExtendedLocation, System.Nullable<Azure.ETag>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayIPConfiguration>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnGatewayGeneration>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, Azure.Core.ResourceIdentifier, Azure.ResourceManager.Network.Models.VirtualNetworkGatewaySku, Azure.ResourceManager.Network.Models.VpnClientConfiguration, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayPolicyGroup>, Azure.ResourceManager.Network.Models.BgpSettings, System.Collections.Generic.IEnumerable<System.String>, System.Nullable<System.Guid>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<System.Boolean>, System.String, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.VirtualNetworkGatewayNatRuleData>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<Azure.ResourceManager.Network.Models.ExpressRouteGatewayAdminState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.FlowLogInformation' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from c29c339. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-network [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model BastionHost has a new parameter network_acls
info	[Changelog]   - Model BastionHost has a new parameter virtual_network
info	[Changelog]   - Model FirewallPolicy has a new parameter size
info	[Changelog]   - Model FirewallPolicyRuleCollectionGroup has a new parameter size
info	[Changelog]   - Model FlowLog has a new parameter identity
info	[Changelog]   - Model Subnet has a new parameter default_outbound_access
info	[Changelog]   - Model VirtualNetworkGateway has a new parameter auto_scale_configuration

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from c29c339. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from c29c339. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*WatchersClient.BeginSetFlowLogConfiguration` parameter(s) have been changed from `(context.Context, string, string, FlowLogInformation, *WatchersClientBeginSetFlowLogConfigurationOptions)` to `(context.Context, string, string, FlowLogInformationRequest, *WatchersClientBeginSetFlowLogConfigurationOptions)`
info	[Changelog] - Struct `FlowLogInformation` has been removed
info	[Changelog] - Field `FlowLogInformation` of struct `WatchersClientGetFlowLogStatusResponse` has been removed
info	[Changelog] - Field `FlowLogInformation` of struct `WatchersClientSetFlowLogConfigurationResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `BastionHostPropertiesFormatNetworkACLs`
info	[Changelog] - New struct `FlowLogInformationRequest`
info	[Changelog] - New struct `FlowLogInformationResponse`
info	[Changelog] - New struct `IPRule`
info	[Changelog] - New struct `RequestIdentityObjectForUserAssigned`
info	[Changelog] - New struct `ResultIdentityObjectForUserAssigned`
info	[Changelog] - New struct `UserIdentityProperties`
info	[Changelog] - New struct `VirtualNetworkGatewayAutoScaleBounds`
info	[Changelog] - New struct `VirtualNetworkGatewayAutoScaleConfiguration`
info	[Changelog] - New field `NetworkACLs`, `VirtualNetwork` in struct `BastionHostPropertiesFormat`
info	[Changelog] - New field `Size` in struct `FirewallPolicyPropertiesFormat`
info	[Changelog] - New field `Size` in struct `FirewallPolicyRuleCollectionGroupProperties`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `DefaultOutboundAccess` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `AutoScaleConfiguration` in struct `VirtualNetworkGatewayPropertiesFormat`
info	[Changelog] - New anonymous field `FlowLogInformationResponse` in struct `WatchersClientGetFlowLogStatusResponse`
info	[Changelog] - New anonymous field `FlowLogInformationResponse` in struct `WatchersClientSetFlowLogConfigurationResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 26 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from c29c339. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-network-33.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface BastionHostPropertiesFormatNetworkAcls
info	[Changelog]   - Added Interface FlowLogInformationRequest
info	[Changelog]   - Added Interface FlowLogInformationResponse
info	[Changelog]   - Added Interface IPRule
info	[Changelog]   - Added Interface RequestIdentityObjectForUserAssigned
info	[Changelog]   - Added Interface ResultIdentityObjectForUserAssigned
info	[Changelog]   - Added Interface UserIdentityProperties
info	[Changelog]   - Added Interface VirtualNetworkGatewayAutoScaleBounds
info	[Changelog]   - Added Interface VirtualNetworkGatewayAutoScaleConfiguration
info	[Changelog]   - Interface BastionHost has a new optional parameter networkAcls
info	[Changelog]   - Interface BastionHost has a new optional parameter virtualNetwork
info	[Changelog]   - Interface FirewallPolicy has a new optional parameter size
info	[Changelog]   - Interface FirewallPolicyRuleCollectionGroup has a new optional parameter size
info	[Changelog]   - Interface FlowLog has a new optional parameter identity
info	[Changelog]   - Interface Subnet has a new optional parameter defaultOutboundAccess
info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter autoScaleConfiguration
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation NetworkWatchers.beginSetFlowLogConfiguration has a new signature
info	[Changelog]   - Operation NetworkWatchers.beginSetFlowLogConfigurationAndWait has a new signature

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from c29c339. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.network.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.network.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-14T09:38:09Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/b9770eeba5a442f1961fb8197e7ef00a
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/84c83999842d4243972e14ff7989bc2c
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/a6c252ef4e8e428c89556e34629c6e42
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/0cd2333b9020458d913bd4b2e2efd875
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/071166629eed4a16b1f0aa2642e85343

mikeharder · 2023-09-15T06:14:25Z

/azp run

azure-pipelines · 2023-09-15T06:14:36Z

Azure Pipelines successfully started running 2 pipeline(s).

jmegha123 added 2 commits September 14, 2023 14:57

Swagger changes for UserAssignedIndentites

4be948a

correcting json

9467841

azure-sdk mentioned this pull request Sep 14, 2023

[AutoPR sdk/resourcemanager/network/armnetwork] Meja/swagger changes for mi azure-sdk/azure-sdk-for-go#7279

Closed

AzureRestAPISpecReview added NewApiVersionRequired resource-manager labels Sep 14, 2023

Changes

a2f7a6f

azure-sdk mentioned this pull request Sep 14, 2023

[AutoPR network/resource-manager] Meja/swagger changes for mi azure-sdk/azure-resource-manager-schemas#3233

Draft

AzureRestAPISpecReview removed the NewApiVersionRequired label Sep 14, 2023

jmegha123 added 3 commits September 14, 2023 22:34

Making changes for swagger build fix

f42f61d

changes

2f13c9e

changes

bf8b5fa

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 14, 2023

openapi-pipeline-app bot added CI-BreakingChange-Go CI-BreakingChange-JavaScript labels Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meja/swagger changes for mi #25790

Meja/swagger changes for mi #25790

jmegha123 commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

mikeharder commented Sep 15, 2023

azure-pipelines bot commented Sep 15, 2023

Meja/swagger changes for mi #25790

Are you sure you want to change the base?

Meja/swagger changes for mi #25790

Conversation

jmegha123 commented Sep 14, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 14, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 14, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 14, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 14, 2023 • edited Loading

Generated ApiView

mikeharder commented Sep 15, 2023

azure-pipelines bot commented Sep 15, 2023

jmegha123 commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2023 •

edited

Loading