Skip to content

Add ResiliencyPolicy to VMSS API #26497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wenhuan-zhai-msft
Copy link
Contributor

@wenhuan-zhai-msft wenhuan-zhai-msft commented Oct 31, 2023

This is about to abort. Will move to feature/Cplat-2023-09-01

Copy link

openapi-pipeline-app bot commented Oct 31, 2023

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Oct 31, 2023

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️🔄Avocado inProgress [Detail]
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Oct 31, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking



️🔄 azure-sdk-for-net-track2 inProgress [Detail]
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️🔄 azure-sdk-for-java inProgress [Detail]
️🔄 azure-sdk-for-js inProgress [Detail]
️🔄 azure-sdk-for-go inProgress [Detail]
️🔄 azure-resource-manager-schemas inProgress [Detail]
️🔄 azure-powershell inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Oct 31, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute https://apiview.dev/Assemblies/Review/da9d7f071bc84a69a50b2fcbf8b25af0
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/1c55f827f8e04723b93862041add6510
.Net Azure.ResourceManager.Compute https://apiview.dev/Assemblies/Review/d482d7895f364b1792f31a0114b428a0
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/f93facf7cf7d41b7be172cb26fb0b185
Swagger Microsoft.Compute https://apiview.dev/Assemblies/Review/153d4cf89149462b9446ffa562743476

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 31, 2023
Copy link
Contributor

Thank you for your contribution wenhuan-zhai-msft! We will review the pull request and get back to you soon.

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

This was referenced Nov 6, 2023
@wenhuan-zhai-msft wenhuan-zhai-msft marked this pull request as draft November 6, 2023 19:09
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cadl Authored with Cadl data-plane RPaaS SuppressionReviewRequired and removed NewApiVersionRequired labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cadl Authored with Cadl CI-BreakingChange-Go customer-reported Issues that are reported by GitHub users external to the Azure organization. data-plane resource-manager RPaaS SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants