-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update alertsSuppressionRules.json #26567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
alertsSuppressionRules.json | 2019-01-01-preview(24140e8) | 2019-01-01-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2019-01-preview-only | package-2019-01-preview-only(24140e8) | package-2019-01-preview-only(main) |
package-composite-v1 | package-composite-v1(24140e8) | package-composite-v1(main) |
package-composite-v2 | package-composite-v2(24140e8) | package-composite-v2(main) |
package-dotnet-sdk | package-dotnet-sdk(24140e8) | package-dotnet-sdk(main) |
package-composite-v3 | package-composite-v3(24140e8) | package-composite-v3(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82 |
ResourceNameRestriction |
The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82 |
ResourceNameRestriction |
The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82 |
ResourceNameRestriction |
The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82 |
ResourceNameRestriction |
The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120 |
DeleteResponseCodes |
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160 |
DeleteResponseCodes |
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160 |
DeleteResponseCodes |
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160 |
DeleteResponseCodes |
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160 |
DeleteResponseCodes |
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160 |
DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297 |
The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6 |
|
The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6 |
|
The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6 |
|
The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6 |
|
The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
fixing doc of MDC alerts suppression API.
expiry time parameter has no limitation.
previous doc was wrong, fixing now to match actual logic