Kushalmehrotra713 migrate microsoft.migrate 2023 04 01 preview diff pr #27009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion stable/2023-03-15 to version 2023-04-01-preview
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/67fef25dec4a1cfc008811014e6ce0919664a657/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/stable/2023-03-15/migrate.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.66/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp -------------------- 2: ERROR: Referenced file 'file:///mnt/vss/work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/WebAppCollectorOperations_Delete_MaximumSetGen.json' not found -------------------- 3: - file:///mnt/vss/work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json:3724:12 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Migrate/assessmentProjects/projectName/webappcollectors/collectorName"].delete["x-ms-examples"].WebAppCollectorOperations_Delete_MaximumSetGen["$ref"]) -------------------- 4: FATAL: swagger-document/loader - FAILED -------------------- 5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting. -------------------- 6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. --------------------" |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/67fef25dec4a1cfc008811014e6ce0919664a657/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2017-11-11-preview/migrate.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.66/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp -------------------- 2: ERROR: Referenced file 'file:///mnt/vss/work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/WebAppCollectorOperations_Delete_MaximumSetGen.json' not found -------------------- 3: - file:///mnt/vss/work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json:3724:12 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Migrate/assessmentProjects/projectName/webappcollectors/collectorName"].delete["x-ms-examples"].WebAppCollectorOperations_Delete_MaximumSetGen["$ref"]) -------------------- 4: FATAL: swagger-document/loader - FAILED -------------------- 5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting. -------------------- 6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. --------------------" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 276 Errors, 11 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-04 | package-preview-2023-04(67fef25) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 22 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksOptionsOperations_ListByAssessmentProject_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L190 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksOptionsOperations_Get_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L245 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksAssessmentOperations_ListByAssessmentProject_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L325 |
|
|
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L368 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksAssessmentOperations_Get_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L380 |
|
|
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L391 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
|
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L430 |
|
|
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L436 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksAssessmentOperations_Create_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L459 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksAssessmentOperations_Delete_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L512 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AssessedWebApplicationOperations_ListByAksAssessment_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L600 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AssessedWebApplicationOperations_Get_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L663 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksClusterOperations_ListByAksAssessment_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L728 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksClusterOperations_Get_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L791 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksCostDetailOperations_ListByAksAssessment_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L856 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksAssessmentOperations_DownloadUrl_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L938 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksSummaryOperations_ListByAksAssessment_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L996 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksSummaryOperations_Get_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1059 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/BusinessCaseOperations_ListByAssessmentProject_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1109 |
|
|
provisioningState property must be set to readOnly. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1152 |
|
|
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/BusinessCaseOperations_Get_MaximumSet_Gen.json . Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1164 |
|
|
The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1175 |
RPC-Put-V1-28, RPC-Patch-V1-12 |
The following errors/warnings exist before current PR submission:
Only 22 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L4658 |
|
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L10770 |
|
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L12665 |
|
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L12741 |
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L4407 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L4411 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L4804 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L4876 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L5135 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L5696 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L5708 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L5724 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6045 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6057 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6079 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6211 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6258 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6321 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6333 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6483 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6754 |
|
| Schema should have a description or title. Location: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L9957 |
️❌Avocado: 117 Errors, 0 Warnings failed [Detail]
Only 22 items are listed, please refer to log for more details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/67fef25dec4a1cfc008811014e6ce0919664a657/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json" |
|
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/67fef25dec4a1cfc008811014e6ce0919664a657/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json" |
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksOptionsOperations_ListByAssessmentProject_MaximumSet_Gen.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/examples/AksOptionsOperations_ListByAssessmentProject_MaximumSet_Gen.json' JsonUrl: AssessmentProjects/preview/2023-04-01-preview/migrate.json |
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SpellCheck: 32 Errors, 0 Warnings failed [Detail]
Only 22 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Unknown word (businesscases), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1065:134 |
|
Unknown word (businesscases), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1115:134 |
|
Unknown word (businesscases), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1302:134 |
|
Unknown word (avssummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1302:167 |
|
Unknown word (businesscases), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1360:134 |
|
Unknown word (avssummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L1360:167 |
|
Unknown word (iaassummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L2193:167 |
|
Unknown word (iaassummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L2251:167 |
|
Unknown word (overviewsummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L2314:167 |
|
Unknown word (overviewsummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L2372:167 |
|
Unknown word (paassummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L2435:167 |
|
Unknown word (paassummaries), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L2493:167 |
|
Unknown word (webappcollectors), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L3492:134 |
|
Unknown word (webappcollectors), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L3542:134 |
|
Unknown word (wacc), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L6161:10 |
|
Unknown word (Datacentre), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L10936:10 |
|
Unknown word (Datacentre), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L10949:22 |
|
Unknown word (Datacentre), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L10950:23 |
|
Unknown word (Datacentre), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L10951:29 |
|
Unknown word (decomission), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L11049:10 |
|
Unknown word (decomission), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L12040:10 |
|
Unknown word (Decommisioned), please fix the error or add words to ./custom-words.txt path: AssessmentProjects/preview/2023-04-01-preview/migrate.json#L12075:31 |
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=401933&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from c9b6c084353ea91b1f20b0af2b418c7ab54554ed. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m
❌Azure.ResourceManager.Migrate [View full logs] [Preview SDK Changes]info [Changelog]
️❌ azure-sdk-for-go failed [Detail]
❌Code Generator Failed [Logs] Generate from c9b6c084353ea91b1f20b0af2b418c7ab54554ed. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json cmderr [generator automation-v2] [ERROR] total 1 error(s): cmderr [generator automation-v2] [ERROR] failed to execute `go generate` '�[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate�[0m cmderr [generator automation-v2] [ERROR] Cannot find go module under resourcemanager/migrate/armmigrate, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate cmderr [generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate cmderr [generator automation-v2] [ERROR] ##[command]Executing autorest.go in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate cmderr [generator automation-v2] [ERROR] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/migrate/armmigrate --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md cmderr [generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v16.20.2] cmderr [generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation. cmderr [generator automation-v2] [ERROR] https://aka.ms/autorest cmderr [generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1). cmderr [generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest cmderr [generator automation-v2] [ERROR] info | Loading AutoRest core '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.10.1) cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/go' (4.0.0-preview.60 -> 4.0.0-preview.60) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/go' (4.0.0-preview.60->4.0.0-preview.60) cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2) cmderr [generator automation-v2] [ERROR] error | [Exception] No input files provided. cmderr [generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation cmderr [generator automation-v2] [ERROR] error | Error: [Exception] No input files provided. cmderr [generator automation-v2] [ERROR] Use --help to get help information or see https://aka.ms/autorest/cli for additional documentation cmderr [generator automation-v2] [ERROR] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmderr [generator automation-v2] [ERROR] ##[error]Error running autorest.go cmderr [generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1 cmderr [generator automation-v2] [ERROR] ': exit status 1 error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2 warn Skip package processing as generation is failed
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from c9b6c084353ea91b1f20b0af2b418c7ab54554ed. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.5 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.5> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cannot force update branch 'sdkAuto/27009/migrate' as it is the current HEAD of the repository. Error: cannot force update branch 'sdkAuto/27009/migrate' as it is the current HEAD of the repository.
️✔️migrate [View full logs] [Preview Schema Changes]️✔️migrate [View full logs]error Fatal error: cannot force update branch 'sdkAuto/27009/migrate' as it is the current HEAD of the repository. error The following packages are still pending: error migrate error migrate
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from c9b6c084353ea91b1f20b0af2b418c7ab54554ed. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.migrate.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.migrate.DefaultTag
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-MissingBaseCommit
new-api-version
resource-manager
TypeSpec
|
Hi @kushalmehrotra713! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Dec 8, 2023
kushalmehrotra713
added
DoNotMerge
ajaygit158
reviewed
Dec 10, 2023
...esource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json
Show resolved
Hide resolved
ajaygit158
reviewed
Dec 10, 2023
...esource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json
Show resolved
Hide resolved
ajaygit158
reviewed
Dec 10, 2023
...esource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json
Show resolved
Hide resolved
ajaygit158
reviewed
Dec 10, 2023
...esource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json
Show resolved
Hide resolved
ajaygit158
reviewed
Dec 10, 2023
| }, | ||
| { | ||
| "name": "StandardE48DsV4", | ||
| "value": "Standard_E4 |
There was a problem hiding this comment.
Have better naming differentiation for WebAppType and WebAppTypes
There was a problem hiding this comment.
@tanvidhope-microsoft
Can we rename WebAppType to WebAppV2Type?
ajaygit158
reviewed
Dec 10, 2023
| }, | ||
| { | ||
| "name": "StandardE48DsV4", | ||
| "value": "Standard_E4 |
There was a problem hiding this comment.
Fix description for webAppSkuSize and webAppSkuName
There was a problem hiding this comment.
@tanvidhope-microsoft to take the change
ajaygit158
reviewed
Dec 10, 2023
| }, | ||
| { | ||
| "name": "StandardE48DsV4", | ||
| "value": "Standard_E4 |
There was a problem hiding this comment.
Check all field descriptions in this object
There was a problem hiding this comment.
I think description is missing because of a lot of possible values for this enum.
can you please confirm if its required (must add) or recommended (can be skipped) by ARM to add descriptions for all values of enums or models in the generated swagger?
@tanvidhope-microsoft for taking the change.
ajaygit158
added
the
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Casing seems to be off in multiple places not sure if its intentional ? Refers to: specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json:1115 in 67fef25. [](commit_id = 67fef25, deletion_comment = False) |
Should it be AksSummaryOperations_List instead ? Refers to: specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json:946 in 67fef25. [](commit_id = 67fef25, deletion_comment = False) |
Should it be AksSummaryOperations_List instead of AksSummaryOperations_ListByAksAssessment ? Refers to: specification/migrate/resource-manager/Microsoft.Migrate/AssessmentProjects/preview/2023-04-01-preview/migrate.json:1304 in 67fef25. [](commit_id = 67fef25, deletion_comment = False) |
I think we don't require user to supply any kind of request body in this POST call for downloading report. But when we used tsp to define the endpoint, it added an empty request body object. |
This operationId is autogenerated by tsp (typespec), we are listing down or GET ALL Summary by the parent resource, which is AKS Assessment, that's why its appending ListByAKSAssessment as suffix. |
although this refers to |
|
@AzureRestAPISpecReview here also, this PR doesn't contain a single TypeSpec file. Why is this labeled TypeSpec? |
|
@AzureRestAPISpecReview I removed the TypeSpec label as this PR does not contain any TypeSpec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.