-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Generate Storage TSP files #27221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Generate Storage TSP files #27221
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/72b017ae777c059f100e537abe6b354e4c099484/specification/storage/resource-manager/Microsoft.Storage/stable/2022-09-01/openapi.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storage/resource-manager/Microsoft.Storage/stable/2022-09-01/openapi.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.71/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/storage/resource-manager/Microsoft.Storage/stable/2022-09-01/openapi.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp -------------------- 2: ERROR: Schema violation: Missing required property: name -------------------- 3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2022-09-01/openapi.json:10335:10 ($.definitions.VirtualNetworkRule.properties.action["x-ms-enum"]) -------------------- 4: ERROR: Schema violation: Missing required property: name -------------------- 5: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2022-09-01/openapi.json:9252:10 ($.definitions.StorageAccountCheckNameAvailabilityParameters.properties.type["x-ms-enum"]) -------------------- 6: ERROR: Schema violation: Missing required property: name --------------------" |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️❌
CredScan: 0 Errors, 0 Warnings failed [Detail]
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
default | default(72b017a) | default(main) |
️❌
Avocado: 19 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.Storage/stable/2022-09-01/examples |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: resource-manager/Microsoft.Storage/stable/2022-09-01 |
UNREFERENCED_JSON_FILE |
The swagger JSON file is not referenced from the readme file. readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/locations/{}/providers/Microsoft.Storage/deletedAccounts/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/abortHierarchicalNamespaceMigration is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/blobServices/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/blobServices/default/containers/{}/immutabilityPolicies/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/blobServices/default/containers/{}/immutabilityPolicies/default/extendImmutabilityPolicy is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/blobServices/default/containers/{}/immutabilityPolicies/default/lockImmutabilityPolicy is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/blobServices/default/containers/{}/objectLevelWorm is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/fileServices/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/hierarchicalNamespaceMigration is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/inventoryPolicies/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/listAccountSAS is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/listServiceSAS is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/managementPolicies/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/privateLinkResources/{}/{}/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/queueServices/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Storage/storageAccounts/{}/tableServices/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/storage/resource-manager/readme.md json: Microsoft.Storage/stable/2022-09-01/openapi.json |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 93 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️❌
SemanticValidation: 5 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
INTERNAL_ERROR |
Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/storage/common-types/resource-management/v3/types.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/storage/common-types/resource-management/v3/types.json' JsonUrl: Microsoft.Storage/stable/2022-09-01/openapi.json |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: swagger JsonUrl: specification/storage/Storage.Management/resources.json |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: info JsonUrl: specification/storage/Storage.Management/resources.json |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: paths JsonUrl: specification/storage/Storage.Management/resources.json |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: Resources JsonUrl: specification/storage/Storage.Management/resources.json |
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
SpellCheck: 5 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (timeto), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Storage/stable/2022-09-01/openapi.json#L6189:10 |
HowToFix |
Unknown word (timeto), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Storage/stable/2022-09-01/openapi.json#L6205:10 |
HowToFix |
Unknown word (doesn), please fix the error. See https://aka.ms/ci-fix#spell-check path: specification/storage/Storage.Management/resources.json#L1:29159 |
HowToFix |
Unknown word (timeto), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Storage/stable/2022-09-01/openapi.json#L5624:10 |
HowToFix |
Unknown word (timeto), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Storage/stable/2022-09-01/openapi.json#L5640:10 |
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌
PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=406404&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌
azure-sdk-for-net-track2 failed [Detail]
❌
Failed [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn specification/storage/Storage.Management/tsp-output/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m
❌
Azure.ResourceManager.Storage [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️
azure-sdk-for-python-track2 warning [Detail]
⚠️
Warning [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/storage/Storage.Management/tsp-output/tspconfig.yaml skipped due to azure-sdk-for-python-track2 not found in tspconfig.yaml command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice warn No file changes detected after generation warn No package detected after generation
️⚠️
azure-sdk-for-java warning [Detail]
⚠️
Warning [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] Time Current cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 063k cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] ############################ 100.0% cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️
azure-resourcemanager-storage-generated [View full logs] [Preview SDK Changes]
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json warn specification/storage/Storage.Management/tsp-output/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
sdk/resourcemanager/storage/armstorage [View full logs] [Preview SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json cmderr [automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
️✔️
@azure/arm-storage [View full logs] [Preview SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️
azure-resource-manager-schemas warning [Detail]
⚠️
Warning [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
️✔️
storage [View full logs]
️️✔️
azure-powershell succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from 31e76ea08eb2146e0e5991dd8cc0fafdd0213888. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json warn specification/storage/Storage.Management/tsp-output/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️
Az.storage.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
|
Hi @dvbb! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
Hi @dvbb This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP. |
Hi, @dvbb, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReview
label.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.