Jmegha123 network microsoft.network 2024 01 01 preview #27332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applicationGateway.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| applicationGatewayWafDynamicManifests.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| applicationSecurityGroup.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| availableDelegations.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| availableServiceAliases.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| azureFirewall.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| azureFirewallFqdnTag.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| azureWebCategory.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| bastionHost.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| checkDnsAvailability.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| cloudServiceNetworkInterface.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| cloudServicePublicIpAddress.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| cloudServiceSwap.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| customIpPrefix.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| ddosCustomPolicy.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| ddosProtectionPlan.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| dscpConfiguration.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| endpointService.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| expressRouteCircuit.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| expressRouteCrossConnection.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| expressRoutePort.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| expressRouteProviderPort.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| firewallPolicy.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| ipAllocation.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| ipGroups.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| loadBalancer.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| natGateway.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| network.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| network.json | 2024-01-01-preview(610b750) | 2023-08-01-preview(main) |
| networkInterface.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManager.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManager.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerActiveConfiguration.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerActiveConfiguration.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerConnection.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerConnection.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerConnectivityConfiguration.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerConnectivityConfiguration.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerEffectiveConfiguration.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerEffectiveConfiguration.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerGroup.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerGroup.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerScopeConnection.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerScopeConnection.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkManagerSecurityAdminConfiguration.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkManagerSecurityAdminConfiguration.json | 2024-01-01-preview(610b750) | 2022-04-01-preview(main) |
| networkProfile.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkSecurityGroup.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkVirtualAppliance.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| networkWatcher.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| operation.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| privateEndpoint.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| privateLinkService.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| publicIpAddress.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| publicIpPrefix.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| routeFilter.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| routeTable.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| securityPartnerProvider.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| serviceCommunity.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| serviceEndpointPolicy.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| serviceTags.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| usage.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| virtualNetwork.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| virtualNetworkGateway.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| virtualNetworkTap.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| virtualRouter.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| virtualWan.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| vmssNetworkInterface.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| vmssPublicIpAddress.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
| webapplicationfirewall.json | 2024-01-01-preview(610b750) | 2023-09-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 12 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L418:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listActiveSecurityUserRules' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L143:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L240:5 |
|
| The new version is missing a definition that was found in the old version. Was 'EffectiveVirtualNetworksParameter' removed or renamed? New: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L422:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L476:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveSecurityUserRule' removed or renamed? New: Microsoft.Network/preview/2024-01-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveDefaultSecurityUserRule' removed or renamed? New: Microsoft.Network/preview/2024-01-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DefaultUserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/preview/2024-01-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'UserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/preview/2024-01-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L504:11 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L558:11 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L576:9 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L625:9 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L613:11 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L661:11 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L676:9 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L724:9 |
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️🔄LintDiff inProgress [Detail]
️❌Avocado: 48 Errors, 6 Warnings failed [Detail]
Only 12 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The API version of the swagger is inconsistent with its file path. readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2024-01-01-preview/vmssNetworkInterface.json |
|
The API version of the swagger is inconsistent with its file path. readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2024-01-01-preview/vmssPublicIpAddress.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/expressRouteCircuits/{}/ is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/expressRouteCircuits/{}arpTable is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/expressRouteCircuits/{}routesTable is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/expressRouteCircuits/{}stats is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/localNetworkGateways/{}/ is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/microsoft.compute/virtualMachineScaleSets/{}/virtualMachines/{}/networkInterfaces is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/microsoft.compute/virtualMachineScaleSets/{}/networkInterfaces is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/microsoft.compute/virtualMachineScaleSets/{}/virtualMachines/{}/networkInterfaces/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/publicIPAddresses/{}/ is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/virtualnetworks/{}/subnets/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/network/resource-manager/readme.md json: Microsoft.Network/preview/2015-05-01-preview/network.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 472 Errors, 0 Warnings failed [Detail]
Only 12 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SpellCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unknown word (Conditon), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Network/preview/2024-01-01-preview/webapplicationfirewall.json#L705:18 |
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-net-track2 failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️⚠️ azure-sdk-for-python-track2 warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️⚠️ azure-sdk-for-java warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️🔄 azure-resource-manager-schemas inProgress [Detail]
️⚠️ azure-powershell warning [Detail]
Only 0 items are rendered, please refer to log for more details.
Generated ApiView
|
This was referenced Jan 10, 2024
|
Hi @jmegha123! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.