Skip to content

Update typespec for ApplicationInsights LiveMetrics #28320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TimothyMothra wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Update typespec for ApplicationInsights LiveMetrics #28320

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5dfe00a
Update tspconfig.yaml - testing csharp
Mar 19, 2024
ac36df0
Merge branch 'main' into TimothyMothra-patch-1
JackTn Mar 25, 2024
71dec0e
testing changes to models
Mar 26, 2024
203c19b
regenerate swagger
Mar 27, 2024
954dc0c
Merge branch 'main' into TimothyMothra-patch-1
Mar 27, 2024
b38875f
Merge branch 'main' into TimothyMothra-patch-1
Apr 4, 2024
9c567d3
Merge branch 'main' into TimothyMothra-patch-1
Apr 4, 2024
df3a876
Merge branch 'main' into TimothyMothra-patch-1
Apr 5, 2024
c721f49
Merge branch 'main' into TimothyMothra-patch-1
Apr 12, 2024
5e0da64
Merge branch 'main' into TimothyMothra-patch-1
May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/applicationinsights/ApplicationInsights.LiveMetrics/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ model Request extends DocumentIngress {

@doc("Request URL with all query string parameters.")
@maxLength(2048)
Url?: url;
Url?: string;

@doc("Result of a request execution. For http requests, it could be some HTTP status code.")
@maxLength(1024)
Expand Down Expand Up @@ -390,7 +390,7 @@ model KeyValuePairStringString {
key: string;

@doc("Value of the key-value pair.")
value: string;
value?: string;
Copy link
Member

@mikekistler mikekistler Apr 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change. I saw your explanation in the PR description (BTW thank you for this -- I see many PRs that lack this kind of explanation):

This change makes the value property settable

But this should not be dependent on whether the property is required or optional. Making the value property optional means that a key-value-pair that only contains a key is valid -- which makes no sense to me.

Copy link
Author

@TimothyMothra TimothyMothra May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with my team, we'll remove this change.

}

/**
Expand Down
4 changes: 2 additions & 2 deletions specification/applicationinsights/ApplicationInsights.LiveMetrics/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ options:
package-mode: dataplane
flavor: azure
"@azure-tools/typespec-csharp":
package-dir: "LiveMetrics"
package-dir: "Azure.Monitor.OpenTelemetry.LiveMetrics"
namespace: "{package-dir}"
clear-output-folder: true
model-namespace: false
model-namespace: true
flavor: azure
"@azure-tools/typespec-ts":
package-dir: "livemetrics-rest"
Expand Down
4 changes: 1 addition & 3 deletions ...on/applicationinsights/data-plane/LiveMetrics/preview/2024-04-01-preview/livemetrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,8 +626,7 @@
}
},
"required": [
"key",
"value"
"key"
]
},
"MetricPoint": {
Expand Down Expand Up @@ -892,7 +891,6 @@
},
"Url": {
"type": "string",
"format": "uri",
"description": "Request URL with all query string parameters.",
"maxLength": 2048
},
Expand Down