Skip to content

Aurghob/ndsswaggerfix #30223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Aurghob/ndsswaggerfix #30223

wants to merge 5 commits into from

Conversation

aurghob
Copy link
Contributor

@aurghob aurghob commented Aug 15, 2024

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 15, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 15, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Swagger Language https://apiview.dev/Assemblies/Review/d940fcb06e874adebca52d9bf9e40221?revisionId=bccae8aa407d4892aa38876401999b6a

@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch Awaiting requested review from annatisch annatisch will be requested when the pull request is marked ready for review annatisch is a code owner

@heaths heaths Awaiting requested review from heaths heaths will be requested when the pull request is marked ready for review heaths is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen will be requested when the pull request is marked ready for review deyaaeldeen is a code owner

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico will be requested when the pull request is marked ready for review kristapratico is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga will be requested when the pull request is marked ready for review joseharriaga is a code owner

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan will be requested when the pull request is marked ready for review minhanh-phan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Cognitive - Language Cognitive Services data-plane VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurghob @AzureRestAPISpecReview